use chai, err needs to be null, not just undefined

Rakefile

@@ -78,7 +78,7 @@ namespace :test do
   MOCHA      = "./node_modules/.bin/mocha"
   COVERALLS  = "./node_modules/.bin/coveralls"
 
-  OPTS = "--compilers coffee:coffee-script/register --ui exports"
+  OPTS = "--compilers coffee:coffee-script/register --ui exports --bail"
 
   desc "Run code coverage, mocha with Blanket.js"
   task :coverage do

package.json

@@ -40,6 +40,7 @@
   "devDependencies": {
     "blanket": "~1.1.6",
     "browserify": "~6.2.0",
+    "chai": "^1.9.2",
     "coffee-script": "~1.8.0",
     "coffeeify": "~0.7.0L",
     "coveralls": "~2.11.2",

src/modules/github/issues.coffee

@@ -13,6 +13,7 @@ module.exports =
       _.partial(oneStatus, repo, 'open')
       _.partial(oneStatus, repo, 'closed')
     ], (err, [ open, closed ]) ->
+      err ?= null
       cb err, { open, closed }
 
 # Calculate size of either open or closed issues.

test/issues.coffee

@@ -1,5 +1,5 @@
-assert = require 'assert'
-moment = require 'moment'
+{ assert } = require 'chai'
+moment     = require 'moment'
 
 request = require '../src/modules/github/request.coffee'
 issues  = require '../src/modules/github/issues.coffee'
@@ -14,7 +14,7 @@ module.exports =
 
     # ISO 8601 dates are in UTC timezone.
     utc = do moment(json[0].created_at).toDate().toUTCString
-    assert.equal utc, 'Fri, 22 Apr 2011 13:33:48 GMT'
+    assert utc, 'Fri, 22 Apr 2011 13:33:48 GMT'
 
     do done
 
@@ -27,10 +27,10 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 2
-      assert.equal open.size, 0
-      assert.equal closed.size, 0
+      assert.isNull err
+      assert called, 2
+      assert.strictEqual open.size, 0
+      assert.strictEqual closed.size, 0
       do done
 
   'issues - open empty': (done) ->
@@ -44,12 +44,12 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 2
-      assert.equal open.size, 0
-      assert.equal open.list.length, 0
-      assert.equal closed.size, 1
-      assert.equal closed.list.length, 1
+      assert.isNull err
+      assert called, 2
+      assert.strictEqual open.size, 0
+      assert.strictEqual open.list.length, 0
+      assert closed.size, 1
+      assert closed.list.length, 1
       do done
 
   'issues - closed empty': (done) ->
@@ -63,10 +63,10 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 2
-      assert.equal open.size, 1
-      assert.equal closed.size, 0
+      assert.isNull err
+      assert called, 2
+      assert open.size, 1
+      assert.strictEqual closed.size, 0
       do done
 
   'issues - both not empty': (done) ->
@@ -78,10 +78,10 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 2
-      assert.equal open.size, 1
-      assert.equal closed.size, 1
+      assert.isNull err
+      assert called, 2
+      assert open.size, 1
+      assert closed.size, 1
       do done
 
   'issues - 99 results on a page': (done) ->
@@ -93,10 +93,10 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 2
-      assert.equal open.size, 99
-      assert.equal closed.size, 99
+      assert.isNull err
+      assert called, 2
+      assert open.size, 99
+      assert closed.size, 99
       do done
 
   'issues - 100 results on a page': (done) ->
@@ -109,10 +109,10 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 4
-      assert.equal open.size, 100
-      assert.equal closed.size, 100
+      assert.isNull err
+      assert called, 4
+      assert open.size, 100
+      assert closed.size, 100
       do done
 
   'issues - 101 total results': (done) ->
@@ -128,10 +128,10 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 4
-      assert.equal open.size, 101
-      assert.equal closed.size, 101
+      assert.isNull err
+      assert called, 4
+      assert open.size, 101
+      assert closed.size, 101
       assert.deepEqual open.list[100], { number: 100, size: 1 }
       assert.deepEqual closed.list[100], { number: 100, size: 1 }
       do done
@@ -149,10 +149,10 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal called, 6
-      assert.equal open.size, 201
-      assert.equal closed.size, 201
+      assert.isNull err
+      assert called, 6
+      assert open.size, 201
+      assert closed.size, 201
       for { list } in [ open, closed ]
         for j in [ 100, 200 ]
           assert.deepEqual list[j], { number: j, size: 1 }
@@ -167,8 +167,8 @@ module.exports =
     config.set 'chart.points', 'ONE_SIZE'
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.equal err, 'Not Found'
-      assert.equal called, 1
+      assert err, 'Not Found'
+      assert called, 1
       do done
 
   'issues - size based on a label': (done) ->
@@ -182,9 +182,9 @@ module.exports =
       ]
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal open.size, 12
-      assert.equal open.list[0].size, 2
+      assert.isNull err
+      assert open.size, 12
+      assert open.list[0].size, 2
       do done
 
   'issues - filter when no labels': (done) ->
@@ -194,8 +194,8 @@ module.exports =
       cb null, [ { } ]
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal open.size, 0
+      assert.isNull err
+      assert.strictEqual open.size, 0
       do done  
 
   'issues - filter when empty labels': (done) ->
@@ -205,8 +205,8 @@ module.exports =
       cb null, [ { labels: [] } ]
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal open.size, 0
+      assert.isNull err
+      assert.strictEqual open.size, 0
       do done 
 
   'issues - filter when not matching regex': (done) ->
@@ -216,8 +216,8 @@ module.exports =
       cb null, [ { labels: [ { name: 'size 1A' } ] } ]
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal open.size, 0
+      assert.isNull err
+      assert.strictEqual open.size, 0
       do done
 
   'issues - filter when multiple match the regex': (done) ->
@@ -230,9 +230,9 @@ module.exports =
       ]
 
     issues.fetchAll repo, (err, { open, closed }) ->
-      assert.ifError err
-      assert.equal open.size, 11
+      assert.isNull err
+      assert open.size, 11
       [ a, b ] = open.list
-      assert.equal a.size, 7
-      assert.equal b.size, 4
+      assert a.size, 7
+      assert b.size, 4
       do done

test/lines.coffee

@@ -1,6 +1,6 @@
-assert = require 'assert'
+{ assert } = require 'chai'
 
-lines = require '../src/modules/chart/lines.coffee'
+lines      = require '../src/modules/chart/lines.coffee'
 
 module.exports =
 

test/milestones.coffee

@@ -1,5 +1,5 @@
-assert = require 'assert'
-moment = require 'moment'
+{ assert } = require 'chai'
+moment     = require 'moment'
 
 module.exports =
 
@@ -8,6 +8,6 @@ module.exports =
 
     # ISO 8601 dates are in UTC timezone.
     utc = do moment(json[0].created_at).toDate().toUTCString
-    assert.equal utc, 'Sun, 10 Apr 2011 20:09:31 GMT'
+    assert utc, 'Sun, 10 Apr 2011 20:09:31 GMT'
 
     do done

test/projects.coffee

@@ -1,6 +1,6 @@
-assert = require 'assert'
+{ assert } = require 'chai'
 
-projects = require '../src/models/projects.coffee'
+projects   = require '../src/models/projects.coffee'
 
 module.exports =
 

test/ractive.coffee

@@ -1,4 +1,4 @@
-assert = require 'assert'
+{ assert } = require 'chai'
 
 RactiveEventful = require '../src/utils/ractive/eventful.coffee'
 
@@ -23,9 +23,9 @@ module.exports = ->
     do view.render()
 
     view.publish '!event'
-    assert.equal ctx.called, 1
+    assert ctx.called, 1
     do view.teardown
     view.publish '!event'
-    assert.equal ctx.called, 1
+    assert ctx.called, 1
 
     do done

test/request.coffee

@@ -1,6 +1,6 @@
-proxy  = do require('proxyquire').noCallThru
-assert = require 'assert'
-path   = require 'path'
+proxy      = do require('proxyquire').noCallThru
+{ assert } = require 'chai'
+path       = require 'path'
 
 class Sa
 
@@ -48,7 +48,7 @@ module.exports =
     name = 'burnchart'
 
     request.allMilestones { owner, name }, (err, data) ->
-      assert.ifError err
+      assert.isNull err
       assert.deepEqual superagent.params,
         'uri': 'https://api.github.com/repos/asm-products/burnchart/milestones?state=open&sort=due_date&direction=asc'
         'Content-Type': 'application/json',
@@ -67,7 +67,7 @@ module.exports =
     milestone = 1
 
     request.oneMilestone { owner, name, milestone }, (err, data) ->
-      assert.ifError err
+      assert.isNull err
       assert.deepEqual superagent.params,
         'uri': 'https://api.github.com/repos/asm-products/burnchart/milestones/1?state=open&sort=due_date&direction=asc'
         'Content-Type': 'application/json',
@@ -88,7 +88,7 @@ module.exports =
     milestone = 0
     
     request.oneMilestone { owner, name, milestone }, (err) ->
-      assert.equal err, 'Not Found'
+      assert err, 'Not Found'
       do done
 
   'request - one milestone (500)': (done) ->
@@ -102,7 +102,7 @@ module.exports =
     milestone = 0
     
     request.oneMilestone { owner, name, milestone }, (err) ->
-      assert.equal err, 'Error'
+      assert err, 'Error'
       do done
 
   'request - all issues (ok)': (done) ->
@@ -116,7 +116,7 @@ module.exports =
     milestone = 0
     
     request.allIssues { owner, name, milestone }, {}, (err, data) ->
-      assert.ifError err
+      assert.isNull err
       assert.deepEqual superagent.params,
         'uri': 'https://api.github.com/repos/asm-products/burnchart/issues?milestone=0&per_page=100'
         'Content-Type': 'application/json',
@@ -139,7 +139,7 @@ module.exports =
     milestone = 0
     
     request.allIssues { owner, name, milestone }, {}, (err) ->
-      assert.equal err, 'Request has timed out'
+      assert err, 'Request has timed out'
       do done
 
   'request - use tokens': (done) ->
@@ -151,5 +151,5 @@ module.exports =
     name = 'burnchart'
     
     request.repo { owner, name }, ->
-      assert.equal superagent.params.Authorization, 'token ABC'
+      assert superagent.params.Authorization, 'token ABC'
       do done

test/stats.coffee

@@ -1,6 +1,6 @@
-proxy  = do require('proxyquire').noCallThru
-assert = require 'assert'
-path   = require 'path'
+proxy      = do require('proxyquire').noCallThru
+{ assert } = require 'chai'
+path       = require 'path'
 
 stats = require '../src/modules/stats.coffee'
 
@@ -13,9 +13,9 @@ module.exports =
         'closed': { 'size': 0 }
 
     { isEmpty, isOverdue, isOnTime } = stats milestone
-    assert.equal isEmpty, yes
-    assert.equal isOverdue, no
-    assert.equal isOnTime, yes
+    assert.isTrue isEmpty
+    assert.isFalse isOverdue
+    assert.isTrue isOnTime
     do done
 
   'stats - is milestone done?': (done) ->
@@ -25,7 +25,7 @@ module.exports =
         'closed': { 'size': 5 }
 
     { isDone } = stats milestone
-    assert.equal isDone, yes
+    assert.isTrue isDone
     do done
 
   'stats - is milestone overdue? has due date': (done) ->
@@ -36,7 +36,7 @@ module.exports =
         'closed': { 'size': 0 }
 
     { isOverdue } = stats milestone
-    assert.equal isOverdue, yes
+    assert.isTrue isOverdue
     do done
 
   'stats - is milestone on time? has due date, yes': (done) ->
@@ -50,7 +50,7 @@ module.exports =
         'closed': { 'size': 1 }
 
     { isOnTime } = stats milestone
-    assert.equal isOnTime, yes
+    assert.isTrue isOnTime
     do done
 
   'stats - is milestone on time? has due date, no': (done) ->
@@ -64,5 +64,5 @@ module.exports =
         'closed': { 'size': 1 }
 
     { isOnTime } = stats milestone
-    assert.equal isOnTime, no
+    assert.isFalse isOnTime
     do done