status-im
/
burnchart
mirror of https://github.com/status-im/burnchart.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

provide better error messages

This commit is contained in:
jhnns 2013-10-04 19:47:46 +02:00
parent 502601123b
commit 882344b0cb
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/modules/milestones.coffee
View File

@ -11,10 +11,10 @@ module.exports =
# GitHub errors? # GitHub errors?
return cb data.message if data.message return cb data.message if data.message
# Empty warning? # Empty warning?
return cb null, 'No open milestones for repo' unless data.length return cb null, "No open milestones for repo #{repo.path}" unless data.length
# The first milestone should be ending soonest. # The first milestone should be ending soonest.
m = data[0] m = data[0]
# Empty milestone? # Empty milestone?
return cb null, 'No issues for milestone' if m.open_issues + m.closed_issues is 0 return cb null, "No issues for milestone #{m.title}" if m.open_issues + m.closed_issues is 0
cb null, null, m cb null, null, m

7
test/milestones.coffee
View File

@ -55,9 +55,9 @@ module.exports =
req.all_milestones = (opts, cb) -> req.all_milestones = (opts, cb) ->
cb null, [] cb null, []
milestones.get_current {}, (err, warn, milestone) -> milestones.get_current { path: 'some/repo' }, (err, warn, milestone) ->
assert.ifError err assert.ifError err
assert.equal warn, 'No open milestones for repo' assert.equal warn, 'No open milestones for repo some/repo'
do done do done
'milestones - get current when not found': (done) -> 'milestones - get current when not found': (done) ->
@ -72,6 +72,7 @@ module.exports =
req.all_milestones = (opts, cb) -> req.all_milestones = (opts, cb) ->
cb null, [ cb null, [
{ {
'title': 'No issues'
'number': 1 'number': 1
'created_at': '2013-01-01T00:00:00Z' 'created_at': '2013-01-01T00:00:00Z'
'due_on': '2013-02-01T00:00:00Z', 'due_on': '2013-02-01T00:00:00Z',
@ -82,5 +83,5 @@ module.exports =
milestones.get_current {}, (err, warn, milestone) -> milestones.get_current {}, (err, warn, milestone) ->
assert.ifError err assert.ifError err
assert.equal warn, 'No issues for milestone' assert.equal warn, 'No issues for milestone No issues'
do done do done