status-im/burnchart
2
0
Fork 0
mirror of https://github.com/status-im/burnchart.git synced 2025-01-31 21:06:01 +00:00
Code Issues Projects Releases Wiki Activity

no issues for milestone warning

Browse Source
This commit is contained in:
Radek Stepan 2013-08-12 20:09:43 +01:00
parent 8a115037c4
commit 5220316bca
2 changed files with 33 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/milestones.coffee
View File

@ -4,11 +4,15 @@ req = require './request'
module.exports = module.exports =
'get_current': (user, repo, cb) -> 'get_current': (user, repo, cb) ->
req.milestones user, repo, (err, data) -> req.milestones user, repo, (err, data) ->
# Request errors.
return cb err if err return cb err if err
# GitHub errors.
return cb data.message if data.message return cb data.message if data.message
return cb 'No open milestones for a repo' unless data.length # Empty warning.
# Go through the milestones looking for one that ends/ended soonest. return cb null, 'No open milestones for repo' unless data.length
max = [ null, 'A' ] # Find the one due on soonest (string comparison).
for i, { due_on } of data when due_on < max[1] max = { 'due_on': 'A' }
max = [ parseInt(i), due_on ] ( max = ms for ms in data when ms.due_on < max.due_on )
cb null, data[max[0]] # Empty milestone?
return cb null, 'No issues for milestone' if max.open_issues + max.closed_issues is 0
cb null, null, max

28
test/milestones.coffee
View File

@ -20,7 +20,7 @@ module.exports =
} }
] ]
milestones.get_current null, null, (err, milestone) -> milestones.get_current null, null, (err, warn, milestone) ->
assert.ifError err assert.ifError err
assert.equal milestone.number, 1 assert.equal milestone.number, 1
done.call null done.call null
@ -45,7 +45,7 @@ module.exports =
} }
] ]
milestones.get_current null, null, (err, milestone) -> milestones.get_current null, null, (err, warn, milestone) ->
assert.ifError err assert.ifError err
assert.equal milestone.number, 2 assert.equal milestone.number, 2
done.call null done.call null
@ -54,14 +54,32 @@ module.exports =
req.milestones = (user, repo, cb) -> req.milestones = (user, repo, cb) ->
cb null, [] cb null, []
milestones.get_current null, null, (err, milestone) -> milestones.get_current null, null, (err, warn, milestone) ->
assert.equal err, 'No open milestones for a repo' assert.ifError err
assert.equal warn, 'No open milestones for repo'
done.call null done.call null
'get current when not found': (done) -> 'get current when not found': (done) ->
req.milestones = (user, repo, cb) -> req.milestones = (user, repo, cb) ->
cb null, { 'message': 'Not Found' } cb null, { 'message': 'Not Found' }
milestones.get_current null, null, (err, milestone) -> milestones.get_current null, null, (err, warn, milestone) ->
assert.equal err, 'Not Found' assert.equal err, 'Not Found'
done.call null done.call null
'get current when no issues': (done) ->
req.milestones = (user, repo, cb) ->
cb null, [
{
'number': 1
'created_at': '2013-01-01T00:00:00Z'
'due_on': '2013-02-01T00:00:00Z',
'open_issues': 0,
'closed_issues': 0
}
]
milestones.get_current null, null, (err, warn, milestone) ->
assert.ifError err
assert.equal warn, 'No issues for milestone'
done.call null