status-im
/
bignumber.js
mirror of https://github.com/status-im/bignumber.js.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Bugfix #58: division 

Due to using base 1e14 and the consequent imprecision of the trial digit calculation, in very rare circumstances the trial digit may be 2 less than the correct value, not just 1 as previously thought.
This commit is contained in:
Michael Mclaughlin 2015-03-25 21:09:13 +00:00
parent 75682d5ea2
commit 3c24e500e9
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bignumber.js
View File

@ -884,7 +884,8 @@
// 6. If remainder > divisor: remainder -= divisor, n++
if ( n > 1 ) {
if ( n >= base ) n = base - 1;
if (n >= base) n = base - 1;
// product = divisor * trial digit.
prod = multiply( yc, n, base );
@ -916,28 +917,25 @@
// Subtract product from remainder.
subtract( rem, prod, remL, base );
remL = rem.length;
// If product was < previous remainder.
// If product was < remainder.
if ( cmp == -1 ) {
remL = rem.length;
// Compare divisor and new remainder.
cmp = compare( yc, rem, yL, remL );
// If divisor < new remainder, subtract divisor from remainder.
if ( cmp < 1 ) {
while ( ( cmp = compare( yc, rem, yL, remL ) ) < 1 ) {
n++;
// Subtract divisor from remainder.
subtract( rem, yL < remL ? yz : yc, remL, base );
remL = rem.length;
}
}
remL = rem.length;
} else if ( cmp === 0 ) {
n++;
rem = [0];
}
// if cmp === 1, n will be 0
} // else cmp === 1 and n will be 0
// Add the next digit, n, to the result array.
qc[i++] = n;

2
bignumber.min.js vendored
View File

File diff suppressed because one or more lines are too long