status-im
/
autobounty
mirror of https://github.com/status-im/autobounty.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #13 from PombeirP/bug/fix-getAddress-tests 

Fix getAddress tests to use the updated comment format with md link
This commit is contained in:
Andy Tudhope 2018-03-21 11:47:09 +02:00 committed by GitHub
parent c418a5c6b8 b0a8db2102
commit 7bbec12242
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bot/index.js
View File

@ -58,9 +58,13 @@ function hasAddress (req) {
function getAddress (req) {
const commentBody = req.body.comment.body
const index = commentBody.search(contractAddressString) + contractAddressString.length + 1
console.log("address: ", commentBody.substring(index, index + 42))
return commentBody.substring(index, index + 42)
const index = commentBody.search(contractAddressString)
if (index === -1) {
return undefined
}
const addressIndex = index + contractAddressString.length + 1
console.log('address: ', commentBody.substring(addressIndex, addressIndex + 42))
return commentBody.substring(addressIndex, addressIndex + 42)
}
async function getLabel (req) {

2
package.json
View File

@ -6,7 +6,7 @@
"scripts": {
"start": "node index.js",
"debug": "node --inspect-brk index.js",
"test": "./node_modules/mocha/bin/mocha"
"test": "./node_modules/mocha/bin/mocha --timeout 5s"
},
"author": "",
"license": "ISC",

5
test/test_bot.js
View File

@ -4,7 +4,7 @@ const config = require('../config')
const bot = require('../bot')
// status-open-bounty comment from https://github.com/status-im/autobounty/issues/1
const sobComment = 'Current balance: 0.000000 ETH\nTokens: SNT: 2500.00 ANT: 25.00\nContract address: 0x3645fe42b1a744ad98cc032c22472388806f86f9\nNetwork: Mainnet\n To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated.\nTo fund it, send ETH or ERC20/ERC223 tokens to the contract address.'
const sobComment = 'Current balance: 0.000000 ETH\nTokens: SNT: 2500.00 ANT: 25.00\nContract address: [0x3645fe42b1a744ad98cc032c22472388806f86f9](https://etherscan.io/address/0x3645fe42b1a744ad98cc032c22472388806f86f9)\nNetwork: Mainnet\n To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated.\nTo fund it, send ETH or ERC20/ERC223 tokens to the contract address.'
const sobCommentWithWinner = 'Balance: 0.000000 ETH\nContract address: [0xe02fbffb3422ddb8e2227c3495f710ba4f8e0c10](https://etherscan.io/address/0xe02fbffb3422ddb8e2227c3495f710ba4f8e0c10)\nNetwork: Mainnet\nStatus: Pending maintainer confirmation\nWinner: foopang\nVisit [https://openbounty.status.im](https://openbounty.status.im) to learn more.'
// Fake requests
@ -43,6 +43,9 @@ describe('Bot behavior', function () {
it('should return the address from a status-open-bounty bot comment', function () {
assert.equal(bot.getAddress(requests[3]), '0x3645fe42b1a744ad98cc032c22472388806f86f9')
})
it('should not return the address from a comment not containing an address', function () {
assert.isUndefined(bot.getAddress(requests[1]))
})
})
describe('#getAmount', function () {