status-im
/
asynctest
mirror of https://github.com/status-im/asynctest.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix BareExcept warnings

This commit is contained in:
Mark Spanbroek 2023-12-14 10:45:00 +01:00 committed by Giuliano Mega
parent 3f89e84f7c
commit 6799f9e1cc
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
asynctest/templates.nim
View File

@ -4,14 +4,18 @@ template launderExceptions(body: typed) =
## exist in asyncdispatch. We therefore launder all real instances of ## exist in asyncdispatch. We therefore launder all real instances of
## Exception into CatchableError and make Chronos happy while not losing ## Exception into CatchableError and make Chronos happy while not losing
## context information for the remainder of the exception types. ## context information for the remainder of the exception types.
{.push warning[BareExcept]:off.}
try: try:
{.push warning[BareExcept]:on.}
body body
{.pop.}
except Defect as ex: except Defect as ex:
raise ex raise ex
except CatchableError as ex: except CatchableError as ex:
raise ex raise ex
except Exception as ex: except Exception as ex:
raise newException(Defect, ex.msg, ex) raise newException(Defect, ex.msg, ex)
{.pop.}
template suite*(name, body) = template suite*(name, body) =

2
testmodules/stdlib/testfail.nim
View File

@ -26,7 +26,7 @@ suite "reports unhandled exception when teardown handles exceptions too":
teardown: teardown:
try: try:
await someAsyncProc() await someAsyncProc()
except: except CatchableError:
discard discard
test "should fail, but not crash": test "should fail, but not crash":