status-im
/
ansible-role-mongodb
mirror of https://github.com/status-im/ansible-role-mongodb.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix systemd test for Ubuntu Xenial 

The role checks if the system is running or not systemd. It checks the
name of the process with PID1, and if it contains the string "systemd"
assumes that the host is systemd-based. Unfortunately that check fails
in Ubuntu Xenial:

  vagrant@mongo-xenial:~$ cat /proc/1/cmdline
  /sbin/init

A better approach may be to check if /sbin/init is a symlink or a
binary. In systemd-based systems (e.g. Ubuntu Xenial), /sbin/init is a
symlink to the systemd binary:

  vagrant@mongo-xenial:~$ file /sbin/init
  /sbin/init: symbolic link to /lib/systemd/systemd

In Ubuntu Trusty /sbin/init is a binary:

  vagrant@mongo-trusty:~$ file /sbin/init
  /sbin/init: ELF 64-bit LSB  shared object, x86-64, version 1 (SYSV),
  dynamically linked (uses shared libs), for GNU/Linux 2.6.24,
  BuildID[sha1]=7a4c688d009fc1f06ffc692f5f42ab09e68582b2, strippe

This commit attempts to solve the problem described above. The systemd
check has been rewritten to check if /sbin/init is a binary or a
symlink.
This commit is contained in:
David Castellanos 2016-09-21 16:33:05 +02:00
parent d10f2919b1
commit d9393b1b66
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tasks/install.deb.yml
View File

@ -3,22 +3,22 @@
- include_vars: "{{ansible_distribution}}.yml" - include_vars: "{{ansible_distribution}}.yml"
- name: Check if running on systemd - name: Check if running on systemd
command: cat /proc/1/cmdline stat: path=/sbin/init
register: systemd register: sbin_init
changed_when: false changed_when: false
always_run: yes # side-effect free, so it can be run in check-mode as well always_run: yes # side-effect free, so it can be run in check-mode as well
- name: Add systemd configuration if present - name: Add systemd configuration if present
copy: src=mongodb.service dest=/lib/systemd/system/mongodb.service owner=root group=root mode=0640 copy: src=mongodb.service dest=/lib/systemd/system/mongodb.service owner=root group=root mode=0640
when: "'systemd' in systemd.stdout" when: sbin_init.stat.islnk is defined and sbin_init.stat.islnk
- name: Add symlink for systemd - name: Add symlink for systemd
file: src=/lib/systemd/system/mongodb.service dest=/etc/systemd/system/multi-user.target.wants/mongodb.service state=link file: src=/lib/systemd/system/mongodb.service dest=/etc/systemd/system/multi-user.target.wants/mongodb.service state=link
when: "'systemd' in systemd.stdout" when: sbin_init.stat.islnk is defined and sbin_init.stat.islnk
notify: reload systemd notify: reload systemd
- meta: flush_handlers - meta: flush_handlers
when: "'systemd' in systemd.stdout" when: sbin_init.stat.islnk is defined and sbin_init.stat.islnk
- name: Add APT key - name: Add APT key
apt_key: apt_key:
@ -48,7 +48,7 @@
- name: reload systemd - name: reload systemd
shell: systemctl daemon-reload shell: systemctl daemon-reload
changed_when: false changed_when: false
when: "'systemd' in systemd.stdout" when: sbin_init.stat.islnk is defined and sbin_init.stat.islnk
- name: Install PyMongo package - name: Install PyMongo package
apt: pkg=python-pymongo state=latest apt: pkg=python-pymongo state=latest