test: Add unit testing (get-latest-version) (#132)

This commit is contained in:
Shohei Ueda 2020-01-18 11:11:17 +09:00 committed by GitHub
parent 386980e22b
commit 442aa4dbd4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 80 additions and 21 deletions

View File

@ -0,0 +1,64 @@
import {getURL, getLatestVersion} from '../src/get-latest-version';
import nock from 'nock';
import {FetchError} from 'node-fetch';
import {Tool} from '../src/constants';
import jsonTestBrew from './data/brew.json';
import jsonTestGithub from './data/github.json';
beforeEach(() => {
jest.resetModules();
});
afterEach(() => {
nock.cleanAll();
});
describe('getURL()', () => {
test('return expected URL', () => {
const urlBrewExpected = `https://formulae.brew.sh/api/formula/${Tool.Repo}.json`;
const urlBrew: string = getURL(Tool.Org, Tool.Repo, 'brew');
expect(urlBrew).toMatch(urlBrewExpected);
const urlGithubExpected = `https://api.github.com/repos/${Tool.Org}/${Tool.Repo}/releases/latest`;
const urlGithub: string = getURL(Tool.Org, Tool.Repo, 'github');
expect(urlGithub).toMatch(urlGithubExpected);
});
});
describe('getLatestVersion()', () => {
test('return latest version via brew', async () => {
nock('https://formulae.brew.sh')
.get(`/api/formula/${Tool.Repo}.json`)
.reply(200, jsonTestBrew);
const versionLatest: string = await getLatestVersion(
Tool.Org,
Tool.Repo,
'brew'
);
expect(versionLatest).toMatch(Tool.TestVersionLatest);
});
test('return latest version via GitHub', async () => {
nock('https://api.github.com')
.get(`/repos/${Tool.Org}/${Tool.Repo}/releases/latest`)
.reply(200, jsonTestGithub);
const versionLatest: string = await getLatestVersion(
Tool.Org,
Tool.Repo,
'github'
);
expect(versionLatest).toMatch(Tool.TestVersionLatest);
});
test('return exception 404', async () => {
nock('https://formulae.brew.sh')
.get(`/api/formula/${Tool.Repo}.json`)
.reply(404);
await expect(
getLatestVersion(Tool.Org, Tool.Repo, 'brew')
).rejects.toThrowError(FetchError);
});
});

View File

@ -56,7 +56,8 @@ describe('showVersion()', () => {
});
test('return not found', async () => {
result = await main.showVersion('gitgit', ['--version']);
expect(result.exitcode).not.toBe(0);
await expect(
main.showVersion('gitgit', ['--version'])
).rejects.toThrowError(Error);
});
});

View File

@ -3,5 +3,7 @@ export enum Tool {
Org = 'gohugoio',
Repo = 'hugo',
CmdName = 'hugo',
CmdOptVersion = 'version'
CmdOptVersion = 'version',
TestVersionLatest = '0.62.2',
TestVersionSpec = '0.61.0'
}

View File

@ -17,18 +17,14 @@ export async function getLatestVersion(
repo: string,
api: string
): Promise<string> {
try {
const url = getURL(org, repo, api);
const response = await fetch(url);
const json = await response.json();
let latestVersion = '';
if (api === 'brew') {
latestVersion = json.versions.stable;
} else if (api === 'github') {
latestVersion = json.tag_name;
}
return latestVersion;
} catch (e) {
return e;
const url = getURL(org, repo, api);
const response = await fetch(url);
const json = await response.json();
let latestVersion = '';
if (api === 'brew') {
latestVersion = json.versions.stable;
} else if (api === 'github') {
latestVersion = json.tag_name;
}
return latestVersion;
}

View File

@ -26,11 +26,7 @@ export async function showVersion(
}
};
try {
result.exitcode = await exec.exec(cmd, args, options);
} catch (e) {
return e;
}
result.exitcode = await exec.exec(cmd, args, options);
core.debug(`command: ${cmd} ${args}`);
core.debug(`exit code: ${result.exitcode}`);
core.debug(`stdout: ${result.output}`);