status-im
/
Vulkan-Docs
mirror of https://github.com/status-im/Vulkan-Docs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

debug_utils: Fix issues discovered by @krOoze (#794) 

Fixing a few items discovered by @krOoze with the EXT_debug_utils
extension spec language validation.  Namely in two issues:

Issue #789:
 The problem was the manual VUs should have been applied to
 the `vkSetDebugUtilsObjectNameEXT` command and not the
 general `VkDebugUtilsObjectNameInfoEXT` structure.

Issue #790:
 Here, we needed to remove the "noautovalidity" tag on
 the XML and add the "optional" tag to `pObjects` and
 `objectCount`.
This commit is contained in:
Mark Young 2018-12-03 03:02:35 -07:00 committed by Jon Leech
parent 4f7b9d7b83
commit f5ae29c4f5
2 changed files with 37 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
chapters/VK_EXT_debug_utils.txt
View File

@ -42,6 +42,12 @@ include::../api/protos/vkSetDebugUtilsObjectNameEXT.txt[]
slink:VkDebugUtilsObjectNameInfoEXT structure specifying the parameters
of the name to set on the object.
.Valid Usage
****
* pname:pNameInfo\->pname:objectType must: not be ename:VK_OBJECT_TYPE_UNKNOWN
* pname:pNameInfo\->pname:objectHandle must: not be dlink:VK_NULL_HANDLE
****
include::../validity/protos/vkSetDebugUtilsObjectNameEXT.txt[]
--
@ -68,13 +74,14 @@ removed.
.Valid Usage
****
* [[VUID-VkDebugUtilsObjectNameInfoEXT-objectType-01905]]
pname:objectType must: not be ename:VK_OBJECT_TYPE_UNKNOWN
* [[VUID-VkDebugUtilsObjectNameInfoEXT-objectHandle-01906]]
* If pname:objectType is ename:VK_OBJECT_TYPE_UNKNOWN,
pname:objectHandle must: not be dlink:VK_NULL_HANDLE
* [[VUID-VkDebugUtilsObjectNameInfoEXT-objectHandle-01907]]
pname:objectHandle must: be a Vulkan object of the type associated with
pname:objectType as defined in <<debugging-object-types>>.
* If pname:objectType is not ename:VK_OBJECT_TYPE_UNKNOWN,
pname:objectHandle must: be dlink:VK_NULL_HANDLE or
a valid Vulkan handle of the type associated with pname:objectType
as defined in the
<<debugging-object-types, VkObjectType and Vulkan Handle Relationship>>
table
****
include::../validity/structs/VkDebugUtilsObjectNameInfoEXT.txt[]
@ -134,11 +141,11 @@ be used by that implementation.
****
* [[VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908]]
pname:objectType must: not be ename:VK_OBJECT_TYPE_UNKNOWN
* [[VUID-VkDebugUtilsObjectTagInfoEXT-objectHandle-01909]]
pname:objectHandle must: not be dlink:VK_NULL_HANDLE
* [[VUID-VkDebugUtilsObjectTagInfoEXT-objectHandle-01910]]
pname:objectHandle must: be a Vulkan object of the type associated with
pname:objectType as defined in <<debugging-object-types>>.
pname:objectHandle must: be a valid Vulkan handle of the type associated
with pname:objectType as defined in the
<<debugging-object-types, VkObjectType and Vulkan Handle Relationship>>
table
****
include::../validity/structs/VkDebugUtilsObjectTagInfoEXT.txt[]
@ -378,6 +385,10 @@ include::../api/protos/vkCreateDebugUtilsMessengerEXT.txt[]
include::../validity/protos/vkCreateDebugUtilsMessengerEXT.txt[]
The application must: ensure that flink:vkCreateDebugUtilsMessengerEXT is not
executed in parallel with any Vulkan command that is also called with
pname:instance or child of pname:instance as the dispatchable argument.
--
[open,refpage='VkDebugUtilsMessengerCreateInfoEXT',desc='Structure specifying parameters of a newly created debug messenger',type='structs']
@ -664,8 +675,16 @@ The parameters are passed on to the callback in addition to the
pname:pUserData value that was defined at the time the messenger was
registered.
.Valid Usage
****
* pname:objectType member of each element of
pname:pCallbackData\->pname:pObjects must: not be
ename:VK_OBJECT_TYPE_UNKNOWN
****
include::../validity/protos/vkSubmitDebugUtilsMessageEXT.txt[]
--
[open,refpage='vkDestroyDebugUtilsMessengerEXT',desc='Destroy a debug messenger object',type='protos']
@ -696,5 +715,9 @@ include::../api/protos/vkDestroyDebugUtilsMessengerEXT.txt[]
include::../validity/protos/vkDestroyDebugUtilsMessengerEXT.txt[]
The application must: ensure that flink:vkDestroyDebugUtilsMessengerEXT is not
executed in parallel with any Vulkan command that is also called with
pname:instance or child of pname:instance as the dispatchable argument.
--

8
xml/vk.xml
View File

@ -2988,11 +2988,11 @@ server.
<member optional="true"><type>int32_t</type> <name>messageIdNumber</name></member>
<member len="null-terminated">const <type>char</type>* <name>pMessage</name></member>
<member optional="true"><type>uint32_t</type> <name>queueLabelCount</name></member>
<member noautovalidity="true" optional="true" len="queueLabelCount"><type>VkDebugUtilsLabelEXT</type>* <name>pQueueLabels</name></member>
<member len="queueLabelCount">const <type>VkDebugUtilsLabelEXT</type>* <name>pQueueLabels</name></member>
<member optional="true"><type>uint32_t</type> <name>cmdBufLabelCount</name></member>
<member noautovalidity="true" optional="true" len="cmdBufLabelCount"><type>VkDebugUtilsLabelEXT</type>* <name>pCmdBufLabels</name></member>
<member><type>uint32_t</type> <name>objectCount</name></member>
<member noautovalidity="true" len="objectCount"><type>VkDebugUtilsObjectNameInfoEXT</type>* <name>pObjects</name></member>
<member len="cmdBufLabelCount">const <type>VkDebugUtilsLabelEXT</type>* <name>pCmdBufLabels</name></member>
<member optional="true"><type>uint32_t</type> <name>objectCount</name></member>
<member len="objectCount">const <type>VkDebugUtilsObjectNameInfoEXT</type>* <name>pObjects</name></member>
</type>
<type category="struct" name="VkImportMemoryHostPointerInfoEXT" structextends="VkMemoryAllocateInfo">
<member values="VK_STRUCTURE_TYPE_IMPORT_MEMORY_HOST_POINTER_INFO_EXT"><type>VkStructureType</type> <name>sType</name></member>