From c55751e7bd09a546b8ef64d1c31a3ac0f36939b5 Mon Sep 17 00:00:00 2001 From: Nayuki Minase Date: Mon, 18 Apr 2016 19:39:32 +0000 Subject: [PATCH] Fixed JavaScript code for detecting the need for a larger QR Code version, due to incorrect code simplification in commit 5692e951ddeb. --- javascript/qrcodegen.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/javascript/qrcodegen.js b/javascript/qrcodegen.js index 7254be3..270278f 100644 --- a/javascript/qrcodegen.js +++ b/javascript/qrcodegen.js @@ -778,13 +778,14 @@ var qrcodegen = new function() { if (version < 1 || version > 40) throw "Version number out of range"; var result = 0; - segs.forEach(function(seg) { + for (var i = 0; i < segs.length; i++) { + var seg = segs[i]; var ccbits = seg.getMode().numCharCountBits(version); // Fail if segment length value doesn't fit in the length field's bit-width if (seg.getNumChars() >= (1 << ccbits)) return null; result += 4 + ccbits + seg.getBits().length; - }); + } return result; };