status-im/QR-Code-generator
2
0
Fork 0
mirror of https://github.com/status-im/QR-Code-generator.git synced 2025-02-24 10:28:20 +00:00
Code Issues Projects Releases Wiki Activity

Simplified the argument check in BitBuffer.appendBits() by tightening the input range, also removed some parentheses.

Browse Source
This commit is contained in:
Project Nayuki 2017-08-18 03:33:03 +00:00
parent 7e512971df
commit 97e0388cb7
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/BitBuffer.cpp
View File

@ -39,7 +39,7 @@ std::vector<std::uint8_t> BitBuffer::getBytes() const {
void BitBuffer::appendBits(std::uint32_t val, int len) {
if (len < 0 || len > 32 || (len < 32 && (val >> len) != 0))
if (len < 0 || len > 31 || val >> len != 0)
throw "Value out of range";
for (int i = len - 1; i >= 0; i--) // Append bit by bit
this->push_back(((val >> i) & 1) != 0);

2
java/io/nayuki/qrcodegen/BitBuffer.java
View File

@ -77,7 +77,7 @@ public final class BitBuffer implements Cloneable {
// Appends the given number of bits of the given value to this sequence.
// If 0 <= len <= 31, then this requires 0 <= val < 2^len.
public void appendBits(int val, int len) {
if (len < 0 || len > 32 || len < 32 && (val >>> len) != 0)
if (len < 0 || len > 31 || val >>> len != 0)
throw new IllegalArgumentException("Value out of range");
for (int i = len - 1; i >= 0; i--, bitLength++) // Append bit by bit
data.set(bitLength, ((val >>> i) & 1) != 0);

2
javascript/qrcodegen.js
View File

@ -1006,7 +1006,7 @@ var qrcodegen = new function() {
// Appends the given number of bits of the given value to this sequence.
// If 0 <= len <= 31, then this requires 0 <= val < 2^len.
this.appendBits = function(val, len) {
if (len < 0 || len > 32 || len < 32 && (val >>> len) != 0)
if (len < 0 || len > 31 || val >>> len != 0)
throw "Value out of range";
for (var i = len - 1; i >= 0; i--) // Append bit by bit
this.push((val >>> i) & 1);