From 78e234fb0dbb055f90b5831b6e1d7b86d7d7a27d Mon Sep 17 00:00:00 2001
From: Project Nayuki <me@nayuki.io>
Date: Sat, 25 Aug 2018 23:15:27 +0000
Subject: [PATCH] Simplified Java QrSegmentAdvanced.splitIntoSegments() to
 reduce redundancy.

---
 .../nayuki/qrcodegen/QrSegmentAdvanced.java   | 20 ++++---------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/java/io/nayuki/qrcodegen/QrSegmentAdvanced.java b/java/io/nayuki/qrcodegen/QrSegmentAdvanced.java
index e7f421d..526d1bb 100644
--- a/java/io/nayuki/qrcodegen/QrSegmentAdvanced.java
+++ b/java/io/nayuki/qrcodegen/QrSegmentAdvanced.java
@@ -181,8 +181,8 @@ public final class QrSegmentAdvanced {
 		// Accumulate run of modes
 		QrSegment.Mode curMode = charModes[0];
 		int start = 0;
-		for (int i = 1; i < data.length; i++) {
-			if (charModes[i] != curMode) {
+		for (int i = 1; ; i++) {
+			if (i >= data.length || charModes[i] != curMode) {
 				if (curMode == BYTE)
 					result.add(QrSegment.makeBytes(Arrays.copyOfRange(data, start, i)));
 				else {
@@ -194,24 +194,12 @@ public final class QrSegmentAdvanced {
 					else
 						throw new AssertionError();
 				}
+				if (i >= data.length)
+					return result;
 				curMode = charModes[i];
 				start = i;
 			}
 		}
-		
-		// Final segment
-		if (curMode == BYTE)
-			result.add(QrSegment.makeBytes(Arrays.copyOfRange(data, start, data.length)));
-		else {
-			String temp = new String(data, start, data.length - start, StandardCharsets.US_ASCII);
-			if (curMode == NUMERIC)
-				result.add(QrSegment.makeNumeric(temp));
-			else if (curMode == ALPHANUMERIC)
-				result.add(QrSegment.makeAlphanumeric(temp));
-			else
-				throw new AssertionError();
-		}
-		return result;
 	}