From 08886d2a3ed29b299ea6bcbe45f17a873579545b Mon Sep 17 00:00:00 2001 From: Project Nayuki Date: Thu, 1 Nov 2018 18:00:02 +0000 Subject: [PATCH] Simplified a bit of code in JavaScript, TypeScript, Python. --- javascript/qrcodegen.js | 5 +++-- python/qrcodegen.py | 4 ++-- typescript/qrcodegen.ts | 4 ++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/javascript/qrcodegen.js b/javascript/qrcodegen.js index 5123072..3fa1a20 100644 --- a/javascript/qrcodegen.js +++ b/javascript/qrcodegen.js @@ -997,8 +997,9 @@ var qrcodegen = new function() { data.forEach(function(b) { var factor = b ^ result.shift(); result.push(0); - for (var i = 0; i < result.length; i++) - result[i] ^= ReedSolomonGenerator.multiply(coefficients[i], factor); + coefficients.forEach(function(coef, i) { + result[i] ^= ReedSolomonGenerator.multiply(coef, factor); + }); }); return result; }; diff --git a/python/qrcodegen.py b/python/qrcodegen.py index 1a3f417..8d82837 100644 --- a/python/qrcodegen.py +++ b/python/qrcodegen.py @@ -870,8 +870,8 @@ class _ReedSolomonGenerator(object): for b in data: factor = b ^ result.pop(0) result.append(0) - for i in range(len(result)): - result[i] ^= _ReedSolomonGenerator._multiply(self.coefficients[i], factor) + for (i, coef) in enumerate(self.coefficients): + result[i] ^= _ReedSolomonGenerator._multiply(coef, factor) return result diff --git a/typescript/qrcodegen.ts b/typescript/qrcodegen.ts index 2bb3e71..d990d84 100644 --- a/typescript/qrcodegen.ts +++ b/typescript/qrcodegen.ts @@ -925,8 +925,8 @@ namespace qrcodegen { for (const b of data) { const factor: byte = b ^ (result.shift() as int); result.push(0); - for (let i = 0; i < result.length; i++) - result[i] ^= ReedSolomonGenerator.multiply(this.coefficients[i], factor); + this.coefficients.forEach((coef, i) => + result[i] ^= ReedSolomonGenerator.multiply(coef, factor)); } return result; }