Sachi King
ed7d0fe94f
Add type to OrderedDict ( #1954 )
...
OrderedDict needs to be typed just like Dict needs to be typed. The
OrderedDict "input" variable key and value are used to append to a
string without any processing, so it seems unlikely that something other
than a string would be valid.
2021-06-02 14:59:42 +10:00
Sachi King
27ba7838e1
Do not import from unpackaged paths in typing ( #1926 )
...
The tests path is not part of the shipped project, thus this type cannot
be checked by users of this project.
The correct type in place of the type imported from tests appears to be
Optional[
Union[HTTPRequestsConnectionClass, HTTPSRequestsConnectionClass]
]
2021-04-26 14:24:54 +10:00
Steve Kowalik
165d995da2
Correct **kwargs typing for search_* ( #1636 )
...
It turns out typing for **kwargs is always Dict[str, Type], so only the
type is required.
Fixes #1633
2020-08-06 21:56:09 +10:00
Denis Blanchette
cc1b884c98
Remove "api_preview" parameter from type stubs and docstrings ( #1559 )
2020-06-18 18:30:33 +10:00
Steve Kowalik
7b20b13d0b
Small improvements to typing ( #1517 )
...
Work through some of the errors when running mypy with --strict.
2020-05-15 10:47:22 +10:00
Alice GIRARD and Liuyang Wan
91433fe925
Type stubs for mypy ( #1231 )
...
* First attempt at stubs
* fix AuthenticatedUser.piy
* fix PullRequest.piy
* fix Authorization.piy
* fix Branch.piy
* fix Clones.piy
* fix Commit.piy
* fix CommitCombinedStatus.piy
* fix CommitComment.piy
* fix CommitStatus.piy
* fix ContentFile.piy
* fix Download.piy
* fix Event.piy
* fix File.piy
* fix Gist.piy
* fix GistComment.piy
* fix GistFile.piy
* fix GitAuthor.piy
* fix GitBlob.piy
* fix GitCommit.piy
* fix GitRef.piy
* fix GitRelease.piy
* renamed stubs into pyi files
* fix Notification
* fix Repository
* fix GitReleaseAsset
* fix GitTag
* fix GitTree
* fix GitTreeElement
* fix GithubException
* fix GithubObject
* fix GitignoreTemplate
* fix HookDescription
* fix HookResponse
* fix InputGitAuthor
* fix Installation
* fix InstallationAuthorization
* fix Invitation
* fix Issue
* fix IssueComment
* Fix random issues found while testing
* fix IssuePullRequest
* fix Label
* fix License
* fix Migration
* fix Milestone
* fix NamedUser
* fix NotificationSubject
* fix Organization
* fix PaginatedList
* fix Path
* fix Permissions
* fix Plan
* fix Project
* fix ProjectCard
* fix ProjectColumn
* fix PullRequestComment
* fix PullRequestMergeStatus
* fix PullRequestPart
* fix PullRequestReview
* fix Rate
* fix RateLimit
* fix Reaction
* fix Referrer
* fix RepositoryKey
* fix RequiredPullRequestReviews
* fix RequiredStatusChecks
* fix SourceImport
* fix Stargazer
* fix StatsCodeFrequency
* fix StatsCommitActivity
* fix StatsContributor
* fix Tag
* fix Team
* fix Topic
* fix UserKey
* fix MainClass
* fix Requester
* added stubs for View
* added stubs for Membership
* various syntax errors
* silence mypy noise
* keeping track of recent changes
* black + isort
Co-authored-by: Liuyang Wan <lwan@zendesk.com >
2020-03-22 19:33:23 +08:00
Sachi King