Commit Graph
32 Commits
Author SHA1 Message Date
Steve Kowalik e113e37de1 Add pyupgrade to pre-commit configuration (#1783)
To help us switch to f-strings and other 3.6+ changes, add pyupgrade to
our pre-commit configuration to keep the codebase clean.
2020-12-15 14:07:33 +11:00
Steve Kowalik dd31a70659 Silence most ResourceWarnings (#1393)
A few test classes were failing to call tearDown() of the superclass,
which meant the file descriptors of their replydata files were leaking.
Make sure to call it, and switch every other callsite of superclasses by
name to using argument-less super().

Revert an AllTests change that snuck in during release.
2020-02-12 15:05:32 +11:00
Wan Liuyang 6ceb9e9a15 Apply black to whole codebase (#1303) 2019-12-10 17:14:33 +08:00
Steve Kowalik f91cbac2e3 Add an IncompletableObject exception (#1227)
If a returned object from GitHub does not include an URL, that object
can not be completed, and used to fail with an obscure traceback saying
NoneType has no method startswith. Check for this, and raise
IncompletableObject instead.
2019-09-23 16:40:06 +10:00
Steve Kowalik a0f01cf9cf Remove more Python version specific code (#1193)
Remove a bunch of other call sites that behaved differently between
Python 2 and 3, massively cleaning up a few messy methods.
2019-08-28 15:24:54 +10:00
sfdye 365a0a24d3 Apply fix_headers script to update copyright info 2018-03-17 20:06:16 +08:00
sfdye 58e1ef9ccb Fix copyright formatting 2018-03-13 22:30:47 +08:00
sfdye 020c136a40 Update doc link in copyright text 2018-03-13 22:07:38 +08:00
Peter Buckley cb0cf0a680 update doc url everywhere (#420) 2016-07-12 16:38:02 -04:00
humbug 8f8b455a35 Fix for pickling exception when deserializing GithubException.
See: https://bugs.python.org/issue9400

"Because CalledProcessError extends PyExc_BaseException, which defines a __reduce__ method, that special method cause the pickle load to call the exception type's __init__ method with packed self.args as arguments. So if a subclass of "Exception" needs to behave correctly in pickling, it should make self.args meet its __init__ method's function signature. "
2016-04-04 16:47:43 -07:00
Vincent Jacques abca7a026e pep8
This is strange, maybe Cygwin's version is stricter.
No time to investigate.
2014-05-04 12:54:05 -07:00
Vincent Jacques f74c95a944 Integrate #220 (fix tests and pep8) 2013-12-23 19:38:39 -08:00
Cameron White 36352598ae Added onetime_password to create_authorization
github.AuthenticatedUser.create_authorization has been modified to
support two-factor authentication. When two-factor authentication
is enabled create_authorization will throw an TwoFactorException.
The onetime password can be then be passed to create_authorization
on a subsequent call.
2013-12-19 04:05:26 -08:00
Vincent Jacques 072bf24277 Raise exception only when user *accesses* an attribute with a bad value (#195) 2013-09-12 11:45:29 +02:00
Vincent Jacques bae0a37d18 #193: Don't use a try-except for a usual execution flow in GithubObject.update
(and factorize assignment of headers in _storeAndUseAttributes,
as done for rawData)
2013-08-23 11:10:35 +02:00
Vincent Jacques 0f74e4389b Review of #189: pep8, copyrights, style, remarks
For remarks, run: git grep "#189"
They are only my first thoughts while reviewing this pull request,
and should be reviewed themselves.
2013-08-22 12:12:38 +02:00
AKFish 1e9ec2df08 Add NotModifiedException class 2013-08-21 23:04:07 +08:00
Vincent Jacques 06a3d87098 Change source file header format 2013-07-13 19:03:53 +02:00
Vincent Jacques db2a9db721 Add two new types of exceptions (issue #152) 2013-05-17 14:27:17 +02:00
Vincent Jacques 73f9ae8f21 Merge branch 'topic/SpecificExceptions' into develop 2013-04-22 22:23:04 +02:00
Vincent Jacques db5560bd65 Add a script to check copyrights with git log. And fix copyrights. 2013-03-29 16:54:15 +01:00
Vincent Jacques dff0946500 Add a documentation note about exceptions 2013-03-29 13:16:57 +01:00
Vincent Jacques 0bc368973a Raise a specific exception for non-existing objects (issue #152) 2013-03-29 13:10:59 +01:00
Vincent Jacques 7b3e4c15ed Raise a specific exception for bad credentials (issue #152) 2013-03-29 13:01:06 +01:00
Vincent Jacques f5d8e221d1 Add (a bit of) documentation about error handling and exceptions 2013-03-28 20:55:48 +01:00
Vincent Jacques 7a415fda66 Change home page 2013-02-16 21:19:49 +01:00
Vincent Jacques abf0867543 Generate some repetitive doc files 2012-12-29 08:47:23 +01:00
Zearin 4c6a70c24a Add encoding comment to source files
This is a minor thing.  It’s a convention, not a rule (obviously)—but it’s also a best practice.

Many text editors look for this kind of comment as the first line—or second line, if there is a shebang (the `#!/usr/bin/env python`, or whatever else)—and make use of this to determine the file’s encoding.
2012-11-01 11:43:56 -04:00
Vincent Jacques 531c3f2d32 Improve comformance to pep8 (+dos2unix)
PyGithub is now a public projects with several public contibutors,
I have to abandon my very personal coding conventions.
2012-09-17 20:37:22 +02:00
Vincent Jacques 41c2b94f95 Add a copyright and license notice (issue #16) 2012-06-03 19:56:33 +01:00
Vincent Jacques 5384d6f9a8 Simplify understanding of GithubExceptions by displaying the error message from Github 2012-06-02 13:07:23 +01:00
Vincent Jacques 9820c58477 Move generated code to 'github' instead of 'src/github' 2012-06-02 13:06:28 +01:00