status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-01 19:31:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-work PullRequest reviewer request (#765)

Browse Source 
Add create_review_request() and delete_review_request() methods to
PullRequest, as well as renaming get_reviewer_requests() to
get_review_requests() and cleaning up its return value to firstly respect
teams, and secondly to cut out the middleman of PullRequestReviewerRequests,
which has been removed.

Fixes #597
This commit is contained in:
Steve Kowalik
2018-04-23 14:22:51 +08:00
committed by Wan Liuyang
parent 1f23c06a4d
commit e2e29918ea
7 changed files with 133 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/tests/PullRequest.py
+10
View File
@@ -98,6 +98,16 @@ class PullRequest(Framework.TestCase):
comment = self.pull.get_issue_comment(8387331)
self.assertEqual(comment.body, "Issue comment created by PyGithub")
def testReviewRequests(self):
self.pull.create_review_request(reviewers="sfdye", team_reviewers="pygithub-owners")
review_requests = self.pull.get_review_requests()
self.assertListKeyEqual(review_requests[0], lambda c: c.login, ["sfdye"])
self.assertListKeyEqual(review_requests[1], lambda c: c.slug, ["pygithub-owners"])
self.pull.delete_review_request(reviewers="sfdye")
review_requests = self.pull.get_review_requests()
self.assertEqual(list(review_requests[0]), [])
self.assertListKeyEqual(review_requests[1], lambda c: c.slug, ["pygithub-owners"])
def testEditWithoutArguments(self):
self.pull.edit()