From dd80a6c09112772f696cc0830e012a74c5a8529e Mon Sep 17 00:00:00 2001
From: Steve Kowalik <steven@wedontsleep.org>
Date: Fri, 17 Jan 2020 13:44:18 +1000
Subject: [PATCH] Tidy up ProjectCard.get_content() (#1355)

ProjectCard.get_content() did not document its one argument or assert
its type. Do so, as well as generally tidy up the calls.
---
 github/ProjectCard.py | 20 +++++++++++---------
 tests/Project.py      |  1 +
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/github/ProjectCard.py b/github/ProjectCard.py
index 13dff57d..ed0712a0 100644
--- a/github/ProjectCard.py
+++ b/github/ProjectCard.py
@@ -115,23 +115,25 @@ class ProjectCard(github.GithubObject.CompletableGithubObject):
     def get_content(self, content_type=github.GithubObject.NotSet):
         """
         :calls: `GET /repos/:owner/:repo/pulls/:number <https://developer.github.com/v3/pulls/#get-a-single-pull-request>`_
+        :param content_type: string, optional
         :rtype: :class:`github.PullRequest.PullRequest` or :class:`github.Issue.Issue`
         """
+        assert content_type is github.GithubObject.NotSet or isinstance(
+            content_type, str
+        ), content_type
         if self.content_url is None:
             return None
 
         if content_type == "PullRequest":
-            headers, data = self._requester.requestJsonAndCheck(
-                "GET", self.content_url.replace("issues", "pulls")
-            )
-            return github.PullRequest.PullRequest(
-                self._requester, headers, data, completed=True
-            )
+            url = self.content_url.replace("issues", "pulls")
+            retclass = github.PullRequest.PullRequest
         elif content_type is github.GithubObject.NotSet or content_type == "Issue":
-            headers, data = self._requester.requestJsonAndCheck("GET", self.content_url)
-            return github.Issue.Issue(self._requester, headers, data, completed=True)
+            url = self.content_url
+            retclass = github.Issue.Issue
         else:
-            assert False, "Unknown content type: %s" % content_type
+            raise ValueError("Unknown content type: %s" % content_type)
+        headers, data = self._requester.requestJsonAndCheck("GET", url)
+        return retclass(self._requester, headers, data, completed=True)
 
     def _initAttributes(self):
         self._archived = github.GithubObject.NotSet
diff --git a/tests/Project.py b/tests/Project.py
index 259a1dc1..71d5c1a8 100644
--- a/tests/Project.py
+++ b/tests/Project.py
@@ -127,6 +127,7 @@ class Project(Framework.TestCase):
         self.assertEqual(
             pull.title, "Work in progress on support for GitHub projects API."
         )
+        self.assertRaises(ValueError, pull_card.get_content, "foo")
 
         issue_card = cards[1]
         issue = issue_card.get_content()