diff --git a/github/MainClass.py b/github/MainClass.py index 3efde171..676fa914 100644 --- a/github/MainClass.py +++ b/github/MainClass.py @@ -93,8 +93,12 @@ class Github(object): def __set_per_page(self, value): self.__requester.per_page = value + # v2: Remove this property? Why should it be necessary to read/modify it after construction per_page = property(__get_per_page, __set_per_page) + # v2: Provide a unified way to access values of headers of last response + # v2: (and add/keep ad hoc properties for specific useful headers like rate limiting, oauth scopes, etc.) + # v2: Return an instance of a class: using a tuple did not allow to add a field "resettime" @property def rate_limiting(self): """ @@ -325,7 +329,7 @@ class Github(object): def get_hooks(self): """ :calls: `GET /hooks `_ - :rtype: :class:`github.PaginatedList.PaginatedList` of :class:`github.HookDescription.HookDescription` + :rtype: list of :class:`github.HookDescription.HookDescription` """ headers, data = self.__requester.requestJsonAndCheck( "GET", diff --git a/github/tests/Persistence.py b/github/tests/Persistence.py index c20f9a7c..300e9174 100644 --- a/github/tests/Persistence.py +++ b/github/tests/Persistence.py @@ -29,6 +29,7 @@ if Framework.atLeastPython26: else: from StringIO import StringIO as IO + class Persistence(Framework.TestCase): def setUp(self): Framework.TestCase.setUp(self)