status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-01 11:21:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assert that we know all attributes

Browse Source 
To be removed before release, since this would break the application if
github.com adds a new attribute
This commit is contained in:
Vincent Jacques
2012-05-12 13:20:32 +02:00
parent 5a943ad0b2
commit dc1a8f8c9d
37 changed files with 149 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/github/PullRequestFile.py
+4 -1
View File
@@ -63,7 +63,10 @@ class PullRequestFile( object ):
self.__status = None
def __useAttributes( self, attributes ):
#@todo No need to check if attribute is in attributes when attribute is mandatory
# @todo Remove this debug weakness: we shall assume that github will add new attributes
for attribute in attributes:
assert attribute in [ "additions", "blob_url", "changes", "deletions", "filename", "patch", "raw_url", "sha", "status", ]
# @todo No need to check if attribute is in attributes when attribute is mandatory
if "additions" in attributes and attributes[ "additions" ] is not None:
self.__additions = attributes[ "additions" ]
if "blob_url" in attributes and attributes[ "blob_url" ] is not None: