status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-01 11:21:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use datetime object in create_milestone (#698)

Browse Source 
Method create_milestone now uses datetime object to fit better with v3 API using ISO8601.

Date object still allowed for backward compatibility.
This commit is contained in:
Brian Torres-Gil
2018-02-06 22:44:57 -08:00
committed by Jason White
parent e671fdd035
commit cef98416f4
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/Repository.py
+6 -3
View File
@@ -968,13 +968,13 @@ class Repository(github.GithubObject.CompletableGithubObject):
:param title: string
:param state: string
:param description: string
:param due_on: date
:param due_on: datetime
:rtype: :class:`github.Milestone.Milestone`
"""
assert isinstance(title, (str, unicode)), title
assert state is github.GithubObject.NotSet or isinstance(state, (str, unicode)), state
assert description is github.GithubObject.NotSet or isinstance(description, (str, unicode)), description
assert due_on is github.GithubObject.NotSet or isinstance(due_on, datetime.date), due_on
assert due_on is github.GithubObject.NotSet or isinstance(due_on, (datetime.datetime, datetime.date)), due_on
post_parameters = {
"title": title,
}
@@ -983,7 +983,10 @@ class Repository(github.GithubObject.CompletableGithubObject):
if description is not github.GithubObject.NotSet:
post_parameters["description"] = description
if due_on is not github.GithubObject.NotSet:
post_parameters["due_on"] = due_on.strftime("%Y-%m-%dT%H:%M:%SZ")
if isinstance(due_on, datetime.date):
post_parameters["due_on"] = due_on.strftime("%Y-%m-%dT%H:%M:%SZ")
else:
post_parameters["due_on"] = due_on.isoformat()
headers, data = self._requester.requestJsonAndCheck(
"POST",
self.url + "/milestones",