diff --git a/codegen/JsonDescriptionOfGithubApiV3/description.human_readable.json b/codegen/JsonDescriptionOfGithubApiV3/description.human_readable.json index 771f8792..7254a742 100644 --- a/codegen/JsonDescriptionOfGithubApiV3/description.human_readable.json +++ b/codegen/JsonDescriptionOfGithubApiV3/description.human_readable.json @@ -11,7 +11,6 @@ }, { "name": "AuthenticatedUser", - "isCompletable": true, "url": [ { "type": "constant", "value": "https://api.github.com/user" } ], @@ -248,7 +247,6 @@ }, { "name": "AuthorizationApplication", - "isCompletable": false, "attributes": [ { "name": "url", "type": "string" }, { "name": "name", "type": "string" } @@ -256,7 +254,6 @@ }, { "name": "Authorization", - "isCompletable": true, "edit": { "optionalParameters": [ { "name": "scopes", "type": "list:string" }, @@ -310,7 +307,6 @@ }, { "name": "Commit", - "isCompletable": true, "attributes": [ { "name": "files", "type": "list:CommitFile" }, { "name": "parents", "type": "list:Commit" }, @@ -342,7 +338,6 @@ }, { "name": "CommitComment", - "isCompletable": true, "edit": { "mandatoryParameters": [ { "name": "body", "type": "string" } @@ -365,7 +360,6 @@ }, { "name": "Download", - "isCompletable": true, "delete": true, "attributes": [ { "name": "accesskeyid", "type": "string" }, @@ -415,7 +409,6 @@ }, { "name": "Gist", - "isCompletable": true, "edit": { "optionalParameters": [ { "name": "description", "type": "string" }, @@ -556,6 +549,7 @@ }, { "name": "GitObject", + "isCompletable": false, "attributes": [ { "name": "sha", "type": "string" }, { "name": "type", "type": "string" }, @@ -592,6 +586,7 @@ }, { "name": "GitTreeElement", + "isCompletable": false, "attributes": [ { "name": "mode", "type": "string" }, { "name": "path", "type": "string" }, @@ -619,7 +614,6 @@ }, { "name": "HookResponse", - "isCompletable": false, "attributes": [ { "name": "status", "type": "string" }, { "name": "message", "type": "string" }, @@ -670,7 +664,6 @@ }, { "name": "IssuePullRequest", - "isCompletable": false, "attributes": [ { "name": "diff_url", "type": "string" }, { "name": "patch_url", "type": "string" }, @@ -679,7 +672,6 @@ }, { "name": "Issue", - "isCompletable": true, "edit": { "optionalParameters": [ { "name": "title", "type": "string" }, @@ -775,7 +767,6 @@ }, { "name": "IssueEvent", - "isCompletable": true, "attributes": [ { "name": "commit_id", "type": "string" }, { "name": "created_at", "type": "string" }, @@ -846,7 +837,6 @@ }, { "name": "NamedUser", - "isCompletable": true, "attributes": [ { "name": "avatar_url", "type": "string" }, { "name": "bio", "type": "string" }, @@ -983,7 +973,6 @@ }, { "name": "Organization", - "isCompletable": true, "edit": { "optionalParameters": [ { "name": "billing_email", "type": "string" }, @@ -1135,7 +1124,6 @@ }, { "name": "PullRequest", - "isCompletable": true, "edit": { "optionalParameters": [ { "name": "title", "type": "string" }, @@ -1250,7 +1238,6 @@ }, { "name": "PullRequestComment", - "isCompletable": true, "edit": { "mandatoryParameters": [ { "name": "body", "type": "string" } @@ -1295,7 +1282,6 @@ }, { "name": "Repository", - "isCompletable": true, "identity": [ { "type": "attribute", "value": [ "owner", "login" ] }, { "type": "constant", "value": "/" }, @@ -1783,7 +1769,6 @@ }, { "name": "Team", - "isCompletable": true, "edit": { "mandatoryParameters": [ { "name": "name", "type": "string" } @@ -1824,7 +1809,6 @@ }, { "name": "UserKey", - "isCompletable": true, "edit": { "optionalParameters": [ { "name": "title", "type": "string" }, diff --git a/codegen/JsonDescriptionOfGithubApiV3/description.normalized.json b/codegen/JsonDescriptionOfGithubApiV3/description.normalized.json index ca8628a8..70423a3c 100644 --- a/codegen/JsonDescriptionOfGithubApiV3/description.normalized.json +++ b/codegen/JsonDescriptionOfGithubApiV3/description.normalized.json @@ -1594,7 +1594,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "AuthorizationApplication", "methods": [] }, @@ -2808,7 +2808,7 @@ "name": "user" } ], - "isCompletable": false, + "isCompletable": true, "name": "GistComment", "methods": [ { @@ -2918,7 +2918,7 @@ "name": "version" } ], - "isCompletable": false, + "isCompletable": true, "name": "GistHistoryState", "methods": [] }, @@ -2996,7 +2996,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "GitBlob", "methods": [] }, @@ -3059,7 +3059,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "GitCommit", "methods": [] }, @@ -3121,7 +3121,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "GitRef", "methods": [ { @@ -3248,7 +3248,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "GitTag", "methods": [] }, @@ -3279,7 +3279,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "GitTree", "methods": [] }, @@ -3413,7 +3413,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "Hook", "methods": [ { @@ -4205,7 +4205,7 @@ "name": "user" } ], - "isCompletable": false, + "isCompletable": true, "name": "IssueComment", "methods": [ { @@ -4393,7 +4393,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "Label", "identity": [ { @@ -4572,7 +4572,7 @@ "name": "url" } ], - "isCompletable": false, + "isCompletable": true, "name": "Milestone", "methods": [ { @@ -10046,7 +10046,7 @@ "name": "verified" } ], - "isCompletable": false, + "isCompletable": true, "name": "RepositoryKey", "methods": [ { diff --git a/codegen/JsonDescriptionOfGithubApiV3/normalize.py b/codegen/JsonDescriptionOfGithubApiV3/normalize.py index b3cae450..29fa546c 100644 --- a/codegen/JsonDescriptionOfGithubApiV3/normalize.py +++ b/codegen/JsonDescriptionOfGithubApiV3/normalize.py @@ -296,7 +296,7 @@ class Class: ], key = lambda class_: class_.name ) - self.isCompletable = "isCompletable" in desc and desc[ "isCompletable" ] + self.isCompletable = ( "isCompletable" not in desc or desc[ "isCompletable" ] ) and any( attribute.name == "url" for attribute in self.attributes ) self.methods = [] if "identity" in desc: self.identity = desc[ "identity" ] diff --git a/codegen/templates/GithubObject.py b/codegen/templates/GithubObject.py index 3eb8ff8d..31694485 100644 --- a/codegen/templates/GithubObject.py +++ b/codegen/templates/GithubObject.py @@ -19,9 +19,9 @@ import {{ dependency }} {% endif %} {% if class.isCompletable %} -class {{ class.name }}( GithubObject.CompletableGithubObject ): -{% else %} class {{ class.name }}( GithubObject.GithubObject ): +{% else %} +class {{ class.name }}( GithubObject.BasicGithubObject ): {% endif %} {% include "GithubObject.PublicAttributes.py" %} diff --git a/src/github/AuthenticatedUser.py b/src/github/AuthenticatedUser.py index 261ff665..f82809aa 100644 --- a/src/github/AuthenticatedUser.py +++ b/src/github/AuthenticatedUser.py @@ -15,7 +15,7 @@ import Issue import Event import Authorization -class AuthenticatedUser( GithubObject.CompletableGithubObject ): +class AuthenticatedUser( GithubObject.GithubObject ): @property def avatar_url( self ): self._completeIfNeeded( self._avatar_url ) diff --git a/src/github/Authorization.py b/src/github/Authorization.py index 658411fb..84d8f84e 100644 --- a/src/github/Authorization.py +++ b/src/github/Authorization.py @@ -6,7 +6,7 @@ from DefaultValueForOptionalParameters import DefaultValueForOptionalParameters ########## import AuthorizationApplication -class Authorization( GithubObject.CompletableGithubObject ): +class Authorization( GithubObject.GithubObject ): @property def app( self ): self._completeIfNeeded( self._app ) diff --git a/src/github/AuthorizationApplication.py b/src/github/AuthorizationApplication.py index 8375ea19..e71ced1f 100644 --- a/src/github/AuthorizationApplication.py +++ b/src/github/AuthorizationApplication.py @@ -6,10 +6,12 @@ import GithubObject class AuthorizationApplication( GithubObject.GithubObject ): @property def name( self ): + self._completeIfNeeded( self._name ) return self._name @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def _initAttributes( self ): diff --git a/src/github/Branch.py b/src/github/Branch.py index c0c4971a..c40dbaf4 100644 --- a/src/github/Branch.py +++ b/src/github/Branch.py @@ -5,7 +5,7 @@ import GithubObject ########## import Commit -class Branch( GithubObject.GithubObject ): +class Branch( GithubObject.BasicGithubObject ): @property def commit( self ): return self._commit diff --git a/src/github/Commit.py b/src/github/Commit.py index 04908fa9..a48cfd3c 100644 --- a/src/github/Commit.py +++ b/src/github/Commit.py @@ -12,7 +12,7 @@ import CommitStats import Commit import CommitComment -class Commit( GithubObject.CompletableGithubObject ): +class Commit( GithubObject.GithubObject ): @property def author( self ): self._completeIfNeeded( self._author ) diff --git a/src/github/CommitComment.py b/src/github/CommitComment.py index dbd060b6..6ef5a8f3 100644 --- a/src/github/CommitComment.py +++ b/src/github/CommitComment.py @@ -5,7 +5,7 @@ import GithubObject ########## import NamedUser -class CommitComment( GithubObject.CompletableGithubObject ): +class CommitComment( GithubObject.GithubObject ): @property def body( self ): self._completeIfNeeded( self._body ) diff --git a/src/github/CommitFile.py b/src/github/CommitFile.py index 5d667ff6..59b3901d 100644 --- a/src/github/CommitFile.py +++ b/src/github/CommitFile.py @@ -3,7 +3,7 @@ import GithubObject -class CommitFile( GithubObject.GithubObject ): +class CommitFile( GithubObject.BasicGithubObject ): @property def additions( self ): return self._additions diff --git a/src/github/CommitStats.py b/src/github/CommitStats.py index 058a269b..f27e6e5a 100644 --- a/src/github/CommitStats.py +++ b/src/github/CommitStats.py @@ -3,7 +3,7 @@ import GithubObject -class CommitStats( GithubObject.GithubObject ): +class CommitStats( GithubObject.BasicGithubObject ): @property def additions( self ): return self._additions diff --git a/src/github/Download.py b/src/github/Download.py index 626720d4..2cc37df2 100644 --- a/src/github/Download.py +++ b/src/github/Download.py @@ -3,7 +3,7 @@ import GithubObject -class Download( GithubObject.CompletableGithubObject ): +class Download( GithubObject.GithubObject ): @property def accesskeyid( self ): self._completeIfNeeded( self._accesskeyid ) diff --git a/src/github/Event.py b/src/github/Event.py index fc65ef84..64a3f02c 100644 --- a/src/github/Event.py +++ b/src/github/Event.py @@ -7,7 +7,7 @@ import Organization import Repository import NamedUser -class Event( GithubObject.GithubObject ): +class Event( GithubObject.BasicGithubObject ): @property def actor( self ): return self._actor diff --git a/src/github/Gist.py b/src/github/Gist.py index 6cfa6904..f11eaab7 100644 --- a/src/github/Gist.py +++ b/src/github/Gist.py @@ -10,7 +10,7 @@ import NamedUser import Gist import GistComment -class Gist( GithubObject.CompletableGithubObject ): +class Gist( GithubObject.GithubObject ): @property def comments( self ): self._completeIfNeeded( self._comments ) diff --git a/src/github/GistComment.py b/src/github/GistComment.py index 5f5e5d53..411481c5 100644 --- a/src/github/GistComment.py +++ b/src/github/GistComment.py @@ -8,26 +8,32 @@ import NamedUser class GistComment( GithubObject.GithubObject ): @property def body( self ): + self._completeIfNeeded( self._body ) return self._body @property def created_at( self ): + self._completeIfNeeded( self._created_at ) return self._created_at @property def id( self ): + self._completeIfNeeded( self._id ) return self._id @property def updated_at( self ): + self._completeIfNeeded( self._updated_at ) return self._updated_at @property def url( self ): + self._completeIfNeeded( self._url ) return self._url @property def user( self ): + self._completeIfNeeded( self._user ) return self._user def delete( self ): diff --git a/src/github/GistHistoryState.py b/src/github/GistHistoryState.py index d0696997..30d2660b 100644 --- a/src/github/GistHistoryState.py +++ b/src/github/GistHistoryState.py @@ -9,22 +9,27 @@ import CommitStats class GistHistoryState( GithubObject.GithubObject ): @property def change_status( self ): + self._completeIfNeeded( self._change_status ) return self._change_status @property def committed_at( self ): + self._completeIfNeeded( self._committed_at ) return self._committed_at @property def url( self ): + self._completeIfNeeded( self._url ) return self._url @property def user( self ): + self._completeIfNeeded( self._user ) return self._user @property def version( self ): + self._completeIfNeeded( self._version ) return self._version def _initAttributes( self ): diff --git a/src/github/GitAuthor.py b/src/github/GitAuthor.py index cba34bb7..36c71542 100644 --- a/src/github/GitAuthor.py +++ b/src/github/GitAuthor.py @@ -3,7 +3,7 @@ import GithubObject -class GitAuthor( GithubObject.GithubObject ): +class GitAuthor( GithubObject.BasicGithubObject ): @property def date( self ): return self._date diff --git a/src/github/GitBlob.py b/src/github/GitBlob.py index 21cefe10..e451326d 100644 --- a/src/github/GitBlob.py +++ b/src/github/GitBlob.py @@ -6,22 +6,27 @@ import GithubObject class GitBlob( GithubObject.GithubObject ): @property def content( self ): + self._completeIfNeeded( self._content ) return self._content @property def encoding( self ): + self._completeIfNeeded( self._encoding ) return self._encoding @property def sha( self ): + self._completeIfNeeded( self._sha ) return self._sha @property def size( self ): + self._completeIfNeeded( self._size ) return self._size @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def _initAttributes( self ): diff --git a/src/github/GitCommit.py b/src/github/GitCommit.py index 1cc4c638..6cd65f0d 100644 --- a/src/github/GitCommit.py +++ b/src/github/GitCommit.py @@ -10,30 +10,37 @@ import GitTree class GitCommit( GithubObject.GithubObject ): @property def author( self ): + self._completeIfNeeded( self._author ) return self._author @property def committer( self ): + self._completeIfNeeded( self._committer ) return self._committer @property def message( self ): + self._completeIfNeeded( self._message ) return self._message @property def parents( self ): + self._completeIfNeeded( self._parents ) return self._parents @property def sha( self ): + self._completeIfNeeded( self._sha ) return self._sha @property def tree( self ): + self._completeIfNeeded( self._tree ) return self._tree @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def _initAttributes( self ): diff --git a/src/github/GitObject.py b/src/github/GitObject.py index 95a6f24a..b30aa05e 100644 --- a/src/github/GitObject.py +++ b/src/github/GitObject.py @@ -3,7 +3,7 @@ import GithubObject -class GitObject( GithubObject.GithubObject ): +class GitObject( GithubObject.BasicGithubObject ): @property def sha( self ): return self._sha diff --git a/src/github/GitRef.py b/src/github/GitRef.py index 76851116..e6e329ff 100644 --- a/src/github/GitRef.py +++ b/src/github/GitRef.py @@ -9,14 +9,17 @@ import GitObject class GitRef( GithubObject.GithubObject ): @property def object( self ): + self._completeIfNeeded( self._object ) return self._object @property def ref( self ): + self._completeIfNeeded( self._ref ) return self._ref @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def delete( self ): diff --git a/src/github/GitTag.py b/src/github/GitTag.py index 803a8efe..5abd4fb7 100644 --- a/src/github/GitTag.py +++ b/src/github/GitTag.py @@ -9,26 +9,32 @@ import GitObject class GitTag( GithubObject.GithubObject ): @property def message( self ): + self._completeIfNeeded( self._message ) return self._message @property def object( self ): + self._completeIfNeeded( self._object ) return self._object @property def sha( self ): + self._completeIfNeeded( self._sha ) return self._sha @property def tag( self ): + self._completeIfNeeded( self._tag ) return self._tag @property def tagger( self ): + self._completeIfNeeded( self._tagger ) return self._tagger @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def _initAttributes( self ): diff --git a/src/github/GitTree.py b/src/github/GitTree.py index da9fe0cc..7439bf24 100644 --- a/src/github/GitTree.py +++ b/src/github/GitTree.py @@ -8,14 +8,17 @@ import GitTreeElement class GitTree( GithubObject.GithubObject ): @property def sha( self ): + self._completeIfNeeded( self._sha ) return self._sha @property def tree( self ): + self._completeIfNeeded( self._tree ) return self._tree @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def _initAttributes( self ): diff --git a/src/github/GitTreeElement.py b/src/github/GitTreeElement.py index 3b794ad1..e966ac95 100644 --- a/src/github/GitTreeElement.py +++ b/src/github/GitTreeElement.py @@ -3,7 +3,7 @@ import GithubObject -class GitTreeElement( GithubObject.GithubObject ): +class GitTreeElement( GithubObject.BasicGithubObject ): @property def mode( self ): return self._mode diff --git a/src/github/GithubObject.py b/src/github/GithubObject.py index 47524ce4..3939b2c2 100644 --- a/src/github/GithubObject.py +++ b/src/github/GithubObject.py @@ -1,6 +1,6 @@ import GithubException -class GithubObject( object ): +class BasicGithubObject( object ): def __init__( self, requester, attributes, completed ): ### 'completed' may be removed if I find a way self._requester = requester self._initAttributes() @@ -16,9 +16,9 @@ class GithubObject( object ): if status >= 400: # pragma no branch raise GithubException.GithubException( status, data ) # pragma no cover -class CompletableGithubObject( GithubObject ): +class GithubObject( BasicGithubObject ): def __init__( self, requester, attributes, completed ): - GithubObject.__init__( self, requester, attributes, completed ) + BasicGithubObject.__init__( self, requester, attributes, completed ) self.__completed = completed def _completeIfNeeded( self, testedAttribute ): diff --git a/src/github/Hook.py b/src/github/Hook.py index 559a1dde..03ae6dac 100644 --- a/src/github/Hook.py +++ b/src/github/Hook.py @@ -9,38 +9,47 @@ import HookResponse class Hook( GithubObject.GithubObject ): @property def active( self ): + self._completeIfNeeded( self._active ) return self._active @property def config( self ): + self._completeIfNeeded( self._config ) return self._config @property def created_at( self ): + self._completeIfNeeded( self._created_at ) return self._created_at @property def events( self ): + self._completeIfNeeded( self._events ) return self._events @property def id( self ): + self._completeIfNeeded( self._id ) return self._id @property def last_response( self ): + self._completeIfNeeded( self._last_response ) return self._last_response @property def name( self ): + self._completeIfNeeded( self._name ) return self._name @property def updated_at( self ): + self._completeIfNeeded( self._updated_at ) return self._updated_at @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def delete( self ): diff --git a/src/github/HookResponse.py b/src/github/HookResponse.py index 2308bdd4..c9c0d29a 100644 --- a/src/github/HookResponse.py +++ b/src/github/HookResponse.py @@ -3,7 +3,7 @@ import GithubObject -class HookResponse( GithubObject.GithubObject ): +class HookResponse( GithubObject.BasicGithubObject ): @property def code( self ): return self._code diff --git a/src/github/Issue.py b/src/github/Issue.py index 67ec5b0f..00bed3ee 100644 --- a/src/github/Issue.py +++ b/src/github/Issue.py @@ -13,7 +13,7 @@ import Milestone import IssueComment import IssuePullRequest -class Issue( GithubObject.CompletableGithubObject ): +class Issue( GithubObject.GithubObject ): @property def assignee( self ): self._completeIfNeeded( self._assignee ) diff --git a/src/github/IssueComment.py b/src/github/IssueComment.py index e1f305ca..f18e04fe 100644 --- a/src/github/IssueComment.py +++ b/src/github/IssueComment.py @@ -8,26 +8,32 @@ import NamedUser class IssueComment( GithubObject.GithubObject ): @property def body( self ): + self._completeIfNeeded( self._body ) return self._body @property def created_at( self ): + self._completeIfNeeded( self._created_at ) return self._created_at @property def id( self ): + self._completeIfNeeded( self._id ) return self._id @property def updated_at( self ): + self._completeIfNeeded( self._updated_at ) return self._updated_at @property def url( self ): + self._completeIfNeeded( self._url ) return self._url @property def user( self ): + self._completeIfNeeded( self._user ) return self._user def delete( self ): diff --git a/src/github/IssueEvent.py b/src/github/IssueEvent.py index 579134fe..adec035f 100644 --- a/src/github/IssueEvent.py +++ b/src/github/IssueEvent.py @@ -6,7 +6,7 @@ import GithubObject import Issue import NamedUser -class IssueEvent( GithubObject.CompletableGithubObject ): +class IssueEvent( GithubObject.GithubObject ): @property def actor( self ): self._completeIfNeeded( self._actor ) diff --git a/src/github/IssuePullRequest.py b/src/github/IssuePullRequest.py index 4dedaff4..56903591 100644 --- a/src/github/IssuePullRequest.py +++ b/src/github/IssuePullRequest.py @@ -3,7 +3,7 @@ import GithubObject -class IssuePullRequest( GithubObject.GithubObject ): +class IssuePullRequest( GithubObject.BasicGithubObject ): @property def diff_url( self ): return self._diff_url diff --git a/src/github/Label.py b/src/github/Label.py index 51414c84..dd7c49fc 100644 --- a/src/github/Label.py +++ b/src/github/Label.py @@ -8,14 +8,17 @@ import GithubObject class Label( GithubObject.GithubObject ): @property def color( self ): + self._completeIfNeeded( self._color ) return self._color @property def name( self ): + self._completeIfNeeded( self._name ) return self._name @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def delete( self ): diff --git a/src/github/Milestone.py b/src/github/Milestone.py index ad3f987c..963ddf60 100644 --- a/src/github/Milestone.py +++ b/src/github/Milestone.py @@ -11,46 +11,57 @@ import Label class Milestone( GithubObject.GithubObject ): @property def closed_issues( self ): + self._completeIfNeeded( self._closed_issues ) return self._closed_issues @property def created_at( self ): + self._completeIfNeeded( self._created_at ) return self._created_at @property def creator( self ): + self._completeIfNeeded( self._creator ) return self._creator @property def description( self ): + self._completeIfNeeded( self._description ) return self._description @property def due_on( self ): + self._completeIfNeeded( self._due_on ) return self._due_on @property def id( self ): + self._completeIfNeeded( self._id ) return self._id @property def number( self ): + self._completeIfNeeded( self._number ) return self._number @property def open_issues( self ): + self._completeIfNeeded( self._open_issues ) return self._open_issues @property def state( self ): + self._completeIfNeeded( self._state ) return self._state @property def title( self ): + self._completeIfNeeded( self._title ) return self._title @property def url( self ): + self._completeIfNeeded( self._url ) return self._url def delete( self ): diff --git a/src/github/NamedUser.py b/src/github/NamedUser.py index 8221c22e..1165b139 100644 --- a/src/github/NamedUser.py +++ b/src/github/NamedUser.py @@ -12,7 +12,7 @@ import Plan import Organization import Event -class NamedUser( GithubObject.CompletableGithubObject ): +class NamedUser( GithubObject.GithubObject ): @property def avatar_url( self ): self._completeIfNeeded( self._avatar_url ) diff --git a/src/github/Organization.py b/src/github/Organization.py index 4df94ff4..874a6310 100644 --- a/src/github/Organization.py +++ b/src/github/Organization.py @@ -11,7 +11,7 @@ import Event import Repository import NamedUser -class Organization( GithubObject.CompletableGithubObject ): +class Organization( GithubObject.GithubObject ): @property def avatar_url( self ): self._completeIfNeeded( self._avatar_url ) diff --git a/src/github/Permissions.py b/src/github/Permissions.py index 0cf13191..91b2c4c1 100644 --- a/src/github/Permissions.py +++ b/src/github/Permissions.py @@ -3,7 +3,7 @@ import GithubObject -class Permissions( GithubObject.GithubObject ): +class Permissions( GithubObject.BasicGithubObject ): @property def admin( self ): return self._admin diff --git a/src/github/Plan.py b/src/github/Plan.py index 6eb560a7..b344fae7 100644 --- a/src/github/Plan.py +++ b/src/github/Plan.py @@ -3,7 +3,7 @@ import GithubObject -class Plan( GithubObject.GithubObject ): +class Plan( GithubObject.BasicGithubObject ): @property def collaborators( self ): return self._collaborators diff --git a/src/github/PullRequest.py b/src/github/PullRequest.py index 18afbfe4..0911c32f 100644 --- a/src/github/PullRequest.py +++ b/src/github/PullRequest.py @@ -11,7 +11,7 @@ import PullRequestMergeStatus import PullRequestComment import PullRequestFile -class PullRequest( GithubObject.CompletableGithubObject ): +class PullRequest( GithubObject.GithubObject ): @property def additions( self ): self._completeIfNeeded( self._additions ) diff --git a/src/github/PullRequestComment.py b/src/github/PullRequestComment.py index c83de049..d7224496 100644 --- a/src/github/PullRequestComment.py +++ b/src/github/PullRequestComment.py @@ -5,7 +5,7 @@ import GithubObject ########## import NamedUser -class PullRequestComment( GithubObject.CompletableGithubObject ): +class PullRequestComment( GithubObject.GithubObject ): @property def body( self ): self._completeIfNeeded( self._body ) diff --git a/src/github/PullRequestFile.py b/src/github/PullRequestFile.py index caa00792..419332eb 100644 --- a/src/github/PullRequestFile.py +++ b/src/github/PullRequestFile.py @@ -3,7 +3,7 @@ import GithubObject -class PullRequestFile( GithubObject.GithubObject ): +class PullRequestFile( GithubObject.BasicGithubObject ): @property def additions( self ): return self._additions diff --git a/src/github/PullRequestMergeStatus.py b/src/github/PullRequestMergeStatus.py index ac3f5b1a..32f788da 100644 --- a/src/github/PullRequestMergeStatus.py +++ b/src/github/PullRequestMergeStatus.py @@ -3,7 +3,7 @@ import GithubObject -class PullRequestMergeStatus( GithubObject.GithubObject ): +class PullRequestMergeStatus( GithubObject.BasicGithubObject ): @property def merged( self ): return self._merged diff --git a/src/github/Repository.py b/src/github/Repository.py index c32b23b8..3da025bd 100644 --- a/src/github/Repository.py +++ b/src/github/Repository.py @@ -31,7 +31,7 @@ import GitTag import Download import Event -class Repository( GithubObject.CompletableGithubObject ): +class Repository( GithubObject.GithubObject ): @property def clone_url( self ): self._completeIfNeeded( self._clone_url ) diff --git a/src/github/RepositoryKey.py b/src/github/RepositoryKey.py index bbdc191d..12b55dc1 100644 --- a/src/github/RepositoryKey.py +++ b/src/github/RepositoryKey.py @@ -15,22 +15,27 @@ class RepositoryKey( GithubObject.GithubObject ): @property def id( self ): + self._completeIfNeeded( self._id ) return self._id @property def key( self ): + self._completeIfNeeded( self._key ) return self._key @property def title( self ): + self._completeIfNeeded( self._title ) return self._title @property def url( self ): + self._completeIfNeeded( self._url ) return self._url @property def verified( self ): + self._completeIfNeeded( self._verified ) return self._verified def delete( self ): diff --git a/src/github/Tag.py b/src/github/Tag.py index b5f43609..59561240 100644 --- a/src/github/Tag.py +++ b/src/github/Tag.py @@ -5,7 +5,7 @@ import GithubObject ########## import Commit -class Tag( GithubObject.GithubObject ): +class Tag( GithubObject.BasicGithubObject ): @property def commit( self ): return self._commit diff --git a/src/github/Team.py b/src/github/Team.py index 49b87577..52ef155c 100644 --- a/src/github/Team.py +++ b/src/github/Team.py @@ -8,7 +8,7 @@ from DefaultValueForOptionalParameters import DefaultValueForOptionalParameters import Repository import NamedUser -class Team( GithubObject.CompletableGithubObject ): +class Team( GithubObject.GithubObject ): @property def id( self ): self._completeIfNeeded( self._id ) diff --git a/src/github/UserKey.py b/src/github/UserKey.py index fe8f440e..66474a20 100644 --- a/src/github/UserKey.py +++ b/src/github/UserKey.py @@ -4,7 +4,7 @@ import GithubObject from DefaultValueForOptionalParameters import DefaultValueForOptionalParameters -class UserKey( GithubObject.CompletableGithubObject ): +class UserKey( GithubObject.GithubObject ): @property def id( self ): self._completeIfNeeded( self._id )