mirror of
https://github.com/status-im/PyGithub.git
synced 2026-09-02 11:51:10 +00:00
Do not try to __complete objects without url
This commit is contained in:
@@ -15,27 +15,21 @@ class Tag( object ):
|
||||
self.__completed = False
|
||||
self.__initAttributes()
|
||||
self.__useAttributes( attributes )
|
||||
if not lazy:
|
||||
self.__complete()
|
||||
|
||||
@property
|
||||
def commit( self ):
|
||||
self.__completeIfNeeded( self.__commit )
|
||||
return self.__commit
|
||||
|
||||
@property
|
||||
def name( self ):
|
||||
self.__completeIfNeeded( self.__name )
|
||||
return self.__name
|
||||
|
||||
@property
|
||||
def tarball_url( self ):
|
||||
self.__completeIfNeeded( self.__tarball_url )
|
||||
return self.__tarball_url
|
||||
|
||||
@property
|
||||
def zipball_url( self ):
|
||||
self.__completeIfNeeded( self.__zipball_url )
|
||||
return self.__zipball_url
|
||||
|
||||
def __initAttributes( self ):
|
||||
@@ -44,21 +38,6 @@ class Tag( object ):
|
||||
self.__tarball_url = None
|
||||
self.__zipball_url = None
|
||||
|
||||
def __completeIfNeeded( self, testedAttribute ):
|
||||
if not self.__completed and testedAttribute is None:
|
||||
self.__complete()
|
||||
|
||||
# @todo Do not generate __complete if type has no url attribute
|
||||
def __complete( self ):
|
||||
status, headers, data = self.__requester.request(
|
||||
"GET",
|
||||
self.__url,
|
||||
None,
|
||||
None
|
||||
)
|
||||
self.__useAttributes( data )
|
||||
self.__completed = True
|
||||
|
||||
def __useAttributes( self, attributes ):
|
||||
#@todo No need to check if attribute is in attributes when attribute is mandatory
|
||||
if "commit" in attributes and attributes[ "commit" ] is not None:
|
||||
|
||||
Reference in New Issue
Block a user