Do not try to __complete objects without url

This commit is contained in:
Vincent Jacques
2012-05-08 21:36:07 +02:00
parent 824b45490d
commit bc08112dce
33 changed files with 13 additions and 115 deletions
-21
View File
@@ -14,27 +14,21 @@ class Plan( object ):
self.__completed = False
self.__initAttributes()
self.__useAttributes( attributes )
if not lazy:
self.__complete()
@property
def collaborators( self ):
self.__completeIfNeeded( self.__collaborators )
return self.__collaborators
@property
def name( self ):
self.__completeIfNeeded( self.__name )
return self.__name
@property
def private_repos( self ):
self.__completeIfNeeded( self.__private_repos )
return self.__private_repos
@property
def space( self ):
self.__completeIfNeeded( self.__space )
return self.__space
def __initAttributes( self ):
@@ -43,21 +37,6 @@ class Plan( object ):
self.__private_repos = None
self.__space = None
def __completeIfNeeded( self, testedAttribute ):
if not self.__completed and testedAttribute is None:
self.__complete()
# @todo Do not generate __complete if type has no url attribute
def __complete( self ):
status, headers, data = self.__requester.request(
"GET",
self.__url,
None,
None
)
self.__useAttributes( data )
self.__completed = True
def __useAttributes( self, attributes ):
#@todo No need to check if attribute is in attributes when attribute is mandatory
if "collaborators" in attributes and attributes[ "collaborators" ] is not None: