status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-02 03:41:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not assert that we know all the attributes we receive

Browse Source
This commit is contained in:
Vincent Jacques
2012-05-27 12:19:45 +01:00
parent c5c1f8de07
commit 855cc5dbd6
42 changed files with 0 additions and 128 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/github/CommitComment.py
-3
View File
@@ -117,9 +117,6 @@ class CommitComment( object ):
self.__completed = True
def __useAttributes( self, attributes ):
# @todo Remove this debug weakness: we shall assume that github will add new attributes
for attribute in attributes:
assert attribute in [ "body", "commit_id", "created_at", "html_url", "id", "line", "path", "position", "updated_at", "url", "user", ], attribute
# @todo No need to check if attribute is in attributes when attribute is mandatory
if "body" in attributes and attributes[ "body" ] is not None: # pragma no branch
assert isinstance( attributes[ "body" ], ( str, unicode ) )