From 722f253429edde97ddaaeaeed8f1736a5325f0c8 Mon Sep 17 00:00:00 2001 From: Wan Liuyang Date: Thu, 5 Apr 2018 10:23:01 +0800 Subject: [PATCH] Remove edit for UserKey as it's immutable now --- github/UserKey.py | 21 ------------------- .../UserKey.testEditWithAllArguments.txt | 11 ---------- .../UserKey.testEditWithoutArguments.txt | 11 ---------- github/tests/UserKey.py | 8 ------- 4 files changed, 51 deletions(-) delete mode 100644 github/tests/ReplayData/UserKey.testEditWithAllArguments.txt delete mode 100644 github/tests/ReplayData/UserKey.testEditWithoutArguments.txt diff --git a/github/UserKey.py b/github/UserKey.py index 4d2aeb47..19baafb4 100644 --- a/github/UserKey.py +++ b/github/UserKey.py @@ -91,27 +91,6 @@ class UserKey(github.GithubObject.CompletableGithubObject): self.url ) - def edit(self, title=github.GithubObject.NotSet, key=github.GithubObject.NotSet): - """ - :calls: `PATCH /user/keys/:id `_ - :param title: string - :param key: string - :rtype: None - """ - assert title is github.GithubObject.NotSet or isinstance(title, (str, unicode)), title - assert key is github.GithubObject.NotSet or isinstance(key, (str, unicode)), key - post_parameters = dict() - if title is not github.GithubObject.NotSet: - post_parameters["title"] = title - if key is not github.GithubObject.NotSet: - post_parameters["key"] = key - headers, data = self._requester.requestJsonAndCheck( - "PATCH", - self.url, - input=post_parameters - ) - self._useAttributes(data) - def _initAttributes(self): self._id = github.GithubObject.NotSet self._key = github.GithubObject.NotSet diff --git a/github/tests/ReplayData/UserKey.testEditWithAllArguments.txt b/github/tests/ReplayData/UserKey.testEditWithAllArguments.txt deleted file mode 100644 index f9685bf3..00000000 --- a/github/tests/ReplayData/UserKey.testEditWithAllArguments.txt +++ /dev/null @@ -1,11 +0,0 @@ -https -PATCH -api.github.com -None -/user/keys/2626650 -{'Content-Type': 'application/json', 'Authorization': 'Basic login_and_password_removed', 'User-Agent': 'PyGithub/Python'} -{"key": "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA5Q58YmzZjU64prR5Pk91MfeHezOTgLqDYmepYbv3qjguiHtPai1vSai5WvUv3hgf9DArXsXE5CV6yoBIhAdGtpJKExHuQ2m4XTFCdbrgfQ3ypcSdgzEiQemyTA6TWwhbuwjJ1IqJMYOVLH+FBCkD8pyIpUDO7v3vaR2TCEuNwOS7lbsRsW3OkGYnUKjaPaCTe/inrqb7I3OE8cPhWJ3dM/zzzBj22J4LCNKhjKua8TFS74xGm3lNDZ6/twQl4n4xmrH/3tG+WOJicNO3JohNHqK9T0pILnr3epEyfdkBjcG0qXApqWvH2WipJhaH6of8Gdr0Z/K/7p8QFddmwNgdPQ==", "title": "Title edited by PyGithub"} -200 -[('status', '200 OK'), ('x-ratelimit-remaining', '4979'), ('content-length', '503'), ('server', 'nginx/1.0.13'), ('connection', 'keep-alive'), ('x-ratelimit-limit', '5000'), ('etag', '"b3e0d8e43865724d6f36f15753984816"'), ('date', 'Sat, 26 May 2012 19:57:25 GMT'), ('content-type', 'application/json; charset=utf-8')] -{"url":"https://api.github.com/user/keys/2626650","verified":true,"key":"ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA5Q58YmzZjU64prR5Pk91MfeHezOTgLqDYmepYbv3qjguiHtPai1vSai5WvUv3hgf9DArXsXE5CV6yoBIhAdGtpJKExHuQ2m4XTFCdbrgfQ3ypcSdgzEiQemyTA6TWwhbuwjJ1IqJMYOVLH+FBCkD8pyIpUDO7v3vaR2TCEuNwOS7lbsRsW3OkGYnUKjaPaCTe/inrqb7I3OE8cPhWJ3dM/zzzBj22J4LCNKhjKua8TFS74xGm3lNDZ6/twQl4n4xmrH/3tG+WOJicNO3JohNHqK9T0pILnr3epEyfdkBjcG0qXApqWvH2WipJhaH6of8Gdr0Z/K/7p8QFddmwNgdPQ==","title":"Title edited by PyGithub","id":2626650} - diff --git a/github/tests/ReplayData/UserKey.testEditWithoutArguments.txt b/github/tests/ReplayData/UserKey.testEditWithoutArguments.txt deleted file mode 100644 index a0d18422..00000000 --- a/github/tests/ReplayData/UserKey.testEditWithoutArguments.txt +++ /dev/null @@ -1,11 +0,0 @@ -https -PATCH -api.github.com -None -/user/keys/2626650 -{'Content-Type': 'application/json', 'Authorization': 'Basic login_and_password_removed', 'User-Agent': 'PyGithub/Python'} -{} -200 -[('status', '200 OK'), ('x-ratelimit-remaining', '4981'), ('content-length', '505'), ('server', 'nginx/1.0.13'), ('connection', 'keep-alive'), ('x-ratelimit-limit', '5000'), ('etag', '"7261ec55c886d6bf42e48d5bf9544586"'), ('date', 'Sat, 26 May 2012 19:57:18 GMT'), ('content-type', 'application/json; charset=utf-8')] -{"url":"https://api.github.com/user/keys/2626650","key":"ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA2Mm0RjTNAYFfSCtUpO54usdseroUSIYg5KX4JoseTpqyiB/hqewjYLAdUq/tNIQzrkoEJWSyZrQt0ma7/YCyMYuNGd3DU6q6ZAyBeY3E9RyCiKjO3aTL2VKQGFvBVVmGdxGVSCITRphAcsKc/PF35/fg9XP9S0anMXcEFtdfMHz41SSw+XtE+Vc+6cX9FuI5qUfLGbkv8L1v3g4uw9VXlzq4GfTA+1S7D6mcoGHopAIXFlVr+2RfDKdSURMcB22z41fljO1MW4+zUS/4FyUTpL991es5fcwKXYoiE+x06VJeJJ1Krwx+DZj45uweV6cHXt2JwJEI9fWB6WyBlDejWw==","verified":true,"title":"Key added through PyGithub","id":2626650} - diff --git a/github/tests/UserKey.py b/github/tests/UserKey.py index d4376942..b353530e 100644 --- a/github/tests/UserKey.py +++ b/github/tests/UserKey.py @@ -46,13 +46,5 @@ class UserKey(Framework.TestCase): # test __repr__() based on this attributes self.assertEqual(self.key.__repr__(), 'UserKey(title="Key added through PyGithub", id=2626650)') - def testEditWithoutArguments(self): - self.key.edit() - - def testEditWithAllArguments(self): - self.key.edit("Title edited by PyGithub", "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA5Q58YmzZjU64prR5Pk91MfeHezOTgLqDYmepYbv3qjguiHtPai1vSai5WvUv3hgf9DArXsXE5CV6yoBIhAdGtpJKExHuQ2m4XTFCdbrgfQ3ypcSdgzEiQemyTA6TWwhbuwjJ1IqJMYOVLH+FBCkD8pyIpUDO7v3vaR2TCEuNwOS7lbsRsW3OkGYnUKjaPaCTe/inrqb7I3OE8cPhWJ3dM/zzzBj22J4LCNKhjKua8TFS74xGm3lNDZ6/twQl4n4xmrH/3tG+WOJicNO3JohNHqK9T0pILnr3epEyfdkBjcG0qXApqWvH2WipJhaH6of8Gdr0Z/K/7p8QFddmwNgdPQ==") - self.assertEqual(self.key.key, "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA5Q58YmzZjU64prR5Pk91MfeHezOTgLqDYmepYbv3qjguiHtPai1vSai5WvUv3hgf9DArXsXE5CV6yoBIhAdGtpJKExHuQ2m4XTFCdbrgfQ3ypcSdgzEiQemyTA6TWwhbuwjJ1IqJMYOVLH+FBCkD8pyIpUDO7v3vaR2TCEuNwOS7lbsRsW3OkGYnUKjaPaCTe/inrqb7I3OE8cPhWJ3dM/zzzBj22J4LCNKhjKua8TFS74xGm3lNDZ6/twQl4n4xmrH/3tG+WOJicNO3JohNHqK9T0pILnr3epEyfdkBjcG0qXApqWvH2WipJhaH6of8Gdr0Z/K/7p8QFddmwNgdPQ==") - self.assertEqual(self.key.title, "Title edited by PyGithub") - def testDelete(self): self.key.delete()