From 6945921c529be14c3a8f566dd1e483674516d46d Mon Sep 17 00:00:00 2001 From: Vincent Jacques Date: Sat, 12 May 2012 15:29:15 +0200 Subject: [PATCH] Use NoCompletion when creating an object from the result of a request --- .../GithubObject.MethodBody.UseResult.py | 2 +- src/github/AuthenticatedUser.py | 16 +++--- src/github/Commit.py | 2 +- src/github/Gist.py | 6 +-- src/github/Issue.py | 4 +- src/github/NamedUser.py | 4 +- src/github/Organization.py | 8 +-- src/github/PullRequest.py | 2 +- src/github/Repository.py | 52 +++++++++---------- test/ReplayData/Repository.testAttributes.txt | 5 -- 10 files changed, 48 insertions(+), 53 deletions(-) diff --git a/codegen/templates/GithubObject.MethodBody.UseResult.py b/codegen/templates/GithubObject.MethodBody.UseResult.py index 5eae0955..9bd87eec 100644 --- a/codegen/templates/GithubObject.MethodBody.UseResult.py +++ b/codegen/templates/GithubObject.MethodBody.UseResult.py @@ -23,7 +23,7 @@ {% else %} {% if method.type.cardinality == "scalar" %} - return {% if method.type.name != class.name %}{{ method.type.name }}.{% endif %}{{ method.type.name }}( self.__requester, data, completion = LazyCompletion ) + return {% if method.type.name != class.name %}{{ method.type.name }}.{% endif %}{{ method.type.name }}( self.__requester, data, completion = NoCompletion ) {% endif %} {% if method.type.cardinality == "list" %} diff --git a/src/github/AuthenticatedUser.py b/src/github/AuthenticatedUser.py index 3259e174..ac12ae7b 100644 --- a/src/github/AuthenticatedUser.py +++ b/src/github/AuthenticatedUser.py @@ -187,7 +187,7 @@ class AuthenticatedUser( object ): None, post_parameters ) - return Authorization.Authorization( self.__requester, data, completion = LazyCompletion ) + return Authorization.Authorization( self.__requester, data, completion = NoCompletion ) def create_fork( self, repo ): status, headers, data = self.__requester.request( @@ -196,7 +196,7 @@ class AuthenticatedUser( object ): None, None ) - return Repository.Repository( self.__requester, data, completion = LazyCompletion ) + return Repository.Repository( self.__requester, data, completion = NoCompletion ) def create_gist( self, public, files, description = DefaultValueForOptionalParameters ): post_parameters = { @@ -211,7 +211,7 @@ class AuthenticatedUser( object ): None, post_parameters ) - return Gist.Gist( self.__requester, data, completion = LazyCompletion ) + return Gist.Gist( self.__requester, data, completion = NoCompletion ) def create_key( self, title, key ): post_parameters = { @@ -224,7 +224,7 @@ class AuthenticatedUser( object ): None, post_parameters ) - return UserKey.UserKey( self.__requester, data, completion = LazyCompletion ) + return UserKey.UserKey( self.__requester, data, completion = NoCompletion ) def create_repo( self, name, description = DefaultValueForOptionalParameters, homepage = DefaultValueForOptionalParameters, private = DefaultValueForOptionalParameters, has_issues = DefaultValueForOptionalParameters, has_wiki = DefaultValueForOptionalParameters, has_downloads = DefaultValueForOptionalParameters, team_id = DefaultValueForOptionalParameters ): post_parameters = { @@ -250,7 +250,7 @@ class AuthenticatedUser( object ): None, post_parameters ) - return Repository.Repository( self.__requester, data, completion = LazyCompletion ) + return Repository.Repository( self.__requester, data, completion = NoCompletion ) def edit( self, name = DefaultValueForOptionalParameters, email = DefaultValueForOptionalParameters, blog = DefaultValueForOptionalParameters, company = DefaultValueForOptionalParameters, location = DefaultValueForOptionalParameters, hireable = DefaultValueForOptionalParameters, bio = DefaultValueForOptionalParameters ): post_parameters = { @@ -284,7 +284,7 @@ class AuthenticatedUser( object ): None, None ) - return Authorization.Authorization( self.__requester, data, completion = LazyCompletion ) + return Authorization.Authorization( self.__requester, data, completion = NoCompletion ) def get_authorizations( self ): status, headers, data = self.__requester.request( @@ -386,7 +386,7 @@ class AuthenticatedUser( object ): None, None ) - return UserKey.UserKey( self.__requester, data, completion = LazyCompletion ) + return UserKey.UserKey( self.__requester, data, completion = NoCompletion ) def get_keys( self ): status, headers, data = self.__requester.request( @@ -437,7 +437,7 @@ class AuthenticatedUser( object ): None, None ) - return Repository.Repository( self.__requester, data, completion = LazyCompletion ) + return Repository.Repository( self.__requester, data, completion = NoCompletion ) def get_repos( self, type = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( diff --git a/src/github/Commit.py b/src/github/Commit.py index 4cf97132..a67011b2 100644 --- a/src/github/Commit.py +++ b/src/github/Commit.py @@ -77,7 +77,7 @@ class Commit( object ): None, post_parameters ) - return CommitComment.CommitComment( self.__requester, data, completion = LazyCompletion ) + return CommitComment.CommitComment( self.__requester, data, completion = NoCompletion ) def get_comments( self ): status, headers, data = self.__requester.request( diff --git a/src/github/Gist.py b/src/github/Gist.py index faafbfea..322f2d2d 100644 --- a/src/github/Gist.py +++ b/src/github/Gist.py @@ -96,7 +96,7 @@ class Gist( object ): None, post_parameters ) - return GistComment.GistComment( self.__requester, data, completion = LazyCompletion ) + return GistComment.GistComment( self.__requester, data, completion = NoCompletion ) def create_fork( self ): status, headers, data = self.__requester.request( @@ -105,7 +105,7 @@ class Gist( object ): None, None ) - return Gist( self.__requester, data, completion = LazyCompletion ) + return Gist( self.__requester, data, completion = NoCompletion ) def delete( self ): status, headers, data = self.__requester.request( @@ -137,7 +137,7 @@ class Gist( object ): None, None ) - return GistComment.GistComment( self.__requester, data, completion = LazyCompletion ) + return GistComment.GistComment( self.__requester, data, completion = NoCompletion ) def get_comments( self ): status, headers, data = self.__requester.request( diff --git a/src/github/Issue.py b/src/github/Issue.py index d548c70c..df79becf 100644 --- a/src/github/Issue.py +++ b/src/github/Issue.py @@ -122,7 +122,7 @@ class Issue( object ): None, post_parameters ) - return IssueComment.IssueComment( self.__requester, data, completion = LazyCompletion ) + return IssueComment.IssueComment( self.__requester, data, completion = NoCompletion ) def delete_labels( self ): pass @@ -157,7 +157,7 @@ class Issue( object ): None, None ) - return IssueComment.IssueComment( self.__requester, data, completion = LazyCompletion ) + return IssueComment.IssueComment( self.__requester, data, completion = NoCompletion ) def get_comments( self ): status, headers, data = self.__requester.request( diff --git a/src/github/NamedUser.py b/src/github/NamedUser.py index 488ed25a..6799c7f5 100644 --- a/src/github/NamedUser.py +++ b/src/github/NamedUser.py @@ -161,7 +161,7 @@ class NamedUser( object ): None, post_parameters ) - return Gist.Gist( self.__requester, data, completion = LazyCompletion ) + return Gist.Gist( self.__requester, data, completion = NoCompletion ) def get_events( self ): status, headers, data = self.__requester.request( @@ -282,7 +282,7 @@ class NamedUser( object ): None, None ) - return Repository.Repository( self.__requester, data, completion = LazyCompletion ) + return Repository.Repository( self.__requester, data, completion = NoCompletion ) def get_repos( self, type = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( diff --git a/src/github/Organization.py b/src/github/Organization.py index 0e21a627..28c32abd 100644 --- a/src/github/Organization.py +++ b/src/github/Organization.py @@ -156,7 +156,7 @@ class Organization( object ): url_parameters, None ) - return Repository.Repository( self.__requester, data, completion = LazyCompletion ) + return Repository.Repository( self.__requester, data, completion = NoCompletion ) def create_repo( self, name, description = DefaultValueForOptionalParameters, homepage = DefaultValueForOptionalParameters, private = DefaultValueForOptionalParameters, has_issues = DefaultValueForOptionalParameters, has_wiki = DefaultValueForOptionalParameters, has_downloads = DefaultValueForOptionalParameters, team_id = DefaultValueForOptionalParameters ): post_parameters = { @@ -182,7 +182,7 @@ class Organization( object ): None, post_parameters ) - return Repository.Repository( self.__requester, data, completion = LazyCompletion ) + return Repository.Repository( self.__requester, data, completion = NoCompletion ) def create_team( self, name, repo_names = DefaultValueForOptionalParameters, permission = DefaultValueForOptionalParameters ): post_parameters = { @@ -198,7 +198,7 @@ class Organization( object ): None, post_parameters ) - return Team.Team( self.__requester, data, completion = LazyCompletion ) + return Team.Team( self.__requester, data, completion = NoCompletion ) def edit( self, billing_email = DefaultValueForOptionalParameters, blog = DefaultValueForOptionalParameters, company = DefaultValueForOptionalParameters, email = DefaultValueForOptionalParameters, location = DefaultValueForOptionalParameters, name = DefaultValueForOptionalParameters ): post_parameters = { @@ -272,7 +272,7 @@ class Organization( object ): None, None ) - return Repository.Repository( self.__requester, data, completion = LazyCompletion ) + return Repository.Repository( self.__requester, data, completion = NoCompletion ) def get_repos( self, type = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( diff --git a/src/github/PullRequest.py b/src/github/PullRequest.py index 8a440241..79d93c71 100644 --- a/src/github/PullRequest.py +++ b/src/github/PullRequest.py @@ -171,7 +171,7 @@ class PullRequest( object ): None, None ) - return PullRequestComment.PullRequestComment( self.__requester, data, completion = LazyCompletion ) + return PullRequestComment.PullRequestComment( self.__requester, data, completion = NoCompletion ) def get_comments( self ): status, headers, data = self.__requester.request( diff --git a/src/github/Repository.py b/src/github/Repository.py index e9efc74b..edb40b72 100644 --- a/src/github/Repository.py +++ b/src/github/Repository.py @@ -218,7 +218,7 @@ class Repository( object ): None, post_parameters ) - return Download.Download( self.__requester, data, completion = LazyCompletion ) + return Download.Download( self.__requester, data, completion = NoCompletion ) def create_git_blob( self, content, encoding ): post_parameters = { @@ -231,7 +231,7 @@ class Repository( object ): None, post_parameters ) - return GitBlob.GitBlob( self.__requester, data, completion = LazyCompletion ) + return GitBlob.GitBlob( self.__requester, data, completion = NoCompletion ) def create_git_commit( self, message, tree, parents, author = DefaultValueForOptionalParameters, committer = DefaultValueForOptionalParameters ): post_parameters = { @@ -249,7 +249,7 @@ class Repository( object ): None, post_parameters ) - return GitCommit.GitCommit( self.__requester, data, completion = LazyCompletion ) + return GitCommit.GitCommit( self.__requester, data, completion = NoCompletion ) def create_git_ref( self, ref, sha ): post_parameters = { @@ -262,7 +262,7 @@ class Repository( object ): None, post_parameters ) - return GitRef.GitRef( self.__requester, data, completion = LazyCompletion ) + return GitRef.GitRef( self.__requester, data, completion = NoCompletion ) def create_git_tag( self, tag, message, object, type, tagger = DefaultValueForOptionalParameters ): post_parameters = { @@ -279,7 +279,7 @@ class Repository( object ): None, post_parameters ) - return GitTag.GitTag( self.__requester, data, completion = LazyCompletion ) + return GitTag.GitTag( self.__requester, data, completion = NoCompletion ) def create_git_tree( self, tree, base_tree = DefaultValueForOptionalParameters ): post_parameters = { @@ -293,7 +293,7 @@ class Repository( object ): None, post_parameters ) - return GitTree.GitTree( self.__requester, data, completion = LazyCompletion ) + return GitTree.GitTree( self.__requester, data, completion = NoCompletion ) def create_hook( self, name, config, events = DefaultValueForOptionalParameters, active = DefaultValueForOptionalParameters ): post_parameters = { @@ -310,7 +310,7 @@ class Repository( object ): None, post_parameters ) - return Hook.Hook( self.__requester, data, completion = LazyCompletion ) + return Hook.Hook( self.__requester, data, completion = NoCompletion ) def create_issue( self, title, body = DefaultValueForOptionalParameters, assignee = DefaultValueForOptionalParameters, milestone = DefaultValueForOptionalParameters, labels = DefaultValueForOptionalParameters ): post_parameters = { @@ -330,7 +330,7 @@ class Repository( object ): None, post_parameters ) - return Issue.Issue( self.__requester, data, completion = LazyCompletion ) + return Issue.Issue( self.__requester, data, completion = NoCompletion ) def create_key( self, title, key ): post_parameters = { @@ -343,7 +343,7 @@ class Repository( object ): None, post_parameters ) - return RepositoryKey.RepositoryKey( self.__requester, data, completion = LazyCompletion ) + return RepositoryKey.RepositoryKey( self.__requester, data, completion = NoCompletion ) def create_label( self, name, color ): post_parameters = { @@ -356,7 +356,7 @@ class Repository( object ): None, post_parameters ) - return Label.Label( self.__requester, data, completion = LazyCompletion ) + return Label.Label( self.__requester, data, completion = NoCompletion ) def create_milestone( self, title, state = DefaultValueForOptionalParameters, description = DefaultValueForOptionalParameters, due_on = DefaultValueForOptionalParameters ): post_parameters = { @@ -374,7 +374,7 @@ class Repository( object ): None, post_parameters ) - return Milestone.Milestone( self.__requester, data, completion = LazyCompletion ) + return Milestone.Milestone( self.__requester, data, completion = NoCompletion ) def edit( self, name, description = DefaultValueForOptionalParameters, homepage = DefaultValueForOptionalParameters, public = DefaultValueForOptionalParameters, has_issues = DefaultValueForOptionalParameters, has_wiki = DefaultValueForOptionalParameters, has_downloads = DefaultValueForOptionalParameters ): post_parameters = { @@ -435,7 +435,7 @@ class Repository( object ): None, None ) - return CommitComment.CommitComment( self.__requester, data, completion = LazyCompletion ) + return CommitComment.CommitComment( self.__requester, data, completion = NoCompletion ) def get_comments( self ): status, headers, data = self.__requester.request( @@ -458,7 +458,7 @@ class Repository( object ): None, None ) - return Commit.Commit( self.__requester, data, completion = LazyCompletion ) + return Commit.Commit( self.__requester, data, completion = NoCompletion ) def get_commits( self, sha = DefaultValueForOptionalParameters, path = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( @@ -495,7 +495,7 @@ class Repository( object ): None, None ) - return Download.Download( self.__requester, data, completion = LazyCompletion ) + return Download.Download( self.__requester, data, completion = NoCompletion ) def get_downloads( self ): status, headers, data = self.__requester.request( @@ -546,7 +546,7 @@ class Repository( object ): None, None ) - return GitBlob.GitBlob( self.__requester, data, completion = LazyCompletion ) + return GitBlob.GitBlob( self.__requester, data, completion = NoCompletion ) def get_git_commit( self, sha ): status, headers, data = self.__requester.request( @@ -555,7 +555,7 @@ class Repository( object ): None, None ) - return GitCommit.GitCommit( self.__requester, data, completion = LazyCompletion ) + return GitCommit.GitCommit( self.__requester, data, completion = NoCompletion ) def get_git_ref( self, ref ): status, headers, data = self.__requester.request( @@ -564,7 +564,7 @@ class Repository( object ): None, None ) - return GitRef.GitRef( self.__requester, data, completion = LazyCompletion ) + return GitRef.GitRef( self.__requester, data, completion = NoCompletion ) def get_git_refs( self ): status, headers, data = self.__requester.request( @@ -587,7 +587,7 @@ class Repository( object ): None, None ) - return GitTag.GitTag( self.__requester, data, completion = LazyCompletion ) + return GitTag.GitTag( self.__requester, data, completion = NoCompletion ) def get_git_tree( self, sha, recursive = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( @@ -596,7 +596,7 @@ class Repository( object ): None, None ) - return GitTree.GitTree( self.__requester, data, completion = LazyCompletion ) + return GitTree.GitTree( self.__requester, data, completion = NoCompletion ) def get_hook( self, id ): status, headers, data = self.__requester.request( @@ -605,7 +605,7 @@ class Repository( object ): None, None ) - return Hook.Hook( self.__requester, data, completion = LazyCompletion ) + return Hook.Hook( self.__requester, data, completion = NoCompletion ) def get_hooks( self ): status, headers, data = self.__requester.request( @@ -628,7 +628,7 @@ class Repository( object ): None, None ) - return Issue.Issue( self.__requester, data, completion = LazyCompletion ) + return Issue.Issue( self.__requester, data, completion = NoCompletion ) def get_issues( self, milestone = DefaultValueForOptionalParameters, state = DefaultValueForOptionalParameters, assignee = DefaultValueForOptionalParameters, mentioned = DefaultValueForOptionalParameters, labels = DefaultValueForOptionalParameters, sort = DefaultValueForOptionalParameters, direction = DefaultValueForOptionalParameters, since = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( @@ -651,7 +651,7 @@ class Repository( object ): None, None ) - return IssueEvent.IssueEvent( self.__requester, data, completion = LazyCompletion ) + return IssueEvent.IssueEvent( self.__requester, data, completion = NoCompletion ) def get_issues_events( self ): status, headers, data = self.__requester.request( @@ -674,7 +674,7 @@ class Repository( object ): None, None ) - return RepositoryKey.RepositoryKey( self.__requester, data, completion = LazyCompletion ) + return RepositoryKey.RepositoryKey( self.__requester, data, completion = NoCompletion ) def get_keys( self ): status, headers, data = self.__requester.request( @@ -697,7 +697,7 @@ class Repository( object ): None, None ) - return Label.Label( self.__requester, data, completion = LazyCompletion ) + return Label.Label( self.__requester, data, completion = NoCompletion ) def get_labels( self ): status, headers, data = self.__requester.request( @@ -729,7 +729,7 @@ class Repository( object ): None, None ) - return Milestone.Milestone( self.__requester, data, completion = LazyCompletion ) + return Milestone.Milestone( self.__requester, data, completion = NoCompletion ) def get_milestones( self, state = DefaultValueForOptionalParameters, sort = DefaultValueForOptionalParameters, direction = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( @@ -766,7 +766,7 @@ class Repository( object ): None, None ) - return PullRequest.PullRequest( self.__requester, data, completion = LazyCompletion ) + return PullRequest.PullRequest( self.__requester, data, completion = NoCompletion ) def get_pulls( self, state = DefaultValueForOptionalParameters ): status, headers, data = self.__requester.request( diff --git a/test/ReplayData/Repository.testAttributes.txt b/test/ReplayData/Repository.testAttributes.txt index bb9f201a..04913441 100644 --- a/test/ReplayData/Repository.testAttributes.txt +++ b/test/ReplayData/Repository.testAttributes.txt @@ -3,8 +3,3 @@ GET /repos/jacquev6/PyGithub {} null [('status', '200 OK'), ('x-ratelimit-remaining', '4995'), ('content-length', '1097'), ('server', 'nginx/1.0.13'), ('connection', 'keep-alive'), ('x-ratelimit-limit', '5000'), ('etag', '"8b91cd1456a5d4ef451946f882d9161e"'), ('date', 'Wed, 09 May 2012 10:26:15 GMT'), ('content-type', 'application/json; charset=utf-8')] {"mirror_url":null,"homepage":"http://vincent-jacques.net/PyGithub","clone_url":"https://github.com/jacquev6/PyGithub.git","html_url":"https://github.com/jacquev6/PyGithub","url":"https://api.github.com/repos/jacquev6/PyGithub","has_downloads":true,"watchers":13,"permissions":{"admin":true,"pull":true,"push":true},"has_wiki":false,"has_issues":true,"fork":false,"forks":2,"language":"Python","size":212,"description":"Python library implementing the full Github API v3","git_url":"git://github.com/jacquev6/PyGithub.git","private":false,"created_at":"2012-02-25T12:53:47Z","open_issues":15,"svn_url":"https://github.com/jacquev6/PyGithub","owner":{"url":"https://api.github.com/users/jacquev6","login":"jacquev6","gravatar_id":"b68de5ae38616c296fa345d2b9df2225","avatar_url":"https://secure.gravatar.com/avatar/b68de5ae38616c296fa345d2b9df2225?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":327146},"name":"PyGithub","pushed_at":"2012-05-08T19:27:43Z","id":3544490,"ssh_url":"git@github.com:jacquev6/PyGithub.git","updated_at":"2012-05-08T19:27:43Z"} -GET /repos/jacquev6/PyGithub {} null -200 -[('status', '200 OK'), ('x-ratelimit-remaining', '4995'), ('content-length', '1097'), ('server', 'nginx/1.0.13'), ('connection', 'keep-alive'), ('x-ratelimit-limit', '5000'), ('etag', '"8b91cd1456a5d4ef451946f882d9161e"'), ('date', 'Wed, 09 May 2012 10:26:15 GMT'), ('content-type', 'application/json; charset=utf-8')] -{"mirror_url":null,"homepage":"http://vincent-jacques.net/PyGithub","clone_url":"https://github.com/jacquev6/PyGithub.git","html_url":"https://github.com/jacquev6/PyGithub","url":"https://api.github.com/repos/jacquev6/PyGithub","has_downloads":true,"watchers":13,"permissions":{"admin":true,"pull":true,"push":true},"has_wiki":false,"has_issues":true,"fork":false,"forks":2,"language":"Python","size":212,"description":"Python library implementing the full Github API v3","git_url":"git://github.com/jacquev6/PyGithub.git","private":false,"created_at":"2012-02-25T12:53:47Z","open_issues":15,"svn_url":"https://github.com/jacquev6/PyGithub","owner":{"url":"https://api.github.com/users/jacquev6","login":"jacquev6","gravatar_id":"b68de5ae38616c296fa345d2b9df2225","avatar_url":"https://secure.gravatar.com/avatar/b68de5ae38616c296fa345d2b9df2225?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":327146},"name":"PyGithub","pushed_at":"2012-05-08T19:27:43Z","id":3544490,"ssh_url":"git@github.com:jacquev6/PyGithub.git","updated_at":"2012-05-08T19:27:43Z"} -