From 5aab6f5dc2693171b54368ca32a9c869fb2be74b Mon Sep 17 00:00:00 2001 From: Steve Kowalik Date: Wed, 24 Mar 2021 14:39:58 +1100 Subject: [PATCH] Tighten asserts for new Permission tests (#1893) The recently merged code checking attributes on Permissions overeagerly used assertEqual for everything, switch to the more appropriate methods. --- tests/Permissions.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/Permissions.py b/tests/Permissions.py index da699f3f..29fa8d94 100644 --- a/tests/Permissions.py +++ b/tests/Permissions.py @@ -29,13 +29,13 @@ class Permissions(Framework.TestCase): self.userRepo = self.g.get_repo("PyGithub/PyGithub") def testUserRepoPermissionAttributes(self): - self.assertEqual(self.userRepo.permissions.admin, False) + self.assertFalse(self.userRepo.permissions.admin) # Attribute is not present for users (only for teams) - self.assertEqual(self.userRepo.permissions.maintain, None) - self.assertEqual(self.userRepo.permissions.pull, True) - self.assertEqual(self.userRepo.permissions.push, False) + self.assertIs(self.userRepo.permissions.maintain, None) + self.assertTrue(self.userRepo.permissions.pull) + self.assertFalse(self.userRepo.permissions.push) # Attribute is not present for users (only for teams) - self.assertEqual(self.userRepo.permissions.triage, None) + self.assertIs(self.userRepo.permissions.triage, None) def testUserRepoPermissionRepresentation(self): self.assertEqual(