From 562908cb1760872816909faba7ae0aefe3f478e6 Mon Sep 17 00:00:00 2001 From: Michell Stuttgart Date: Sun, 7 Oct 2018 23:19:38 -0300 Subject: [PATCH] Improve __repr__ method of Milestone class (#921) This commit add the title of milestone in string representation of Milestone class. This modification improve readbility of milestone instances. Before: ```python >>> repo.get_milestone(number=1) Milestone(number=1) ``` After: ```python >>> repo.get_milestone(number=1) Milestone(title='Milestone Example', number=1) ``` --- github/Milestone.py | 2 +- github/tests/Milestone.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/github/Milestone.py b/github/Milestone.py index 41a41179..18d0e5ea 100644 --- a/github/Milestone.py +++ b/github/Milestone.py @@ -45,7 +45,7 @@ class Milestone(github.GithubObject.CompletableGithubObject): """ def __repr__(self): - return self.get__repr__({"number": self._number.value}) + return self.get__repr__({"number": self._number.value, "title": self._title.value}) @property def closed_issues(self): diff --git a/github/tests/Milestone.py b/github/tests/Milestone.py index a5be659d..4654569f 100644 --- a/github/tests/Milestone.py +++ b/github/tests/Milestone.py @@ -52,7 +52,7 @@ class Milestone(Framework.TestCase): self.assertEqual(self.milestone.creator.login, "jacquev6") # test __repr__() based on this attributes - self.assertEqual(self.milestone.__repr__(), 'Milestone(number=1)') + self.assertEqual(self.milestone.__repr__(), 'Milestone(title="Version 0.4", number=1)') def testEditWithMinimalParameters(self): self.milestone.edit("Title edited by PyGithub")