status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-08-31 19:01:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use right variable in both get_check_runs() (#1889)

Browse Source 
Both CheckSuite and Commit have a get_check_runs() method that allows
filtering by a string -- the original code did not check for it, and
never added it to the query string since it checked the wrong variable.
Check the right variable and re-record the replay data.

Fixes #1843
This commit is contained in:
Steve Kowalik
2021-03-24 10:02:02 +11:00
committed by GitHub
parent 6bae9e5cae
commit 3003e06501
6 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/CheckSuite.py
+1 -1
View File
@@ -193,7 +193,7 @@ class CheckSuite(github.GithubObject.CompletableGithubObject):
url_parameters["check_name"] = check_name
if status is not github.GithubObject.NotSet:
url_parameters["status"] = status
if status is not github.GithubObject.NotSet:
if filter is not github.GithubObject.NotSet:
url_parameters["filter"] = filter
return github.PaginatedList.PaginatedList(
github.CheckRun.CheckRun,
github/Commit.py
+1 -1
View File
@@ -281,7 +281,7 @@ class Commit(github.GithubObject.CompletableGithubObject):
url_parameters["check_name"] = check_name
if status is not github.GithubObject.NotSet:
url_parameters["status"] = status
if status is not github.GithubObject.NotSet:
if filter is not github.GithubObject.NotSet:
url_parameters["filter"] = filter
return github.PaginatedList.PaginatedList(
github.CheckRun.CheckRun,