status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-02 03:41:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added option to create review for Pull request (#662)

Browse Source 
* Added option to create review for Pull request

* Fix tests
This commit is contained in:
Gilad Shefer
2018-03-20 22:28:39 +08:00
committed by Wan Liuyang
parent 3cd176e3c3
commit 162f0397bc
5 changed files with 69 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/tests/PullRequestReview.py
+7
View File
@@ -36,6 +36,12 @@ class PullRequestReview(Framework.TestCase):
self.repo = self.g.get_repo("PyGithub/PyGithub")
self.pull = self.repo.get_pull(538)
# Test ability to create a review
self.created_pullreview = self.pull.create_review(
self.repo.get_commit('2f0e4e55fe87e38d26efc9aa1346f56abfbd6c52'),
'Some review created by PyGithub'
)
# Test ability to get all reviews
self.pullreviews = self.pull.get_reviews()
@@ -51,6 +57,7 @@ class PullRequestReview(Framework.TestCase):
self.assertEqual(self.pullreview.html_url, "https://github.com/PyGithub/PyGithub/pull/538#pullrequestreview-28482091")
self.assertEqual(self.pullreview.pull_request_url, "https://api.github.com/repos/PyGithub/PyGithub/pulls/538")
self.assertEqual(self.pullreview.submitted_at, datetime.datetime(2017, 3, 22, 19, 6, 59))
self.assertIn(self.created_pullreview, self.pullreviews)
# test __repr__() based on this attributes
self.assertEqual(self.pullreview.__repr__(), 'PullRequestReview(user=NamedUser(login="jzelinskie"), id=28482091)')