From 1292bf0e22c796e91cc3d6e24b544aece8c21f2a Mon Sep 17 00:00:00 2001 From: Vincent Jacques Date: Wed, 9 May 2012 18:22:33 +0200 Subject: [PATCH] Remove completion functions from GitAuthor --- github/GithubObjects/GitAuthor.py | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/github/GithubObjects/GitAuthor.py b/github/GithubObjects/GitAuthor.py index e6e12a92..ca6a3c61 100644 --- a/github/GithubObjects/GitAuthor.py +++ b/github/GithubObjects/GitAuthor.py @@ -14,22 +14,17 @@ class GitAuthor( object ): self.__completed = False self.__initAttributes() self.__useAttributes( attributes ) - if not lazy: - self.__complete() @property def date( self ): - self.__completeIfNeeded( self.__date ) return self.__date @property def email( self ): - self.__completeIfNeeded( self.__email ) return self.__email @property def name( self ): - self.__completeIfNeeded( self.__name ) return self.__name def __initAttributes( self ): @@ -37,21 +32,6 @@ class GitAuthor( object ): self.__email = None self.__name = None - def __completeIfNeeded( self, testedAttribute ): - if not self.__completed and testedAttribute is None: - self.__complete() - - # @todo Do not generate __complete if type has no url attribute - def __complete( self ): - status, headers, data = self.__requester.request( - "GET", - self.__url, - None, - None - ) - self.__useAttributes( data ) - self.__completed = True - def __useAttributes( self, attributes ): #@todo No need to check if attribute is in attributes when attribute is mandatory if "date" in attributes and attributes[ "date" ] is not None: