status-im/PyGithub
1
0
Fork 0
mirror of https://github.com/status-im/PyGithub.git synced 2026-09-02 11:51:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add url attribute to PullRequestReview object (#731)

Browse Source 
To compare PullRequestReview objects, they need to have the 'url'
attribute because the CompletableGithubObject expects to be able to
inspect a '_url' attribute on objects when testing for equality.
This commit is contained in:
Darragh Bailey
2018-03-16 22:49:01 +08:00
committed by Wan Liuyang
parent 0f0a7d4e68
commit 0fb176fd71
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/PullRequestReview.py
+11
View File
@@ -79,6 +79,14 @@ class PullRequestReview(github.GithubObject.CompletableGithubObject):
self._completeIfNotSet(self._state)
return self._state.value
@property
def url(self):
"""
:type: string
"""
self._completeIfNotSet(self._url)
return self._url.value
@property
def html_url(self):
"""
@@ -109,6 +117,7 @@ class PullRequestReview(github.GithubObject.CompletableGithubObject):
self._body = github.GithubObject.NotSet
self._commit_id = github.GithubObject.NotSet
self._state = github.GithubObject.NotSet
self._url = github.GithubObject.NotSet
self._html_url = github.GithubObject.NotSet
self._pull_request_url = github.GithubObject.NotSet
self._submitted_at = github.GithubObject.NotSet
@@ -124,6 +133,8 @@ class PullRequestReview(github.GithubObject.CompletableGithubObject):
self._commit_id = self._makeStringAttribute(attributes["commit_id"])
if "state" in attributes: # pragma no branch
self._state = self._makeStringAttribute(attributes["state"])
if "url" in attributes: # pragma no branch
self._url = self._makeStringAttribute(attributes["url"])
if "html_url" in attributes: # pragma no branch
self._html_url = self._makeStringAttribute(attributes["html_url"])
if "pull_request_url" in attributes: # pragma no branch