Review of #189: pep8, copyrights, style, remarks

For remarks, run: git grep "#189"
They are only my first thoughts while reviewing this pull request,
and should be reviewed themselves.
This commit is contained in:
Vincent Jacques
2013-08-22 12:12:38 +02:00
parent 1787765a61
commit 0f74e4389b
6 changed files with 32 additions and 21 deletions
+5 -1
View File
@@ -21,13 +21,17 @@
# #
################################################################################
# #189: Line endings should be linux style
import Framework
import github
class ConditionalRequestUpdate(Framework.TestCase):
def setUp(self):
Framework.TestCase.setUp(self)
self.repo = self.g.get_repo("akfish/PyGithub")
self.repo = self.g.get_repo("akfish/PyGithub")
# #189: Let's separate this assert in its own test method, remove it from setUp.
# Not updated
self.assertFalse(self.repo.update(), msg="The repo is not changes. But update() != False")