mirror of
https://github.com/status-im/PyGithub.git
synced 2026-09-02 03:41:08 +00:00
Review of #189: pep8, copyrights, style, remarks
For remarks, run: git grep "#189" They are only my first thoughts while reviewing this pull request, and should be reviewed themselves.
This commit is contained in:
@@ -290,6 +290,8 @@ class Requester:
|
||||
requestHeaders["Authorization"] = self.__authorizationHeader
|
||||
|
||||
def __conditional(self, requestHeaders, parameters):
|
||||
# #189: Why pass etag and last_modified by param "parameters"?
|
||||
# #189: May be better to add a specific param "headers" to methods requestFoobar?
|
||||
etag = parameters.get(Consts.REQ_IF_NONE_MATCH)
|
||||
last_modified = parameters.get(Consts.REQ_IF_MODIFIED_SINCE)
|
||||
if etag is not None:
|
||||
|
||||
Reference in New Issue
Block a user