Review of #189: pep8, copyrights, style, remarks

For remarks, run: git grep "#189"
They are only my first thoughts while reviewing this pull request,
and should be reviewed themselves.
This commit is contained in:
Vincent Jacques
2013-08-22 12:12:38 +02:00
parent 1787765a61
commit 0f74e4389b
6 changed files with 32 additions and 21 deletions
+2
View File
@@ -290,6 +290,8 @@ class Requester:
requestHeaders["Authorization"] = self.__authorizationHeader
def __conditional(self, requestHeaders, parameters):
# #189: Why pass etag and last_modified by param "parameters"?
# #189: May be better to add a specific param "headers" to methods requestFoobar?
etag = parameters.get(Consts.REQ_IF_NONE_MATCH)
last_modified = parameters.get(Consts.REQ_IF_MODIFIED_SINCE)
if etag is not None: