From 03d7fb012e9d032165c43f93a4c67bc29af9366f Mon Sep 17 00:00:00 2001 From: Vincent Jacques Date: Fri, 23 Aug 2013 11:15:17 +0200 Subject: [PATCH] #193: Add remarks --- github/GithubObject.py | 1 + github/Requester.py | 1 + 2 files changed, 2 insertions(+) diff --git a/github/GithubObject.py b/github/GithubObject.py index 6bc5a7bb..bc32b257 100644 --- a/github/GithubObject.py +++ b/github/GithubObject.py @@ -133,6 +133,7 @@ class GithubObject(object): ''' return self._headers.get(Consts.RES_LAST_MODIFED) + # #193: Should be only in CompletableGithubObject, NonCompletableGithubObjects don't have urls def update(self): ''' Check and update the object with conditional request diff --git a/github/Requester.py b/github/Requester.py index 792861d9..feed86b2 100644 --- a/github/Requester.py +++ b/github/Requester.py @@ -176,6 +176,7 @@ class Requester: def __check(self, status, responseHeaders, output): output = self.__structuredFromJson(output) + # #193: Shouldn't next line be in __requestEncode? (__check is not called on all requests) # Log frame self.DEBUG_ON_RESPONSE(status, responseHeaders, output)