Connor Bryan e761b9d1fb Refactor redux pattern from top-level to ducks (#1936)
* Add a new route for AddressBook

* Further templating of the AddressBook view

* Add initial functionality to handle a table of existing address labels

* Make the linter happy

* Adjust paths

* Factor out TableRow and add common functionality

* Add initial Redux boilerplate for addressBook | fix minor linting issues

* Swap out terminology and types

* Connect up to Redux

* Connect data for AddressBookTable to Redux

* Use temporary fields for addition

* Remove alignment and index column

* Stopping point

* Adjust the sizing of rows to be consistent

* Initial implementation of a dropdown for the address field

* Minor styling to dropdown

* Stopping point

* Apply a focus concept onto the factory

* Add keyboard controls for the address field dropdown

* Adjust label of address field when it matches an addressBook entry

* Properly handle attempting to blur a non-existent component

* Minor styling changes on dropdown box

* Standardize address casing, add accessibility to dropdown

* Create an addressLabel component

* Pass refs correctly and fix some typings

* Exact version

* Add module name mapping for shared/keycodes

* addressBook reducer tests

* Add functionality to DeterministicModal

* Minor changes / Add test for addressBook selectors

* Move out AddressBookTable to a component

* Typing, translation and restructuring

* More typing and translation fixes

* More linting fixes

* More type changes

* Variable name for dropdown background

* Fix TS type errors, lint errors, remove unused props

* Used a different selector and removed method: AddressBookTable

* Linter was mad

* Linter mad again :(

* Add a translation and adjust styling of AddressBookTable

* Move the onBlur to a class method

* Prevent the default behavior of up/down/enter for dropdown

* Let's do it this way instead

* Adjust the styling on DeterministicWalletModal labels

* Change `AddressBookTable` into a pseudo-table using section and div

* Use readable keys vs. keycodes

* Put the dropdown in InputFactory and position it correctly

* Sanitation of label adding and changing

* Prevent duplicate labels in AddressBook and Row

* Add a box shadow and use `invalid` class insted of custom

* Use emphasis vs strong for address in dropdown

* Display the label undernearth the input vs. changing it

* Isolate AccountAddress into its own component

* Introduce interactivity to AccountAddress

* Fully incorporate with Redux

* Validation for AccountAddress

* Add validation notifications for address field on AddressBookTable

* Minor formatting

* Adjust wrappage for optimal flexboxxing

* Make AddressBookTable responsive

* Show an invalid input in "real time" instead of only on submit

* Real time input validation for AddressBookTableRow

* Responsive-ize the To address dropdown

* Hide identicons instead at small enough screen sizes

* Fix repsonsiveness of dropdown further

* Fix responsiveness of table rows and inputs

* Truncate account info and switch identicons to the right for consistency

* Use classnames instead of targetting element directly for DWM

* Display a notice if the entered query doesnt match a label and isnt an addr

* Don't show an error on the To address if its a label entry

* Display an error under AddressBookTableRow in real time

* Display errors in real time for AddressBookTable temp inputs

* Add realtime validation to AccountAddress

* Ensure toChecksumAddress is used when entering labels to address manager

* Show errors even after blurring.

* Create a ducks/ implementation for addressBook

* Duck-ize notifications

* Duck-ize customTokens

* Duck-ize deterministicWallets

* Only show errors on address/label entry if they have been blurred

* On certain inputs, show an invalid input immediately

* spec files in same directory

* Rename top-level redux directory

* Duck-ize gas

* Add displayed errors for labels with 0x and labels containing ens

* Move ENS checking validation out

* Add a saga for addLabelForAddress

* Completely revamp the redux side of Address Manager and test it all

* Adjust components to use new redux addressBook

* Incorporate new redux into AddressBookTableRow and clean up for linter

* Make linter and tests happy

* Another reduxy overhaul

* Still fixing it

* More redux updates

* Finalize redux stuff.

* Incorporate new reduxy way into AddressBookTable & Row

* Incorporate redux changes into Account Address

* Small tests fix

* Add and fix some selector tests

* Addressing Will's comments

* Shortened visibility class for line length reasons.

* Incorporate ducks pattern on updates addressBook

* Fix typeerror

* Migrate messages to ducks

* For Henry

* Duckify onboardStatus

* Duckify paritySigner

* Duckify rates

* Duckify transactions

* Duckerize wallet

* Reduckerate config

* Adjust exports and tests of every duck so far

* Duckify ENS

* Duckerificate schedule

* Duckificate swap

* Actually use the new sagas;  fix a circular dependency problem.

* Duckify transaction (phew)

* Add basics to redux/ directory

* Remove non-ducked redux stuff

* First sweep of redux/ directory

* Combine redundant imports

* Fix more linting stuff.

* A few more type fixes

* Welp... now I know not to use index.

* Sweep components/

* Sweep through containers/

* Im really starting to get frustrated

* The dawn of a new age.

* Linter fixes.

* De-flatten config/ reducers

* Do my thang on config selectors

* Adjust all references to config

* Split up ens reducers

* Wrap up de-nesting ENS

* Big boy refactor

* Split transaction into its reducers

* Fix reducers in transaction/

* Stopping point

* Adjust references to transaction from components

* Fix references to selectors

* Nest broadcast actions

* Nest field actions

* Nest meta actions

* Nest network actions

* Nest sign actions

* Nest broadcast types

* Nested fields types

* Nest meta types

* Nested network types

* Nested sign types

* Implement transaction saga changes

* Huh? No prepush problems?

* Update snappshot

* Reintroduce deleted tests

* A few missing tests found

* Found three missing transaction tests

* Found more tests

* Found the rest of the tests, woohoo.

* Renamed TypeKeys in TRANSACTION

* Specify TRANSACTION_BROADCAST

* Pretty up these imports

* Specify TRANSACTION_FIELDS

* Specify TRANSACTION_META

* Specify TRANSACTION_NETWORK

* Specify TRANSACTION_SIGN

* Adjust imports and add translations

* Update config snapshot

* Post-merge

* Temporary fix for DW/Config sagas so Daniel can continue smoke testing

* Remove first circulat dependency

* Fix more circular dependencies

* Properly structure config indices

* Further restructure config

* Prepare for idea

* Target directly from within features/

* Remove that circular dependency -- woohoo

* Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance

* Un-comment the component-in-redux phenomenon

* Move onLoad to the store file

* Adjust addressBook imports/exports

* Adjusted imports/exports for customTokens

* Adjust imports/exports of deterministicWallets

* Adjust imports/exports of ens

* Restructure imports/exports of gas

* Restructure imports/exports for message

* Adjust imports/exports of notifications

* Restructure onboardStatus imports/exports

* Restructure paritySigner imports/exports

* Restructure rates imports/exports

* Restructure schedule imports/exports

* Fix broadcastweb3handler test

* Restructure swap imports/exports/

* Restructure transactionS imports/exports

* Restructured wallet imports and exports

* Hoist all necessary selectors aside from config/**/* and transaction/**/*

* Hoist all top-level selectors from transaction

* [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj

* Implement right-click context menu (#1780) @ bryanwb

* No Private Keys Online (#1466) @ wbobeirne

* Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne

* [Fix] Make ENS Value Consistent (#1956) @ skubakdj

* Auto token add (#1808) @ HenryNguyen5

* Electron Ledger + Trezor Support (#1836) @ wbobeirne

* Fix Context Menu Popup Parameters (#1957)

* Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne

* Change displayed notification back in helpers.tsx

* Remove newline on shell files

* Re-add newlines

* Remove newling on .travis.yml

* Prettier two files

* Re-add index.scss import in OnboardModal

* Restructure transaction subdirectories

* Everything in transaction/ except for sagas

* Restructure transaction imports/exports

* Nest broadcast sagas

* Nest fields

* Nest meta

* Nest network

* Nest sign

* Use generic names for reduxy stuff in the same directory to save space

* Do everything every in the whole wide world
2018-06-17 20:53:00 -05:00

308 lines
11 KiB
TypeScript

import BN from 'bn.js';
import { SagaIterator } from 'redux-saga';
import {
apply,
put,
select,
take,
call,
fork,
race,
takeEvery,
takeLatest,
all
} from 'redux-saga/effects';
import { Address, toTokenBase, Wei, fromTokenBase, fromWei, TokenValue } from 'libs/units';
import { isValidENSAddress, validNumber, validPositiveNumber, validDecimal } from 'libs/validators';
import { IGetTransaction, ICurrentValue } from 'features/types';
import { AppState } from 'features/reducers';
import * as derivedSelectors from 'features/selectors';
import * as configSelectors from 'features/config/selectors';
import { ensTypes, ensActions, ensSelectors } from 'features/ens';
import { walletTypes, walletSelectors } from 'features/wallet';
import { notificationsActions } from 'features/notifications';
import { transactionBroadcastSagas } from './broadcast';
import { transactionFieldsTypes, transactionFieldsActions, transactionFieldsSagas } from './fields';
import {
transactionMetaTypes,
transactionMetaActions,
transactionMetaSelectors,
transactionMetaSagas
} from './meta';
import { transactionNetworkSagas } from './network';
import { transactionSignTypes, transactionSignSagas } from './sign';
import * as types from './types';
import * as actions from './actions';
import * as helpers from './helpers';
//#region Current
//#region Current To
export function* setCurrentToSaga({ payload: raw }: types.SetCurrentToAction): SagaIterator {
const isValidAddress: ReturnType<typeof configSelectors.getIsValidAddressFn> = yield select(
configSelectors.getIsValidAddressFn
);
const validAddress: boolean = yield call(isValidAddress, raw);
const validEns: boolean = yield call(isValidENSAddress, raw);
let value: Buffer | null = null;
if (validAddress) {
value = Address(raw);
} else if (validEns) {
yield call(setField, { value, raw });
const [domain] = raw.split('.');
yield put(ensActions.resolveDomainRequested(domain));
yield take([
ensTypes.ENSActions.RESOLVE_DOMAIN_FAILED,
ensTypes.ENSActions.RESOLVE_DOMAIN_SUCCEEDED,
ensTypes.ENSActions.RESOLVE_DOMAIN_CACHED
]);
const resolvedAddress: string | null = yield select(ensSelectors.getResolvedAddress, true);
if (resolvedAddress) {
value = Address(resolvedAddress);
}
}
yield call(setField, { value, raw });
}
export function* setField(
payload:
| transactionFieldsTypes.SetToFieldAction['payload']
| transactionMetaTypes.SetTokenToMetaAction['payload']
) {
const etherTransaction: boolean = yield select(derivedSelectors.isEtherTransaction);
if (etherTransaction) {
yield put(transactionFieldsActions.setToField(payload));
} else {
yield put(transactionMetaActions.setTokenTo(payload));
}
}
export const currentTo = takeLatest([types.TransactionActions.CURRENT_TO_SET], setCurrentToSaga);
//#endregion Current To
//#region Current Value
export function* setCurrentValueSaga(action: types.SetCurrentValueAction): SagaIterator {
const etherTransaction = yield select(derivedSelectors.isEtherTransaction);
const setter = etherTransaction
? transactionFieldsActions.setValueField
: transactionMetaActions.setTokenValue;
return yield call(valueHandler, action, setter);
}
export function* valueHandler(
{ payload }: types.SetCurrentValueAction,
setter: transactionFieldsActions.TSetValueField | transactionMetaActions.TSetTokenValue
) {
const decimal: number = yield select(transactionMetaSelectors.getDecimal);
const unit: string = yield select(derivedSelectors.getUnit);
const isEth = yield select(derivedSelectors.isEtherTransaction);
const validNum = isEth ? validNumber : validPositiveNumber;
if (!validNum(Number(payload)) || !validDecimal(payload, decimal)) {
return yield put(setter({ raw: payload, value: null }));
}
const value = toTokenBase(payload, decimal);
const isValid: boolean = yield call(helpers.validateInput, value, unit);
yield put(setter({ raw: payload, value: isValid ? value : null }));
}
export function* revalidateCurrentValue(): SagaIterator {
const etherTransaction = yield select(derivedSelectors.isEtherTransaction);
const currVal: ICurrentValue = yield select(derivedSelectors.getCurrentValue);
const reparsedValue: null | ICurrentValue = yield call(reparseCurrentValue, currVal);
const unit: string = yield select(derivedSelectors.getUnit);
const setter = etherTransaction
? transactionFieldsActions.setValueField
: transactionMetaActions.setTokenValue;
if (!reparsedValue || !reparsedValue.value) {
return yield put(setter({ raw: currVal.raw, value: null }));
}
const isValid: boolean = yield call(helpers.validateInput, reparsedValue.value, unit);
const newVal = { raw: reparsedValue.raw, value: isValid ? reparsedValue.value : null };
if (isValueDifferent(currVal, newVal)) {
yield put(setter(newVal));
}
}
export function isValueDifferent(curVal: ICurrentValue, newVal: ICurrentValue) {
const val1 = curVal.value as BN;
const val2 = newVal.value as BN;
if (curVal.raw !== newVal.raw) {
return true;
}
if (BN.isBN(val1) && BN.isBN(val2)) {
return !val1.eq(val2);
}
if (curVal.value !== newVal.value) {
return true;
}
}
export function* reparseCurrentValue(value: helpers.IInput): SagaIterator {
const isEth = yield select(derivedSelectors.isEtherTransaction);
const decimal = yield select(transactionMetaSelectors.getDecimal);
const validNum = isEth ? validNumber : validPositiveNumber;
if (validNum(Number(value.raw)) && validDecimal(value.raw, decimal)) {
return {
raw: value.raw,
value: toTokenBase(value.raw, decimal)
};
} else {
return null;
}
}
export const currentValue = [
takeEvery([types.TransactionActions.CURRENT_VALUE_SET], setCurrentValueSaga),
takeEvery(
[
transactionFieldsTypes.TransactionFieldsActions.GAS_LIMIT_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.GAS_PRICE_FIELD_SET
],
revalidateCurrentValue
)
];
//#endregion Current Value
export const current = [currentTo, ...currentValue];
//#endregion Current
//#region Send Everything
export function* handleSendEverything(): SagaIterator {
const { transaction }: IGetTransaction = yield select(derivedSelectors.getTransaction);
const currentBalance: Wei | TokenValue | null = yield select(derivedSelectors.getCurrentBalance);
const etherBalance: AppState['wallet']['balance']['wei'] = yield select(
walletSelectors.getEtherBalance
);
if (!etherBalance || !currentBalance) {
return yield put(actions.sendEverythingFailed());
}
transaction.value = Buffer.from([]);
const etherTransaction: boolean = yield select(derivedSelectors.isEtherTransaction);
const setter = etherTransaction
? transactionFieldsActions.setValueField
: transactionMetaActions.setTokenValue;
// set transaction value to 0 so it's not calculated in the upfrontcost
const totalCost: Wei = yield apply(transaction, transaction.getUpfrontCost);
if (totalCost.gt(etherBalance)) {
// Dust amount is too small
yield put(
notificationsActions.showNotification(
'warning',
`The cost of gas is higher than your balance. Total cost: ${totalCost} > Your Ether balance: ${etherBalance}`
)
);
yield put(actions.sendEverythingFailed());
return yield put(setter({ raw: '0', value: null }));
}
if (etherTransaction) {
const remainder = currentBalance.sub(totalCost);
const rawVersion = fromWei(remainder, 'ether');
yield put(setter({ raw: rawVersion, value: remainder }));
yield put(actions.sendEverythingSucceeded());
} else {
// else we just max out the token value
const decimal: number = yield select(transactionMetaSelectors.getDecimal);
const rawVersion = fromTokenBase(currentBalance, decimal);
yield put(setter({ raw: rawVersion, value: currentBalance }));
yield put(actions.sendEverythingSucceeded());
}
}
export const sendEverything = [
takeEvery(types.TransactionActions.SEND_EVERYTHING_REQUESTED, handleSendEverything)
];
//#endregion Send Everything
//#region Reset
export function* resetTransactionState(): SagaIterator {
const contractInteraction: ReturnType<
typeof transactionMetaSelectors.isContractInteraction
> = yield select(transactionMetaSelectors.isContractInteraction);
yield put(
transactionFieldsActions.resetTransactionSuccessful({
isContractInteraction: contractInteraction
})
);
}
/**
* After a transaction is signed, wait for any action that would result in the transaction state changing then fire off
* a handler that will remove the current serialized transaction so the user does not send a stale transaction
*/
export function* watchTransactionState(): SagaIterator {
while (true) {
// wait for transaction to be signed
yield take([
transactionSignTypes.TransactionSignActions.SIGN_LOCAL_TRANSACTION_SUCCEEDED,
transactionSignTypes.TransactionSignActions.SIGN_WEB3_TRANSACTION_SUCCEEDED
]);
const { bail } = yield race({
bail: take([types.TransactionActions.RESET_REQUESTED, walletTypes.WalletActions.RESET]), // bail on actions that would wipe state
wipeState: take([
types.TransactionActions.CURRENT_TO_SET,
types.TransactionActions.CURRENT_VALUE_SET,
transactionFieldsTypes.TransactionFieldsActions.GAS_LIMIT_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.GAS_PRICE_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.VALUE_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.DATA_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.NONCE_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.TO_FIELD_SET,
transactionMetaTypes.TransactionMetaActions.TOKEN_TO_META_SET,
transactionMetaTypes.TransactionMetaActions.TOKEN_VALUE_META_SET,
transactionMetaTypes.TransactionMetaActions.UNIT_META_SET
]) // watch for any actions that would change transaction state
});
if (bail) {
continue;
}
yield put(transactionFieldsActions.resetTransactionRequested());
}
}
export function* setNetworkUnit(): SagaIterator {
const networkUnit = yield select(configSelectors.getNetworkUnit);
yield put(transactionMetaActions.setUnitMeta(networkUnit));
}
export const reset = [
takeEvery([walletTypes.WalletActions.RESET], resetTransactionState),
takeEvery(types.TransactionActions.RESET_REQUESTED, resetTransactionState),
fork(watchTransactionState),
takeEvery(types.TransactionActions.RESET_SUCCESSFUL, setNetworkUnit)
];
//#endregion Reset
export function* transactionSaga(): SagaIterator {
yield all([
...transactionBroadcastSagas.broadcastSaga,
...transactionFieldsSagas.fieldsSaga,
...transactionMetaSagas.metaSaga,
...transactionNetworkSagas.networkSaga,
...transactionSignSagas.signing,
...current,
...sendEverything,
...reset
]);
}