MyCrypto/common/features/config/sagas.spec.ts
Connor Bryan e761b9d1fb Refactor redux pattern from top-level to ducks (#1936)
* Add a new route for AddressBook

* Further templating of the AddressBook view

* Add initial functionality to handle a table of existing address labels

* Make the linter happy

* Adjust paths

* Factor out TableRow and add common functionality

* Add initial Redux boilerplate for addressBook | fix minor linting issues

* Swap out terminology and types

* Connect up to Redux

* Connect data for AddressBookTable to Redux

* Use temporary fields for addition

* Remove alignment and index column

* Stopping point

* Adjust the sizing of rows to be consistent

* Initial implementation of a dropdown for the address field

* Minor styling to dropdown

* Stopping point

* Apply a focus concept onto the factory

* Add keyboard controls for the address field dropdown

* Adjust label of address field when it matches an addressBook entry

* Properly handle attempting to blur a non-existent component

* Minor styling changes on dropdown box

* Standardize address casing, add accessibility to dropdown

* Create an addressLabel component

* Pass refs correctly and fix some typings

* Exact version

* Add module name mapping for shared/keycodes

* addressBook reducer tests

* Add functionality to DeterministicModal

* Minor changes / Add test for addressBook selectors

* Move out AddressBookTable to a component

* Typing, translation and restructuring

* More typing and translation fixes

* More linting fixes

* More type changes

* Variable name for dropdown background

* Fix TS type errors, lint errors, remove unused props

* Used a different selector and removed method: AddressBookTable

* Linter was mad

* Linter mad again :(

* Add a translation and adjust styling of AddressBookTable

* Move the onBlur to a class method

* Prevent the default behavior of up/down/enter for dropdown

* Let's do it this way instead

* Adjust the styling on DeterministicWalletModal labels

* Change `AddressBookTable` into a pseudo-table using section and div

* Use readable keys vs. keycodes

* Put the dropdown in InputFactory and position it correctly

* Sanitation of label adding and changing

* Prevent duplicate labels in AddressBook and Row

* Add a box shadow and use `invalid` class insted of custom

* Use emphasis vs strong for address in dropdown

* Display the label undernearth the input vs. changing it

* Isolate AccountAddress into its own component

* Introduce interactivity to AccountAddress

* Fully incorporate with Redux

* Validation for AccountAddress

* Add validation notifications for address field on AddressBookTable

* Minor formatting

* Adjust wrappage for optimal flexboxxing

* Make AddressBookTable responsive

* Show an invalid input in "real time" instead of only on submit

* Real time input validation for AddressBookTableRow

* Responsive-ize the To address dropdown

* Hide identicons instead at small enough screen sizes

* Fix repsonsiveness of dropdown further

* Fix responsiveness of table rows and inputs

* Truncate account info and switch identicons to the right for consistency

* Use classnames instead of targetting element directly for DWM

* Display a notice if the entered query doesnt match a label and isnt an addr

* Don't show an error on the To address if its a label entry

* Display an error under AddressBookTableRow in real time

* Display errors in real time for AddressBookTable temp inputs

* Add realtime validation to AccountAddress

* Ensure toChecksumAddress is used when entering labels to address manager

* Show errors even after blurring.

* Create a ducks/ implementation for addressBook

* Duck-ize notifications

* Duck-ize customTokens

* Duck-ize deterministicWallets

* Only show errors on address/label entry if they have been blurred

* On certain inputs, show an invalid input immediately

* spec files in same directory

* Rename top-level redux directory

* Duck-ize gas

* Add displayed errors for labels with 0x and labels containing ens

* Move ENS checking validation out

* Add a saga for addLabelForAddress

* Completely revamp the redux side of Address Manager and test it all

* Adjust components to use new redux addressBook

* Incorporate new redux into AddressBookTableRow and clean up for linter

* Make linter and tests happy

* Another reduxy overhaul

* Still fixing it

* More redux updates

* Finalize redux stuff.

* Incorporate new reduxy way into AddressBookTable & Row

* Incorporate redux changes into Account Address

* Small tests fix

* Add and fix some selector tests

* Addressing Will's comments

* Shortened visibility class for line length reasons.

* Incorporate ducks pattern on updates addressBook

* Fix typeerror

* Migrate messages to ducks

* For Henry

* Duckify onboardStatus

* Duckify paritySigner

* Duckify rates

* Duckify transactions

* Duckerize wallet

* Reduckerate config

* Adjust exports and tests of every duck so far

* Duckify ENS

* Duckerificate schedule

* Duckificate swap

* Actually use the new sagas;  fix a circular dependency problem.

* Duckify transaction (phew)

* Add basics to redux/ directory

* Remove non-ducked redux stuff

* First sweep of redux/ directory

* Combine redundant imports

* Fix more linting stuff.

* A few more type fixes

* Welp... now I know not to use index.

* Sweep components/

* Sweep through containers/

* Im really starting to get frustrated

* The dawn of a new age.

* Linter fixes.

* De-flatten config/ reducers

* Do my thang on config selectors

* Adjust all references to config

* Split up ens reducers

* Wrap up de-nesting ENS

* Big boy refactor

* Split transaction into its reducers

* Fix reducers in transaction/

* Stopping point

* Adjust references to transaction from components

* Fix references to selectors

* Nest broadcast actions

* Nest field actions

* Nest meta actions

* Nest network actions

* Nest sign actions

* Nest broadcast types

* Nested fields types

* Nest meta types

* Nested network types

* Nested sign types

* Implement transaction saga changes

* Huh? No prepush problems?

* Update snappshot

* Reintroduce deleted tests

* A few missing tests found

* Found three missing transaction tests

* Found more tests

* Found the rest of the tests, woohoo.

* Renamed TypeKeys in TRANSACTION

* Specify TRANSACTION_BROADCAST

* Pretty up these imports

* Specify TRANSACTION_FIELDS

* Specify TRANSACTION_META

* Specify TRANSACTION_NETWORK

* Specify TRANSACTION_SIGN

* Adjust imports and add translations

* Update config snapshot

* Post-merge

* Temporary fix for DW/Config sagas so Daniel can continue smoke testing

* Remove first circulat dependency

* Fix more circular dependencies

* Properly structure config indices

* Further restructure config

* Prepare for idea

* Target directly from within features/

* Remove that circular dependency -- woohoo

* Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance

* Un-comment the component-in-redux phenomenon

* Move onLoad to the store file

* Adjust addressBook imports/exports

* Adjusted imports/exports for customTokens

* Adjust imports/exports of deterministicWallets

* Adjust imports/exports of ens

* Restructure imports/exports of gas

* Restructure imports/exports for message

* Adjust imports/exports of notifications

* Restructure onboardStatus imports/exports

* Restructure paritySigner imports/exports

* Restructure rates imports/exports

* Restructure schedule imports/exports

* Fix broadcastweb3handler test

* Restructure swap imports/exports/

* Restructure transactionS imports/exports

* Restructured wallet imports and exports

* Hoist all necessary selectors aside from config/**/* and transaction/**/*

* Hoist all top-level selectors from transaction

* [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj

* Implement right-click context menu (#1780) @ bryanwb

* No Private Keys Online (#1466) @ wbobeirne

* Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne

* [Fix] Make ENS Value Consistent (#1956) @ skubakdj

* Auto token add (#1808) @ HenryNguyen5

* Electron Ledger + Trezor Support (#1836) @ wbobeirne

* Fix Context Menu Popup Parameters (#1957)

* Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne

* Change displayed notification back in helpers.tsx

* Remove newline on shell files

* Re-add newlines

* Remove newling on .travis.yml

* Prettier two files

* Re-add index.scss import in OnboardModal

* Restructure transaction subdirectories

* Everything in transaction/ except for sagas

* Restructure transaction imports/exports

* Nest broadcast sagas

* Nest fields

* Nest meta

* Nest network

* Nest sign

* Use generic names for reduxy stuff in the same directory to save space

* Do everything every in the whole wide world
2018-06-17 20:53:00 -05:00

376 lines
13 KiB
TypeScript

import { delay, SagaIterator } from 'redux-saga';
import { call, fork, put, take, select, apply } from 'redux-saga/effects';
import { cloneableGenerator, SagaIteratorClone } from 'redux-saga/utils';
import { shepherd } from 'mycrypto-shepherd';
import { translateRaw } from 'translations';
import { makeAutoNodeName } from 'libs/nodes';
import { Web3Wallet } from 'libs/wallet';
import { StaticNodeConfig, CustomNodeConfig } from 'types/node';
import configuredStore from 'features/store';
import * as notificationsActions from 'features/notifications/actions';
import { selectedNodeExpectedState } from './nodes/selected/reducer.spec';
import { staticNodesExpectedState } from './nodes/static/reducer.spec';
import { customNodesExpectedState, firstCustomNode } from './nodes/custom/reducer.spec';
import { setLatestBlock } from './meta/actions';
import { getOffline } from './meta/selectors';
import { CONFIG_NETWORKS, ChangeNetworkRequestedAction } from './networks/types';
import { getNodeConfig } from './nodes/selectors';
import { CONFIG_NODES_CUSTOM, RemoveCustomNodeAction } from './nodes/custom/types';
import { getCustomNodeFromId } from './nodes/custom/selectors';
import { CONFIG_NODES_SELECTED, ChangeNodeRequestedOneTimeAction } from './nodes/selected/types';
import {
changeNodeRequested,
changeNodeSucceeded,
changeNodeFailed,
changeNodeForce,
changeNodeRequestedOneTime
} from './nodes/selected/actions';
import { SELECTED_NODE_INITIAL_STATE } from './nodes/selected/reducer';
import { getNodeId, getPreviouslySelectedNode } from './nodes/selected/selectors';
import { isStaticNodeId } from './nodes/static/selectors';
import { getAllNodes, getStaticNodeFromId } from './selectors';
import {
unsetWeb3Node,
unsetWeb3NodeOnWalletEvent,
handleNewNetwork,
handleChangeNodeRequested,
handleChangeNodeRequestedOneTime,
handleNodeChangeForce,
handleChangeNetworkRequested,
handleRemoveCustomNode
} from './sagas';
// init module
configuredStore.getState();
describe('handleChangeNodeRequested*', () => {
let originalRandom: any;
// normal operation variables
const defaultNodeId: any = selectedNodeExpectedState.initialState.nodeId;
const defaultNodeConfig: any = (staticNodesExpectedState as any).initialState[defaultNodeId];
const newNodeId = Object.keys(staticNodesExpectedState.initialState).reduce(
(acc, cur) =>
(staticNodesExpectedState as any).initialState[cur].network !== defaultNodeConfig.network
? cur
: acc
);
const newNodeConfig: StaticNodeConfig = (staticNodesExpectedState as any).initialState[newNodeId];
const isOffline = false;
const changeNodeRequestedAction = changeNodeRequested(newNodeId);
const latestBlock = '0xa';
const data = {} as any;
data.gen = cloneableGenerator(handleChangeNodeRequested)(changeNodeRequestedAction);
function shouldBailOut(gen: SagaIterator, nextVal: any, errMsg: string) {
expect(gen.next(nextVal).value).toEqual(
put(notificationsActions.showNotification('danger', errMsg, 5000))
);
expect(gen.next().value).toEqual(put(changeNodeFailed()));
expect(gen.next().done).toEqual(true);
}
beforeAll(() => {
originalRandom = Math.random;
Math.random = () => 0.001;
});
afterAll(() => {
Math.random = originalRandom;
});
it('should select is static node', () => {
expect(data.gen.next().value).toEqual(select(isStaticNodeId, newNodeId));
});
it('should select nodeConfig', () => {
expect(data.gen.next(defaultNodeId).value).toEqual(select(getNodeConfig));
});
it('should select getStaticNodeFromId', () => {
expect(data.gen.next(defaultNodeConfig).value).toEqual(select(getStaticNodeFromId, newNodeId));
});
it('should get the next network', () => {
expect(data.gen.next(newNodeConfig).value).toMatchSnapshot();
});
it('should select isOffline', () => {
expect(data.gen.next(true).value).toEqual(select(getOffline));
});
it('should show error if check times out', () => {
data.clone1 = data.gen.clone();
data.clone1.next(true);
expect(data.clone1.throw('err').value).toEqual(
put(notificationsActions.showNotification('danger', translateRaw('ERROR_32'), 5000))
);
expect(data.clone1.next().value).toEqual(put(changeNodeFailed()));
expect(data.clone1.next().done).toEqual(true);
});
it('should sucessfully switch to the manual node', () => {
expect(data.gen.next(isOffline).value).toEqual(
apply(shepherd, shepherd.manual, [newNodeId, false])
);
});
it('should get the current block', () => {
data.gen.next();
});
it('should put setLatestBlock', () => {
expect(data.gen.next(latestBlock).value).toEqual(put(setLatestBlock(latestBlock)));
});
it('should put changeNode', () => {
expect(data.gen.next().value).toEqual(
put(changeNodeSucceeded({ networkId: newNodeConfig.network, nodeId: newNodeId }))
);
});
it('should fork handleNewNetwork', () => {
expect(data.gen.next().value).toEqual(fork(handleNewNetwork));
});
it('should be done', () => {
expect(data.gen.next().done).toEqual(true);
});
// custom node variables
const customNodeConfigs = customNodesExpectedState.addFirstCustomNode;
const customNodeAction = changeNodeRequested(firstCustomNode.id);
data.customNode = handleChangeNodeRequested(customNodeAction);
// test custom node
it('should select getCustomNodeConfig and match race snapshot', () => {
data.customNode.next();
data.customNode.next(false);
expect(data.customNode.next(defaultNodeConfig).value).toEqual(
select(getCustomNodeFromId, firstCustomNode.id)
);
expect(data.customNode.next(customNodeConfigs.customNode1).value).toMatchSnapshot();
});
const customNodeIdNotFound = firstCustomNode.id + 'notFound';
const customNodeNotFoundAction = changeNodeRequested(customNodeIdNotFound);
data.customNodeNotFound = handleChangeNodeRequested(customNodeNotFoundAction);
// test custom node not found
it('should handle unknown / missing custom node', () => {
data.customNodeNotFound.next();
data.customNodeNotFound.next(false);
});
it('should select getCustomNodeFromId', () => {
expect(data.customNodeNotFound.next(defaultNodeConfig).value).toEqual(
select(getCustomNodeFromId, customNodeIdNotFound)
);
});
it('should show an error if was an unknown custom node', () => {
shouldBailOut(
data.customNodeNotFound,
null,
`Attempted to switch to unknown node '${customNodeNotFoundAction.payload}'`
);
});
});
describe('handleChangeNodeRequestedOneTime', () => {
const saga = handleChangeNodeRequestedOneTime();
const action: ChangeNodeRequestedOneTimeAction = changeNodeRequestedOneTime('eth_auto');
it('should take a one time action based on the url containing a valid network to switch to', () => {
expect(saga.next().value).toEqual(take(CONFIG_NODES_SELECTED.CHANGE_REQUESTED_ONETIME));
});
it(`should delay for 10 ms to allow shepherdProvider async init to complete`, () => {
expect(saga.next(action).value).toEqual(call(delay, 100));
});
it('should dispatch the change node intent', () => {
expect(saga.next().value).toEqual(put(changeNodeRequested(action.payload)));
});
it('should be done', () => {
expect(saga.next().done).toEqual(true);
});
});
describe('unsetWeb3Node*', () => {
const previousNodeId = 'eth_mycrypto';
const mockNodeId = 'web3';
const gen = unsetWeb3Node();
it('should select getNode', () => {
expect(gen.next().value).toEqual(select(getNodeId));
});
it('should select an alternative node to web3', () => {
// get a 'no visual difference' error here
expect(gen.next(mockNodeId).value).toEqual(select(getPreviouslySelectedNode));
});
it('should put changeNodeForce', () => {
expect(gen.next(previousNodeId).value).toEqual(put(changeNodeForce(previousNodeId)));
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
it('should return early if node type is not web3', () => {
const gen1 = unsetWeb3Node();
gen1.next();
gen1.next('notWeb3');
expect(gen1.next().done).toEqual(true);
});
});
describe('unsetWeb3NodeOnWalletEvent*', () => {
const fakeAction: any = {};
const mockNodeId = 'web3';
const previousNodeId = 'eth_mycrypto';
const gen = unsetWeb3NodeOnWalletEvent(fakeAction);
it('should select getNode', () => {
expect(gen.next().value).toEqual(select(getNodeId));
});
it('should select an alternative node to web3', () => {
expect(gen.next(mockNodeId).value).toEqual(select(getPreviouslySelectedNode));
});
it('should put changeNodeForce', () => {
expect(gen.next(previousNodeId).value).toEqual(put(changeNodeForce(previousNodeId)));
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
it('should return early if node type is not web3', () => {
const gen1 = unsetWeb3NodeOnWalletEvent({ payload: false } as any);
gen1.next(); //getNode
gen1.next('notWeb3'); //getNodeConfig
expect(gen1.next().done).toEqual(true);
});
it('should return early if wallet type is web3', () => {
const mockAddress = '0x0';
const mockNetwork = 'ETH';
const mockWeb3Wallet = new Web3Wallet(mockAddress, mockNetwork);
const gen2 = unsetWeb3NodeOnWalletEvent({ payload: mockWeb3Wallet } as any);
gen2.next(); //getNode
gen2.next('web3'); //getNodeConfig
expect(gen2.next().done).toEqual(true);
});
});
describe('handleNodeChangeForce*', () => {
const payload: any = 'nodeId';
const action: any = { payload };
const gen = cloneableGenerator(handleNodeChangeForce)(action);
const nodeConfig: any = { network: 'network' };
it('should select isStaticNodeId', () => {
expect(gen.next().value).toEqual(select(isStaticNodeId, payload));
});
it('should return if not static node', () => {
const clone = gen.clone();
expect(clone.next(false).done).toEqual(true);
});
it('should select getStaticNodeFromId', () => {
expect(gen.next(true).value).toEqual(select(getStaticNodeFromId, payload));
});
it('should force the node change', () => {
expect(gen.next(nodeConfig).value).toEqual(
put(
changeNodeSucceeded({
networkId: nodeConfig.network,
nodeId: payload
})
)
);
});
it('should put a change node intent', () => {
expect(gen.next().value).toEqual(put(changeNodeRequested(payload)));
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
});
describe('handleChangeNetworkRequested*', () => {
const action: ChangeNetworkRequestedAction = {
payload: 'ETH',
type: CONFIG_NETWORKS.CHANGE_NETWORK_REQUESTED
};
const nextNodeName = makeAutoNodeName(action.payload);
const customNode: CustomNodeConfig = {
id: 'id',
url: 'url',
name: 'Custom Node',
service: 'your custom node',
network: action.payload,
isCustom: true
};
const gen = cloneableGenerator(handleChangeNetworkRequested);
const staticCase = gen(action);
let customCase: SagaIteratorClone;
let failureCase: SagaIteratorClone;
it('should select isStaticNodeId', () => {
expect(staticCase.next().value).toEqual(select(isStaticNodeId, nextNodeName));
});
it('should put changeNodeRequested for auto node if static network', () => {
customCase = staticCase.clone();
expect(staticCase.next(true).value).toEqual(put(changeNodeRequested(nextNodeName)));
expect(staticCase.next().done).toBeTruthy();
});
it('should select getAllNodes if non-static network', () => {
expect(customCase.next(false).value).toEqual(select(getAllNodes));
});
it('should put changeNodeRequested on the first custom node if found', () => {
failureCase = customCase.clone();
expect(customCase.next([customNode]).value).toEqual(put(changeNodeRequested(customNode.id)));
});
it('should put showNotification if not a valid network', () => {
const value = failureCase.next([]).value as any;
expect(value.PUT.action.type).toBe('SHOW_NOTIFICATION');
});
});
describe('handleRemoveCustomNode*', () => {
const customNodeUrl = 'https://mycustomnode.com';
const action: RemoveCustomNodeAction = {
type: CONFIG_NODES_CUSTOM.REMOVE,
payload: customNodeUrl
};
const sameCase = cloneableGenerator(handleRemoveCustomNode)(action);
let diffCase: SagaIteratorClone;
it('Should select getNodeId', () => {
expect(sameCase.next().value).toEqual(select(getNodeId));
});
it('Should put changeNodeForce to default network if current node id === removed node id', () => {
diffCase = sameCase.clone();
expect(sameCase.next(customNodeUrl).value).toEqual(
put(changeNodeForce(SELECTED_NODE_INITIAL_STATE.nodeId))
);
});
it('Should do nothing if current node id !== removed node id', () => {
expect(diffCase.next('Different').done).toBeTruthy();
});
});