mirror of
https://github.com/status-im/MyCrypto.git
synced 2025-01-10 19:16:10 +00:00
e761b9d1fb
* Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Create a ducks/ implementation for addressBook * Duck-ize notifications * Duck-ize customTokens * Duck-ize deterministicWallets * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * spec files in same directory * Rename top-level redux directory * Duck-ize gas * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons. * Incorporate ducks pattern on updates addressBook * Fix typeerror * Migrate messages to ducks * For Henry * Duckify onboardStatus * Duckify paritySigner * Duckify rates * Duckify transactions * Duckerize wallet * Reduckerate config * Adjust exports and tests of every duck so far * Duckify ENS * Duckerificate schedule * Duckificate swap * Actually use the new sagas; fix a circular dependency problem. * Duckify transaction (phew) * Add basics to redux/ directory * Remove non-ducked redux stuff * First sweep of redux/ directory * Combine redundant imports * Fix more linting stuff. * A few more type fixes * Welp... now I know not to use index. * Sweep components/ * Sweep through containers/ * Im really starting to get frustrated * The dawn of a new age. * Linter fixes. * De-flatten config/ reducers * Do my thang on config selectors * Adjust all references to config * Split up ens reducers * Wrap up de-nesting ENS * Big boy refactor * Split transaction into its reducers * Fix reducers in transaction/ * Stopping point * Adjust references to transaction from components * Fix references to selectors * Nest broadcast actions * Nest field actions * Nest meta actions * Nest network actions * Nest sign actions * Nest broadcast types * Nested fields types * Nest meta types * Nested network types * Nested sign types * Implement transaction saga changes * Huh? No prepush problems? * Update snappshot * Reintroduce deleted tests * A few missing tests found * Found three missing transaction tests * Found more tests * Found the rest of the tests, woohoo. * Renamed TypeKeys in TRANSACTION * Specify TRANSACTION_BROADCAST * Pretty up these imports * Specify TRANSACTION_FIELDS * Specify TRANSACTION_META * Specify TRANSACTION_NETWORK * Specify TRANSACTION_SIGN * Adjust imports and add translations * Update config snapshot * Post-merge * Temporary fix for DW/Config sagas so Daniel can continue smoke testing * Remove first circulat dependency * Fix more circular dependencies * Properly structure config indices * Further restructure config * Prepare for idea * Target directly from within features/ * Remove that circular dependency -- woohoo * Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance * Un-comment the component-in-redux phenomenon * Move onLoad to the store file * Adjust addressBook imports/exports * Adjusted imports/exports for customTokens * Adjust imports/exports of deterministicWallets * Adjust imports/exports of ens * Restructure imports/exports of gas * Restructure imports/exports for message * Adjust imports/exports of notifications * Restructure onboardStatus imports/exports * Restructure paritySigner imports/exports * Restructure rates imports/exports * Restructure schedule imports/exports * Fix broadcastweb3handler test * Restructure swap imports/exports/ * Restructure transactionS imports/exports * Restructured wallet imports and exports * Hoist all necessary selectors aside from config/**/* and transaction/**/* * Hoist all top-level selectors from transaction * [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj * Implement right-click context menu (#1780) @ bryanwb * No Private Keys Online (#1466) @ wbobeirne * Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne * [Fix] Make ENS Value Consistent (#1956) @ skubakdj * Auto token add (#1808) @ HenryNguyen5 * Electron Ledger + Trezor Support (#1836) @ wbobeirne * Fix Context Menu Popup Parameters (#1957) * Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne * Change displayed notification back in helpers.tsx * Remove newline on shell files * Re-add newlines * Remove newling on .travis.yml * Prettier two files * Re-add index.scss import in OnboardModal * Restructure transaction subdirectories * Everything in transaction/ except for sagas * Restructure transaction imports/exports * Nest broadcast sagas * Nest fields * Nest meta * Nest network * Nest sign * Use generic names for reduxy stuff in the same directory to save space * Do everything every in the whole wide world
397 lines
12 KiB
TypeScript
397 lines
12 KiB
TypeScript
import { toChecksumAddress, isValidPrivate } from 'ethereumjs-util';
|
|
import { isValidChecksumAddress as isValidChecksumRSKAddress } from 'rskjs-util';
|
|
import WalletAddressValidator from 'wallet-address-validator';
|
|
import { Validator } from 'jsonschema';
|
|
import BN from 'bn.js';
|
|
|
|
import { dPathRegex, ETC_LEDGER, ETH_SINGULAR } from 'config/dpaths';
|
|
import { translateRaw } from 'translations';
|
|
import { stripHexPrefix } from 'libs/formatters';
|
|
import { isPositiveInteger } from 'utils/helpers';
|
|
import {
|
|
GAS_LIMIT_LOWER_BOUND,
|
|
GAS_LIMIT_UPPER_BOUND,
|
|
GAS_PRICE_GWEI_LOWER_BOUND,
|
|
GAS_PRICE_GWEI_UPPER_BOUND
|
|
} from 'config/constants';
|
|
import { JsonRpcResponse } from './nodes/rpc/types';
|
|
import { normalise } from './ens';
|
|
import { EAC_SCHEDULING_CONFIG } from './scheduling';
|
|
|
|
export function getIsValidAddressFunction(chainId: number) {
|
|
if (chainId === 30 || chainId === 31) {
|
|
return (address: string) => isValidRSKAddress(address, chainId);
|
|
}
|
|
return isValidETHAddress;
|
|
}
|
|
|
|
export function isValidAddress(address: string, chainId: number) {
|
|
return getIsValidAddressFunction(chainId)(address);
|
|
}
|
|
|
|
function isValidETHLikeAddress(address: string, extraChecks?: () => boolean): boolean {
|
|
if (address === '0x0000000000000000000000000000000000000000') {
|
|
return false;
|
|
}
|
|
if (address.substring(0, 2) !== '0x') {
|
|
return false;
|
|
} else if (!/^(0x)?[0-9a-f]{40}$/i.test(address)) {
|
|
return false;
|
|
} else if (/^(0x)?[0-9a-f]{40}$/.test(address) || /^(0x)?[0-9A-F]{40}$/.test(address)) {
|
|
return true;
|
|
} else {
|
|
return extraChecks ? extraChecks() : false;
|
|
}
|
|
}
|
|
|
|
export function isValidETHAddress(address: string): boolean {
|
|
return isValidETHLikeAddress(address, () => isChecksumAddress(address));
|
|
}
|
|
|
|
export function isValidRSKAddress(address: string, chainId: number): boolean {
|
|
return isValidETHLikeAddress(address, () => isValidChecksumRSKAddress(address, chainId));
|
|
}
|
|
|
|
export const isCreationAddress = (address: string): boolean =>
|
|
address === '0x0' || address === '0x0000000000000000000000000000000000000000';
|
|
|
|
export function isValidBTCAddress(address: string): boolean {
|
|
return WalletAddressValidator.validate(address, 'BTC');
|
|
}
|
|
|
|
export function isValidHex(str: string): boolean {
|
|
if (str === '') {
|
|
return true;
|
|
}
|
|
str = str.substring(0, 2) === '0x' ? str.substring(2).toUpperCase() : str.toUpperCase();
|
|
const re = /^[0-9A-F]*$/g; // Match 0 -> unlimited times, 0 being "0x" case
|
|
return re.test(str);
|
|
}
|
|
|
|
export function isValidENSorEtherAddress(address: string): boolean {
|
|
return isValidETHAddress(address) || isValidENSAddress(address);
|
|
}
|
|
|
|
export function isValidENSName(str: string) {
|
|
try {
|
|
return str.length > 6 && normalise(str) !== '' && str.substring(0, 2) !== '0x';
|
|
} catch (e) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
export function isValidENSAddress(address: string): boolean {
|
|
try {
|
|
const normalized = normalise(address);
|
|
const tld = normalized.substr(normalized.lastIndexOf('.') + 1);
|
|
const validTLDs = {
|
|
eth: true,
|
|
test: true,
|
|
reverse: true
|
|
};
|
|
if (validTLDs[tld as keyof typeof validTLDs]) {
|
|
return true;
|
|
}
|
|
} catch (e) {
|
|
return false;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
function isChecksumAddress(address: string): boolean {
|
|
return address === toChecksumAddress(address);
|
|
}
|
|
|
|
export function isValidPrivKey(privkey: string | Buffer): boolean {
|
|
if (typeof privkey === 'string') {
|
|
const strippedKey = stripHexPrefix(privkey);
|
|
const initialCheck = strippedKey.length === 64;
|
|
if (initialCheck) {
|
|
const keyBuffer = Buffer.from(strippedKey, 'hex');
|
|
return isValidPrivate(keyBuffer);
|
|
}
|
|
return false;
|
|
} else if (privkey instanceof Buffer) {
|
|
return privkey.length === 32 && isValidPrivate(privkey);
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
export function isValidEncryptedPrivKey(privkey: string): boolean {
|
|
if (typeof privkey === 'string') {
|
|
return privkey.length === 128 || privkey.length === 132;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
export const validNumber = (num: number) => isFinite(num) && num >= 0;
|
|
export const validPositiveNumber = (num: number) => validNumber(num) && num !== 0;
|
|
|
|
export const validDecimal = (input: string, decimal: number) => {
|
|
const arr = input.split('.');
|
|
const fractionPortion = arr[1];
|
|
if (!fractionPortion || fractionPortion.length === 0) {
|
|
return true;
|
|
}
|
|
const decimalLength = fractionPortion.length;
|
|
return decimalLength <= decimal;
|
|
};
|
|
|
|
export function isPositiveIntegerOrZero(num: number): boolean {
|
|
if (isNaN(num) || !isFinite(num)) {
|
|
return false;
|
|
}
|
|
return num >= 0 && parseInt(num.toString(), 10) === num;
|
|
}
|
|
|
|
export function isValidPath(dPath: string) {
|
|
// ETC Ledger is incorrect up due to an extra ' at the end of it
|
|
if (dPath === ETC_LEDGER.value) {
|
|
return true;
|
|
}
|
|
|
|
// SingularDTV is incorrect due to using a 0 instead of a 44 as the purpose
|
|
if (dPath === ETH_SINGULAR.value) {
|
|
return true;
|
|
}
|
|
|
|
return dPathRegex.test(dPath);
|
|
}
|
|
|
|
export const isValidValue = (value: string) =>
|
|
!!(value && isFinite(Number(value)) && Number(value) >= 0);
|
|
|
|
export const gasLimitValidator = (gasLimit: number | string) => {
|
|
const gasLimitFloat = typeof gasLimit === 'string' ? Number(gasLimit) : gasLimit;
|
|
return (
|
|
validNumber(gasLimitFloat) &&
|
|
gasLimitFloat >= GAS_LIMIT_LOWER_BOUND &&
|
|
gasLimitFloat <= GAS_LIMIT_UPPER_BOUND
|
|
);
|
|
};
|
|
|
|
export const gasPriceValidator = (gasPrice: number | string): boolean => {
|
|
const gasPriceFloat = typeof gasPrice === 'string' ? Number(gasPrice) : gasPrice;
|
|
return (
|
|
validNumber(gasPriceFloat) &&
|
|
gasPriceFloat >= GAS_PRICE_GWEI_LOWER_BOUND &&
|
|
gasPriceFloat <= GAS_PRICE_GWEI_UPPER_BOUND
|
|
);
|
|
};
|
|
|
|
export const timeBountyValidator = (timeBounty: BN | number | string | null): boolean => {
|
|
if (!timeBounty) {
|
|
return false;
|
|
}
|
|
|
|
if (timeBounty instanceof BN) {
|
|
return (
|
|
timeBounty.gte(EAC_SCHEDULING_CONFIG.TIME_BOUNTY_MIN) &&
|
|
timeBounty.lte(EAC_SCHEDULING_CONFIG.TIME_BOUNTY_MAX)
|
|
);
|
|
}
|
|
|
|
const timeBountyFloat = typeof timeBounty === 'string' ? Number(timeBounty) : timeBounty;
|
|
|
|
return validNumber(timeBountyFloat);
|
|
};
|
|
|
|
export const isValidByteCode = (byteCode: string) =>
|
|
byteCode && byteCode.length > 0 && byteCode.length % 2 === 0;
|
|
|
|
export const isValidAbiJson = (abiJson: string) =>
|
|
abiJson && abiJson.startsWith('[') && abiJson.endsWith(']');
|
|
|
|
// JSONSchema Validations for Rpc responses
|
|
const v = new Validator();
|
|
|
|
export const schema = {
|
|
RpcNode: {
|
|
type: 'object',
|
|
additionalProperties: false,
|
|
properties: {
|
|
jsonrpc: { type: 'string' },
|
|
id: { oneOf: [{ type: 'string' }, { type: 'integer' }] },
|
|
result: {
|
|
oneOf: [{ type: 'string' }, { type: 'array' }, { type: 'object' }]
|
|
},
|
|
status: { type: 'string' },
|
|
message: { type: 'string', maxLength: 2 }
|
|
}
|
|
}
|
|
};
|
|
|
|
export const isValidNonce = (value: string): boolean => {
|
|
let valid;
|
|
if (value === '0') {
|
|
valid = true;
|
|
} else if (!value) {
|
|
valid = false;
|
|
} else {
|
|
valid = isPositiveInteger(+value);
|
|
}
|
|
return valid;
|
|
};
|
|
|
|
function isValidResult(response: JsonRpcResponse, schemaFormat: typeof schema.RpcNode): boolean {
|
|
return v.validate(response, schemaFormat).valid;
|
|
}
|
|
|
|
function formatErrors(response: JsonRpcResponse, apiType: string) {
|
|
if (response.error) {
|
|
// Metamask errors are sometimes full-blown stacktraces, no bueno. Instead,
|
|
// We'll just take the first line of it, and the last thing after all of
|
|
// the colons. An example error message would be:
|
|
// "Error: Metamask Sign Tx Error: User rejected the signature."
|
|
const lines = response.error.message.split('\n');
|
|
if (lines.length > 2) {
|
|
return lines[0].split(':').pop();
|
|
} else {
|
|
return `${response.error.message} ${response.error.data || ''}`;
|
|
}
|
|
}
|
|
return `Invalid ${apiType} Error`;
|
|
}
|
|
|
|
enum API_NAME {
|
|
Get_Balance = 'Get Balance',
|
|
Estimate_Gas = 'Estimate Gas',
|
|
Call_Request = 'Call Request',
|
|
Token_Balance = 'Token Balance',
|
|
Transaction_Count = 'Transaction Count',
|
|
Current_Block = 'Current Block',
|
|
Raw_Tx = 'Raw Tx',
|
|
Send_Transaction = 'Send Transaction',
|
|
Sign_Message = 'Sign Message',
|
|
Get_Accounts = 'Get Accounts',
|
|
Net_Version = 'Net Version',
|
|
Transaction_By_Hash = 'Transaction By Hash',
|
|
Transaction_Receipt = 'Transaction Receipt'
|
|
}
|
|
|
|
const isValidEthCall = (response: JsonRpcResponse, schemaType: typeof schema.RpcNode) => (
|
|
apiName: API_NAME,
|
|
cb?: (res: JsonRpcResponse) => any
|
|
) => {
|
|
if (!isValidResult(response, schemaType)) {
|
|
if (cb) {
|
|
return cb(response);
|
|
}
|
|
throw new Error(formatErrors(response, apiName));
|
|
}
|
|
return response;
|
|
};
|
|
|
|
export const isValidGetBalance = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Get_Balance);
|
|
|
|
export const isValidEstimateGas = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Estimate_Gas);
|
|
|
|
export const isValidCallRequest = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Call_Request);
|
|
|
|
export const isValidTokenBalance = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Token_Balance, () => ({
|
|
result: 'Failed'
|
|
}));
|
|
|
|
export const isValidTransactionCount = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Transaction_Count);
|
|
|
|
export const isValidTransactionByHash = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Transaction_By_Hash);
|
|
|
|
export const isValidTransactionReceipt = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Transaction_Receipt);
|
|
|
|
export const isValidCurrentBlock = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Current_Block);
|
|
|
|
export const isValidRawTxApi = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Raw_Tx);
|
|
|
|
export const isValidSendTransaction = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Send_Transaction);
|
|
|
|
export const isValidSignMessage = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Sign_Message);
|
|
|
|
export const isValidGetAccounts = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Get_Accounts);
|
|
|
|
export const isValidGetNetVersion = (response: JsonRpcResponse) =>
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Net_Version);
|
|
export const isValidTxHash = (hash: string) =>
|
|
hash.substring(0, 2) === '0x' && hash.length === 66 && isValidHex(hash);
|
|
|
|
export function isValidLabelLength(label: string, options: { allowEmpty?: boolean } = {}): boolean {
|
|
const meetsMinimumLengthRequirement = label.length >= 2;
|
|
const meetsMaximumLengthRequirement = label.length <= 50;
|
|
const labelOnlyContainsSpaces = !label.trim();
|
|
|
|
if (options.allowEmpty && label.length === 0) {
|
|
return true;
|
|
}
|
|
|
|
if (!options.allowEmpty && labelOnlyContainsSpaces) {
|
|
return false;
|
|
}
|
|
|
|
return meetsMinimumLengthRequirement && meetsMaximumLengthRequirement;
|
|
}
|
|
|
|
export function isLabelWithoutENS(label: string): boolean {
|
|
const ensTlds = ['.eth', '.test', '.reverse'];
|
|
|
|
for (const tld of ensTlds) {
|
|
if (label.includes(tld)) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
export function isValidAddressLabel(
|
|
address: string,
|
|
label: string,
|
|
addresses: { [address: string]: string },
|
|
labels: { [label: string]: string },
|
|
chainId: number
|
|
) {
|
|
const addressAlreadyExists = !!addresses[address.toLowerCase()];
|
|
const labelAlreadyExists = !!labels[label];
|
|
const result: { isValid: boolean; addressError?: string; labelError?: string } = {
|
|
isValid: true
|
|
};
|
|
|
|
if (!isValidAddress(address, chainId)) {
|
|
result.addressError = translateRaw('INVALID_ADDRESS');
|
|
}
|
|
|
|
if (addressAlreadyExists) {
|
|
result.addressError = translateRaw('ADDRESS_ALREADY_EXISTS');
|
|
}
|
|
|
|
if (!isValidLabelLength(label)) {
|
|
result.labelError = translateRaw('INVALID_LABEL_LENGTH');
|
|
}
|
|
|
|
if (!isLabelWithoutENS(label)) {
|
|
result.labelError = translateRaw('LABEL_CANNOT_CONTAIN_ENS_SUFFIX');
|
|
}
|
|
|
|
if (labelAlreadyExists) {
|
|
result.labelError = translateRaw('LABEL_ALREADY_EXISTS');
|
|
}
|
|
|
|
if (result.addressError || result.labelError) {
|
|
result.isValid = false;
|
|
}
|
|
|
|
return result;
|
|
}
|