mirror of
https://github.com/status-im/MyCrypto.git
synced 2025-01-11 19:44:21 +00:00
e761b9d1fb
* Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Create a ducks/ implementation for addressBook * Duck-ize notifications * Duck-ize customTokens * Duck-ize deterministicWallets * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * spec files in same directory * Rename top-level redux directory * Duck-ize gas * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons. * Incorporate ducks pattern on updates addressBook * Fix typeerror * Migrate messages to ducks * For Henry * Duckify onboardStatus * Duckify paritySigner * Duckify rates * Duckify transactions * Duckerize wallet * Reduckerate config * Adjust exports and tests of every duck so far * Duckify ENS * Duckerificate schedule * Duckificate swap * Actually use the new sagas; fix a circular dependency problem. * Duckify transaction (phew) * Add basics to redux/ directory * Remove non-ducked redux stuff * First sweep of redux/ directory * Combine redundant imports * Fix more linting stuff. * A few more type fixes * Welp... now I know not to use index. * Sweep components/ * Sweep through containers/ * Im really starting to get frustrated * The dawn of a new age. * Linter fixes. * De-flatten config/ reducers * Do my thang on config selectors * Adjust all references to config * Split up ens reducers * Wrap up de-nesting ENS * Big boy refactor * Split transaction into its reducers * Fix reducers in transaction/ * Stopping point * Adjust references to transaction from components * Fix references to selectors * Nest broadcast actions * Nest field actions * Nest meta actions * Nest network actions * Nest sign actions * Nest broadcast types * Nested fields types * Nest meta types * Nested network types * Nested sign types * Implement transaction saga changes * Huh? No prepush problems? * Update snappshot * Reintroduce deleted tests * A few missing tests found * Found three missing transaction tests * Found more tests * Found the rest of the tests, woohoo. * Renamed TypeKeys in TRANSACTION * Specify TRANSACTION_BROADCAST * Pretty up these imports * Specify TRANSACTION_FIELDS * Specify TRANSACTION_META * Specify TRANSACTION_NETWORK * Specify TRANSACTION_SIGN * Adjust imports and add translations * Update config snapshot * Post-merge * Temporary fix for DW/Config sagas so Daniel can continue smoke testing * Remove first circulat dependency * Fix more circular dependencies * Properly structure config indices * Further restructure config * Prepare for idea * Target directly from within features/ * Remove that circular dependency -- woohoo * Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance * Un-comment the component-in-redux phenomenon * Move onLoad to the store file * Adjust addressBook imports/exports * Adjusted imports/exports for customTokens * Adjust imports/exports of deterministicWallets * Adjust imports/exports of ens * Restructure imports/exports of gas * Restructure imports/exports for message * Adjust imports/exports of notifications * Restructure onboardStatus imports/exports * Restructure paritySigner imports/exports * Restructure rates imports/exports * Restructure schedule imports/exports * Fix broadcastweb3handler test * Restructure swap imports/exports/ * Restructure transactionS imports/exports * Restructured wallet imports and exports * Hoist all necessary selectors aside from config/**/* and transaction/**/* * Hoist all top-level selectors from transaction * [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj * Implement right-click context menu (#1780) @ bryanwb * No Private Keys Online (#1466) @ wbobeirne * Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne * [Fix] Make ENS Value Consistent (#1956) @ skubakdj * Auto token add (#1808) @ HenryNguyen5 * Electron Ledger + Trezor Support (#1836) @ wbobeirne * Fix Context Menu Popup Parameters (#1957) * Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne * Change displayed notification back in helpers.tsx * Remove newline on shell files * Re-add newlines * Remove newling on .travis.yml * Prettier two files * Re-add index.scss import in OnboardModal * Restructure transaction subdirectories * Everything in transaction/ except for sagas * Restructure transaction imports/exports * Nest broadcast sagas * Nest fields * Nest meta * Nest network * Nest sign * Use generic names for reduxy stuff in the same directory to save space * Do everything every in the whole wide world
408 lines
12 KiB
TypeScript
408 lines
12 KiB
TypeScript
import BN from 'bn.js';
|
|
import { SagaIterator } from 'redux-saga';
|
|
import { call, select, put } from 'redux-saga/effects';
|
|
import { cloneableGenerator, SagaIteratorClone } from 'redux-saga/utils';
|
|
import { bufferToHex, toBuffer } from 'ethereumjs-util';
|
|
|
|
import { encodeTransfer } from 'libs/transaction';
|
|
import { Address, Wei } from 'libs/units';
|
|
import configuredStore from 'features/store';
|
|
import * as derivedSelectors from 'features/selectors';
|
|
import * as configSelectors from 'features/config/selectors';
|
|
import { scheduleActions } from 'features/schedule';
|
|
import { transactionFieldsActions, transactionFieldsSelectors } from '../fields';
|
|
import * as transactionActions from '../actions';
|
|
import * as transactionSelectors from '../selectors';
|
|
import * as transactionHelpers from '../helpers';
|
|
import * as selectors from './selectors';
|
|
import * as sagas from './sagas';
|
|
|
|
describe('Meta Sagas', () => {
|
|
describe('Token', () => {
|
|
configuredStore.getState();
|
|
|
|
const itShouldBeDone = (gen: SagaIterator) => {
|
|
it('should be done', () => {
|
|
expect(gen.next().done).toEqual(true);
|
|
});
|
|
};
|
|
|
|
describe('handleTokenTo*', () => {
|
|
const action: any = {
|
|
payload: {
|
|
value: 'value1'
|
|
}
|
|
};
|
|
const tokenValue: any = {
|
|
value: 'value2'
|
|
};
|
|
const data: any = 'data';
|
|
|
|
const gens: any = {};
|
|
gens.gen = cloneableGenerator(sagas.handleTokenTo)(action);
|
|
|
|
it('should select getTokenValue', () => {
|
|
expect(gens.gen.next().value).toEqual(select(selectors.getTokenValue));
|
|
});
|
|
|
|
it('should return if !tokenValue.value', () => {
|
|
gens.clone1 = gens.gen.clone();
|
|
expect(gens.clone1.next({ value: false }).done).toEqual(true);
|
|
});
|
|
|
|
it('should call encodeTransfer', () => {
|
|
expect(gens.gen.next(tokenValue).value).toEqual(
|
|
call(encodeTransfer, action.payload.value, tokenValue.value)
|
|
);
|
|
});
|
|
|
|
it('should put setDataField', () => {
|
|
expect(gens.gen.next(data).value).toEqual(
|
|
put(
|
|
transactionFieldsActions.setDataField({
|
|
raw: bufferToHex(data),
|
|
value: data
|
|
})
|
|
)
|
|
);
|
|
});
|
|
|
|
itShouldBeDone(gens.gen);
|
|
});
|
|
|
|
describe('handleTokenValue*', () => {
|
|
const action: any = {
|
|
payload: {
|
|
value: 'value1'
|
|
}
|
|
};
|
|
const tokenTo: any = {
|
|
value: 'value2'
|
|
};
|
|
const data: any = toBuffer('0x0a');
|
|
const prevData: any = {
|
|
raw: '0x0b'
|
|
};
|
|
|
|
const gens: any = {};
|
|
gens.gen = cloneableGenerator(sagas.handleTokenValue)(action);
|
|
|
|
it('should select getTokenTo', () => {
|
|
expect(gens.gen.next().value).toEqual(select(selectors.getTokenTo));
|
|
});
|
|
|
|
it('should select getData', () => {
|
|
gens.clone1 = gens.gen.clone();
|
|
expect(gens.gen.next(tokenTo).value).toEqual(select(transactionFieldsSelectors.getData));
|
|
});
|
|
|
|
it('should return if !tokenTo.value', () => {
|
|
gens.clone1.next({ value: false });
|
|
expect(gens.clone1.next().done).toEqual(true);
|
|
});
|
|
|
|
it('should call encodeTransfer', () => {
|
|
expect(gens.gen.next(prevData).value).toEqual(
|
|
call(encodeTransfer, tokenTo.value, action.payload.value)
|
|
);
|
|
});
|
|
|
|
it('should put setDataField', () => {
|
|
gens.clone2 = gens.gen.clone();
|
|
expect(gens.gen.next(data).value).toEqual(
|
|
put(transactionFieldsActions.setDataField({ raw: bufferToHex(data), value: data }))
|
|
);
|
|
});
|
|
|
|
it('should return if prevData is equal to data', () => {
|
|
const sameData = toBuffer('0xb');
|
|
expect(gens.clone2.next(sameData).done).toEqual(true);
|
|
});
|
|
|
|
itShouldBeDone(gens.gen);
|
|
});
|
|
});
|
|
|
|
describe('Unit Swap', () => {
|
|
const itShouldBeDone = (gen: SagaIterator) => {
|
|
it('should be done', () => {
|
|
expect(gen.next().done).toEqual(true);
|
|
});
|
|
};
|
|
|
|
describe('handleSetUnitMeta*', () => {
|
|
const expectedStart = (
|
|
gen: SagaIterator,
|
|
previousUnit: string,
|
|
currentUnit: string,
|
|
prevUnitIsNetworkUnit: boolean,
|
|
currUnitIsNetworkUnit: boolean
|
|
) => {
|
|
it('should select getPreviousUnit', () => {
|
|
expect(gen.next().value).toEqual(select(transactionSelectors.getPreviousUnit));
|
|
});
|
|
|
|
it('should check if prevUnit is a network unit', () => {
|
|
expect(gen.next(previousUnit).value).toEqual(
|
|
select(configSelectors.isNetworkUnit, previousUnit)
|
|
);
|
|
});
|
|
|
|
it('should check if currUnit is a network unit', () => {
|
|
expect(gen.next(prevUnitIsNetworkUnit).value).toEqual(
|
|
select(configSelectors.isNetworkUnit, currentUnit)
|
|
);
|
|
});
|
|
|
|
it('should select getDeciimalFromUnit with currentUnit', () => {
|
|
expect(gen.next(currUnitIsNetworkUnit).value).toEqual(
|
|
select(derivedSelectors.getDecimalFromUnit, currentUnit)
|
|
);
|
|
});
|
|
};
|
|
|
|
describe('etherToEther', () => {
|
|
const currentUnit = 'ETH';
|
|
const previousUnit = 'ETH';
|
|
const action: any = {
|
|
payload: currentUnit
|
|
};
|
|
const gen = sagas.handleSetUnitMeta(action);
|
|
|
|
expectedStart(gen, previousUnit, currentUnit, true, true);
|
|
|
|
it('should return correctly', () => {
|
|
expect(gen.next().value).toEqual(undefined);
|
|
});
|
|
|
|
itShouldBeDone(gen);
|
|
});
|
|
|
|
describe('tokenToEther', () => {
|
|
const previousUnit = 'token';
|
|
const currentUnit = 'ETH';
|
|
const action: any = {
|
|
payload: currentUnit
|
|
};
|
|
const decimal = 1;
|
|
const tokenTo: any = 'tokenTo';
|
|
const tokenValue: any = 'tokenValue';
|
|
const raw = 'raw';
|
|
const value: any = 'value';
|
|
const gen = sagas.handleSetUnitMeta(action);
|
|
|
|
expectedStart(gen, previousUnit, currentUnit, false, true);
|
|
|
|
it('should select getTokenTo', () => {
|
|
expect(gen.next(decimal).value).toEqual(select(selectors.getTokenTo));
|
|
});
|
|
|
|
it('should select getTokenValue', () => {
|
|
expect(gen.next(tokenTo).value).toEqual(select(selectors.getTokenValue));
|
|
});
|
|
|
|
it('should call rebaseUserInput with tokenValue', () => {
|
|
expect(gen.next(tokenValue).value).toEqual(
|
|
call(transactionHelpers.rebaseUserInput, tokenValue)
|
|
);
|
|
});
|
|
|
|
it('should call validateInput with value and currentUnit', () => {
|
|
expect(gen.next({ value, raw }).value).toEqual(
|
|
call(transactionHelpers.validateInput, value, currentUnit)
|
|
);
|
|
});
|
|
|
|
it('should put swapTokenToEther', () => {
|
|
expect(gen.next(true).value).toEqual(
|
|
put(
|
|
transactionActions.swapTokenToEther({
|
|
to: tokenTo,
|
|
value: {
|
|
raw,
|
|
value
|
|
},
|
|
decimal
|
|
} as any)
|
|
)
|
|
);
|
|
});
|
|
|
|
itShouldBeDone(gen);
|
|
});
|
|
|
|
describe('etherToToken || tokenToToken', () => {
|
|
const sharedLogicA = (gen: SagaIteratorClone, decimal: number, currentUnit: string) => {
|
|
it('should select getToken with currentUnit', () => {
|
|
expect(gen.next(decimal).value).toEqual(select(derivedSelectors.getToken, currentUnit));
|
|
});
|
|
|
|
it('should throw error if !currentToken', () => {
|
|
const clone = gen.clone();
|
|
expect(() => clone.next(false)).toThrowError('Could not find token during unit swap');
|
|
});
|
|
};
|
|
|
|
const sharedLogicB = (
|
|
gen: SagaIterator,
|
|
input: string,
|
|
raw: string,
|
|
value: BN,
|
|
currentUnit: string,
|
|
isValid: boolean
|
|
) => {
|
|
it('should call rebaseUserInput with input', () => {
|
|
expect(gen.next(input).value).toEqual(
|
|
call(transactionHelpers.rebaseUserInput, input as any)
|
|
);
|
|
});
|
|
|
|
it('should call validateInput with value and currentUnit', () => {
|
|
expect(gen.next({ raw, value }).value).toEqual(
|
|
call(transactionHelpers.validateInput, value, currentUnit)
|
|
);
|
|
});
|
|
|
|
it('should select getTo', () => {
|
|
expect(gen.next(isValid).value).toEqual(select(transactionFieldsSelectors.getTo));
|
|
});
|
|
};
|
|
|
|
const constructExpectedPayload = (
|
|
data: Buffer,
|
|
toAddress: string,
|
|
raw: string,
|
|
value: BN,
|
|
decimal: number,
|
|
tokenTo?: any
|
|
) => {
|
|
const base = {
|
|
data: { raw: bufferToHex(data), value: data },
|
|
to: { raw: '', value: Address(toAddress) },
|
|
tokenValue: { raw, value },
|
|
decimal
|
|
};
|
|
if (!tokenTo) {
|
|
return base;
|
|
}
|
|
return {
|
|
...base,
|
|
tokenTo
|
|
};
|
|
};
|
|
|
|
describe('etherToToken', () => {
|
|
const previousUnit = 'ETH';
|
|
const currentUnit = 'token';
|
|
const action: any = {
|
|
payload: currentUnit
|
|
};
|
|
const currentToken = {
|
|
address: '0x0'
|
|
};
|
|
const decimal = 1;
|
|
const input = 'input';
|
|
const raw = 'raw';
|
|
const value = Wei('100');
|
|
const isValid = true;
|
|
const to = { value: value.toBuffer() };
|
|
|
|
const gens: any = {};
|
|
gens.gen = cloneableGenerator(sagas.handleSetUnitMeta)(action);
|
|
|
|
expectedStart(gens.gen, previousUnit, currentUnit, true, false);
|
|
|
|
sharedLogicA(gens.gen, decimal, currentUnit);
|
|
|
|
it('should select getValue', () => {
|
|
expect(gens.gen.next(currentToken).value).toEqual(
|
|
select(transactionFieldsSelectors.getValue)
|
|
);
|
|
});
|
|
|
|
sharedLogicB(gens.gen, input, raw, value, currentUnit, isValid);
|
|
|
|
it('should put setSchedulingToogle', () => {
|
|
expect(gens.gen.next(to).value).toEqual(
|
|
put(
|
|
scheduleActions.setSchedulingToggle({
|
|
value: false
|
|
})
|
|
)
|
|
);
|
|
});
|
|
|
|
it('should put swapEtherToToken', () => {
|
|
const data = encodeTransfer(to.value, value);
|
|
const payload: any = constructExpectedPayload(
|
|
data,
|
|
currentToken.address,
|
|
raw,
|
|
value,
|
|
decimal,
|
|
to
|
|
);
|
|
|
|
expect(gens.gen.next(to).value).toEqual(
|
|
put(transactionActions.swapEtherToToken(payload))
|
|
);
|
|
});
|
|
|
|
itShouldBeDone(gens.gen);
|
|
});
|
|
|
|
describe('tokenToToken', () => {
|
|
const previousUnit = 'token';
|
|
const currentUnit = 'token';
|
|
const action: any = {
|
|
payload: currentUnit
|
|
};
|
|
const currentToken = {
|
|
address: '0x1'
|
|
};
|
|
const decimal = 1;
|
|
const input = 'input';
|
|
const raw = 'raw';
|
|
const value = Wei('100');
|
|
const isValid = true;
|
|
const to = { value: '0xa' };
|
|
const tokenTo = { value: '0xb' };
|
|
|
|
const gens: any = {};
|
|
gens.gen = cloneableGenerator(sagas.handleSetUnitMeta)(action);
|
|
|
|
expectedStart(gens.gen, previousUnit, currentUnit, false, false);
|
|
|
|
sharedLogicA(gens.gen, decimal, currentUnit);
|
|
|
|
it('should select getTokenValue', () => {
|
|
expect(gens.gen.next(currentToken).value).toEqual(select(selectors.getTokenValue));
|
|
});
|
|
|
|
sharedLogicB(gens.gen, input, raw, value, currentUnit, isValid);
|
|
|
|
it('should select getTokenTo', () => {
|
|
expect(gens.gen.next(to).value).toEqual(select(selectors.getTokenTo));
|
|
});
|
|
|
|
it('should put swapEtherToToken', () => {
|
|
const data = encodeTransfer(Address(tokenTo.value), value);
|
|
const payload = constructExpectedPayload(
|
|
data,
|
|
currentToken.address,
|
|
raw,
|
|
value,
|
|
decimal
|
|
);
|
|
expect(gens.gen.next(tokenTo).value).toEqual(
|
|
put(transactionActions.swapTokenToToken(payload))
|
|
);
|
|
});
|
|
|
|
itShouldBeDone(gens.gen);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|