MyCrypto/common/features/transaction/selectors.spec.ts
Connor Bryan e761b9d1fb Refactor redux pattern from top-level to ducks (#1936)
* Add a new route for AddressBook

* Further templating of the AddressBook view

* Add initial functionality to handle a table of existing address labels

* Make the linter happy

* Adjust paths

* Factor out TableRow and add common functionality

* Add initial Redux boilerplate for addressBook | fix minor linting issues

* Swap out terminology and types

* Connect up to Redux

* Connect data for AddressBookTable to Redux

* Use temporary fields for addition

* Remove alignment and index column

* Stopping point

* Adjust the sizing of rows to be consistent

* Initial implementation of a dropdown for the address field

* Minor styling to dropdown

* Stopping point

* Apply a focus concept onto the factory

* Add keyboard controls for the address field dropdown

* Adjust label of address field when it matches an addressBook entry

* Properly handle attempting to blur a non-existent component

* Minor styling changes on dropdown box

* Standardize address casing, add accessibility to dropdown

* Create an addressLabel component

* Pass refs correctly and fix some typings

* Exact version

* Add module name mapping for shared/keycodes

* addressBook reducer tests

* Add functionality to DeterministicModal

* Minor changes / Add test for addressBook selectors

* Move out AddressBookTable to a component

* Typing, translation and restructuring

* More typing and translation fixes

* More linting fixes

* More type changes

* Variable name for dropdown background

* Fix TS type errors, lint errors, remove unused props

* Used a different selector and removed method: AddressBookTable

* Linter was mad

* Linter mad again :(

* Add a translation and adjust styling of AddressBookTable

* Move the onBlur to a class method

* Prevent the default behavior of up/down/enter for dropdown

* Let's do it this way instead

* Adjust the styling on DeterministicWalletModal labels

* Change `AddressBookTable` into a pseudo-table using section and div

* Use readable keys vs. keycodes

* Put the dropdown in InputFactory and position it correctly

* Sanitation of label adding and changing

* Prevent duplicate labels in AddressBook and Row

* Add a box shadow and use `invalid` class insted of custom

* Use emphasis vs strong for address in dropdown

* Display the label undernearth the input vs. changing it

* Isolate AccountAddress into its own component

* Introduce interactivity to AccountAddress

* Fully incorporate with Redux

* Validation for AccountAddress

* Add validation notifications for address field on AddressBookTable

* Minor formatting

* Adjust wrappage for optimal flexboxxing

* Make AddressBookTable responsive

* Show an invalid input in "real time" instead of only on submit

* Real time input validation for AddressBookTableRow

* Responsive-ize the To address dropdown

* Hide identicons instead at small enough screen sizes

* Fix repsonsiveness of dropdown further

* Fix responsiveness of table rows and inputs

* Truncate account info and switch identicons to the right for consistency

* Use classnames instead of targetting element directly for DWM

* Display a notice if the entered query doesnt match a label and isnt an addr

* Don't show an error on the To address if its a label entry

* Display an error under AddressBookTableRow in real time

* Display errors in real time for AddressBookTable temp inputs

* Add realtime validation to AccountAddress

* Ensure toChecksumAddress is used when entering labels to address manager

* Show errors even after blurring.

* Create a ducks/ implementation for addressBook

* Duck-ize notifications

* Duck-ize customTokens

* Duck-ize deterministicWallets

* Only show errors on address/label entry if they have been blurred

* On certain inputs, show an invalid input immediately

* spec files in same directory

* Rename top-level redux directory

* Duck-ize gas

* Add displayed errors for labels with 0x and labels containing ens

* Move ENS checking validation out

* Add a saga for addLabelForAddress

* Completely revamp the redux side of Address Manager and test it all

* Adjust components to use new redux addressBook

* Incorporate new redux into AddressBookTableRow and clean up for linter

* Make linter and tests happy

* Another reduxy overhaul

* Still fixing it

* More redux updates

* Finalize redux stuff.

* Incorporate new reduxy way into AddressBookTable & Row

* Incorporate redux changes into Account Address

* Small tests fix

* Add and fix some selector tests

* Addressing Will's comments

* Shortened visibility class for line length reasons.

* Incorporate ducks pattern on updates addressBook

* Fix typeerror

* Migrate messages to ducks

* For Henry

* Duckify onboardStatus

* Duckify paritySigner

* Duckify rates

* Duckify transactions

* Duckerize wallet

* Reduckerate config

* Adjust exports and tests of every duck so far

* Duckify ENS

* Duckerificate schedule

* Duckificate swap

* Actually use the new sagas;  fix a circular dependency problem.

* Duckify transaction (phew)

* Add basics to redux/ directory

* Remove non-ducked redux stuff

* First sweep of redux/ directory

* Combine redundant imports

* Fix more linting stuff.

* A few more type fixes

* Welp... now I know not to use index.

* Sweep components/

* Sweep through containers/

* Im really starting to get frustrated

* The dawn of a new age.

* Linter fixes.

* De-flatten config/ reducers

* Do my thang on config selectors

* Adjust all references to config

* Split up ens reducers

* Wrap up de-nesting ENS

* Big boy refactor

* Split transaction into its reducers

* Fix reducers in transaction/

* Stopping point

* Adjust references to transaction from components

* Fix references to selectors

* Nest broadcast actions

* Nest field actions

* Nest meta actions

* Nest network actions

* Nest sign actions

* Nest broadcast types

* Nested fields types

* Nest meta types

* Nested network types

* Nested sign types

* Implement transaction saga changes

* Huh? No prepush problems?

* Update snappshot

* Reintroduce deleted tests

* A few missing tests found

* Found three missing transaction tests

* Found more tests

* Found the rest of the tests, woohoo.

* Renamed TypeKeys in TRANSACTION

* Specify TRANSACTION_BROADCAST

* Pretty up these imports

* Specify TRANSACTION_FIELDS

* Specify TRANSACTION_META

* Specify TRANSACTION_NETWORK

* Specify TRANSACTION_SIGN

* Adjust imports and add translations

* Update config snapshot

* Post-merge

* Temporary fix for DW/Config sagas so Daniel can continue smoke testing

* Remove first circulat dependency

* Fix more circular dependencies

* Properly structure config indices

* Further restructure config

* Prepare for idea

* Target directly from within features/

* Remove that circular dependency -- woohoo

* Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance

* Un-comment the component-in-redux phenomenon

* Move onLoad to the store file

* Adjust addressBook imports/exports

* Adjusted imports/exports for customTokens

* Adjust imports/exports of deterministicWallets

* Adjust imports/exports of ens

* Restructure imports/exports of gas

* Restructure imports/exports for message

* Adjust imports/exports of notifications

* Restructure onboardStatus imports/exports

* Restructure paritySigner imports/exports

* Restructure rates imports/exports

* Restructure schedule imports/exports

* Fix broadcastweb3handler test

* Restructure swap imports/exports/

* Restructure transactionS imports/exports

* Restructured wallet imports and exports

* Hoist all necessary selectors aside from config/**/* and transaction/**/*

* Hoist all top-level selectors from transaction

* [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj

* Implement right-click context menu (#1780) @ bryanwb

* No Private Keys Online (#1466) @ wbobeirne

* Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne

* [Fix] Make ENS Value Consistent (#1956) @ skubakdj

* Auto token add (#1808) @ HenryNguyen5

* Electron Ledger + Trezor Support (#1836) @ wbobeirne

* Fix Context Menu Popup Parameters (#1957)

* Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne

* Change displayed notification back in helpers.tsx

* Remove newline on shell files

* Re-add newlines

* Remove newling on .travis.yml

* Prettier two files

* Re-add index.scss import in OnboardModal

* Restructure transaction subdirectories

* Everything in transaction/ except for sagas

* Restructure transaction imports/exports

* Nest broadcast sagas

* Nest fields

* Nest meta

* Nest network

* Nest sign

* Use generic names for reduxy stuff in the same directory to save space

* Do everything every in the whole wide world
2018-06-17 20:53:00 -05:00

466 lines
14 KiB
TypeScript

import BN from 'bn.js';
import cloneDeep from 'lodash/cloneDeep';
import { Wei } from 'libs/units';
import * as helpers from 'features/helpers';
import * as testHelpers from 'features/testHelpers';
import * as derivedSelectors from 'features/selectors';
import { transactionBroadcastSelectors } from './broadcast';
import { transactionFieldsSelectors } from './fields';
import { transactionMetaSelectors } from './meta';
import { transactionNetworkTypes, transactionNetworkSelectors } from './network';
import { transactionSignSelectors } from './sign';
import * as selectors from './selectors';
const initialState = cloneDeep(testHelpers.getInitialState());
describe('helpers selector', () => {
const state = testHelpers.getInitialState();
state.transaction = {
...state.transaction,
meta: {
...state.transaction.meta,
unit: 'ETH'
},
fields: {
to: {
raw: '0x4bbeEB066eD09B7AEd07bF39EEe0460DFa261520',
value: new Buffer([0, 1, 2, 3])
},
data: {
raw: '',
value: null
},
nonce: {
raw: '0',
value: new BN('0')
},
value: {
raw: '1000000000',
value: Wei('1000000000')
},
gasLimit: {
raw: '21000',
value: Wei('21000')
},
gasPrice: {
raw: '1500',
value: Wei('1500')
}
}
};
it('should reduce the fields state to its base values', () => {
const values = {
data: null,
gasLimit: Wei('21000'),
gasPrice: Wei('1500'),
nonce: new BN('0'),
to: new Buffer([0, 1, 2, 3]),
value: Wei('1000000000')
};
expect(helpers.reduceToValues(state.transaction.fields)).toEqual(values);
});
it('should check isFullTransaction with full transaction arguments', () => {
const currentTo = derivedSelectors.getCurrentTo(state);
const currentValue = derivedSelectors.getCurrentValue(state);
const transactionFields = transactionFieldsSelectors.getFields(state);
const unit = derivedSelectors.getUnit(state);
const dataExists = selectors.getDataExists(state);
const validGasCost = derivedSelectors.getValidGasCost(state);
const isFullTransaction = helpers.isFullTx(
state,
transactionFields,
currentTo,
currentValue,
dataExists,
validGasCost,
unit
);
expect(isFullTransaction).toEqual(true);
});
it('should check isFullTransaction without full transaction arguments', () => {
const currentTo = { raw: '', value: null };
const currentValue = derivedSelectors.getCurrentValue(state);
const transactionFields = transactionFieldsSelectors.getFields(state);
const unit = derivedSelectors.getUnit(state);
const dataExists = selectors.getDataExists(state);
const validGasCost = derivedSelectors.getValidGasCost(state);
const isFullTransaction = helpers.isFullTx(
state,
transactionFields,
currentTo,
currentValue,
dataExists,
validGasCost,
unit
);
expect(isFullTransaction).toEqual(false);
});
});
//#region Broadcast
describe('broadcast selector', () => {
const state = testHelpers.getInitialState();
state.transaction = {
...state.transaction,
broadcast: {
...state.transaction.broadcast,
testIndexingHash1: {
broadcastedHash: 'testBroadcastedHash',
broadcastSuccessful: true,
isBroadcasting: false,
serializedTransaction: new Buffer([1, 2, 3])
},
testIndexingHash2: {
broadcastedHash: 'testBroadcastedHash',
broadcastSuccessful: true,
isBroadcasting: false,
serializedTransaction: new Buffer([1, 2, 3])
}
},
sign: {
...state.transaction.sign,
indexingHash: 'testIndexingHash1',
pending: false
}
};
it('should check getTransactionState with an indexing hash', () => {
expect(transactionBroadcastSelectors.getTransactionStatus(state, 'testIndexingHash1')).toEqual(
state.transaction.broadcast.testIndexingHash1
);
});
it('should check getCurrentTransactionStatus', () => {
expect(selectors.getCurrentTransactionStatus(state)).toEqual(
state.transaction.broadcast.testIndexingHash2
);
});
it('should check currentTransactionFailed', () => {
expect(selectors.currentTransactionFailed(state)).toEqual(false);
});
it('should check currentTransactionBroadcasting', () => {
expect(selectors.currentTransactionBroadcasting(state)).toEqual(false);
});
it('should check currentTransactionBroadcasted', () => {
expect(selectors.currentTransactionBroadcasted(state)).toEqual(true);
});
it('should return false on getCurrentTransactionStatus if no index hash present', () => {
state.transaction.sign.indexingHash = null;
expect(selectors.getCurrentTransactionStatus(state)).toEqual(false);
});
});
//#endregion Broadcast
//#region Current
describe('current selector', () => {
const state = testHelpers.getInitialState();
state.transaction = {
...state.transaction,
fields: {
...state.transaction.fields,
to: {
raw: '0x4bbeEB066eD09B7AEd07bF39EEe0460DFa261520',
value: new Buffer([0, 1, 2, 3])
},
gasLimit: {
raw: '21000',
value: Wei('21000')
},
gasPrice: {
raw: '1500',
value: Wei('1500')
}
},
meta: {
...state.transaction.meta,
unit: 'ETH',
previousUnit: 'ETH'
}
};
it('should get stored receiver address on getCurrentTo', () => {
expect(derivedSelectors.getCurrentTo(state)).toEqual(state.transaction.fields.to);
});
it('should get stored value on getCurrentValue', () => {
expect(derivedSelectors.getCurrentValue(state)).toEqual(state.transaction.fields.value);
});
it('should get message to the receiver', () => {
expect(derivedSelectors.getCurrentToAddressMessage(state)).toEqual({
msg: 'Thank you for donating to MyCrypto. TO THE MOON!'
});
});
it('should check isValidGasPrice', () => {
expect(selectors.isValidGasPrice(state)).toEqual(true);
});
it('should check isEtherTransaction', () => {
expect(derivedSelectors.isEtherTransaction(state)).toEqual(true);
});
it('should check isValidGasLimit', () => {
expect(selectors.isValidGasLimit(state)).toEqual(true);
});
it('should check isValidCurrentTo', () => {
expect(derivedSelectors.isValidCurrentTo(state)).toEqual(true);
});
it('should check isCurrentToLabelEntry', () => {
expect(derivedSelectors.isCurrentToLabelEntry(state)).toEqual(false);
const otherState = { ...state };
otherState.transaction = {
...state.transaction,
fields: { ...state.transaction.fields, to: { ...state.transaction.fields.to, raw: 'derp' } }
};
expect(derivedSelectors.isCurrentToLabelEntry(otherState)).toEqual(true);
});
});
//#endregion Current
//#region Fields
describe('fields selector', () => {
const state = testHelpers.getInitialState();
state.transaction.fields = {
to: {
raw: '0x4bbeEB066eD09B7AEd07bF39EEe0460DFa261520',
value: new Buffer([0, 1, 2, 3])
},
data: {
raw: '',
value: null
},
nonce: {
raw: '0',
value: new BN('0')
},
value: {
raw: '1000000000',
value: Wei('1000000000')
},
gasLimit: {
raw: '21000',
value: Wei('21000')
},
gasPrice: {
raw: '1500',
value: Wei('1500')
}
};
it('should get fields from fields store', () => {
expect(transactionFieldsSelectors.getFields(state)).toEqual(state.transaction.fields);
});
it('should get data from fields store', () => {
expect(transactionFieldsSelectors.getData(state)).toEqual(state.transaction.fields.data);
});
it('should get gas limit from fields store', () => {
expect(transactionFieldsSelectors.getGasLimit(state)).toEqual(
state.transaction.fields.gasLimit
);
});
it('should get value from fields store', () => {
expect(transactionFieldsSelectors.getValue(state)).toEqual(state.transaction.fields.value);
});
it('sould get receiver address from fields store', () => {
expect(transactionFieldsSelectors.getTo(state)).toEqual(state.transaction.fields.to);
});
it('should get nonce from fields store', () => {
expect(transactionFieldsSelectors.getNonce(state)).toEqual(state.transaction.fields.nonce);
});
it('should get gas price from fields store', () => {
expect(transactionFieldsSelectors.getGasPrice(state)).toEqual(
state.transaction.fields.gasPrice
);
});
it('should check getDataExists', () => {
expect(selectors.getDataExists(state)).toEqual(false);
});
it('should check when gas cost is valid', () => {
expect(derivedSelectors.getValidGasCost(state)).toEqual(true);
});
it('should check when gas cost is invalid', () => {
state.wallet.balance = {
wei: Wei('0'),
isPending: false
};
expect(derivedSelectors.getValidGasCost(state)).toEqual(false);
});
});
//#endregion Fields
//#region Meta
describe('meta tests', () => {
const state = { ...initialState };
(state.transaction.meta = {
unit: 'ETH',
previousUnit: 'ETH',
decimal: 18,
tokenValue: {
raw: '',
value: null
},
tokenTo: {
raw: '',
value: null
},
from: 'fromAddress',
isContractInteraction: false
}),
(state.customTokens = [
{
address: '0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7',
symbol: 'UNI',
decimal: 0
}
]);
it('should get the stored sender address', () => {
expect(derivedSelectors.getFrom(state)).toEqual(state.transaction.meta.from);
});
it('should get the stored decimal', () => {
expect(transactionMetaSelectors.getDecimal(state)).toEqual(state.transaction.meta.decimal);
});
it('should get the token value', () => {
expect(transactionMetaSelectors.getTokenValue(state)).toEqual(
state.transaction.meta.tokenValue
);
});
it('should get the token receiver address', () => {
expect(transactionMetaSelectors.getTokenTo(state)).toEqual(state.transaction.meta.tokenTo);
});
it('should get the stored unit', () => {
expect(derivedSelectors.getUnit(state)).toEqual(state.transaction.meta.unit);
});
it('should get the stored previous unit', () => {
expect(selectors.getPreviousUnit(state)).toEqual(state.transaction.meta.previousUnit);
});
it('should get the decimal for ether', () => {
expect(derivedSelectors.getDecimalFromUnit(state, derivedSelectors.getUnit(state))).toEqual(18);
});
it('should get the decimal for a token', () => {
expect(derivedSelectors.getDecimalFromUnit(state, 'UNI')).toEqual(0);
});
it('should throw error if the token is not found', () => {
expect(() => derivedSelectors.getDecimalFromUnit(state, 'ABC')).toThrowError(
`Token ABC not found`
);
});
});
//#endregion Meta
//#region Network
describe('network selector', () => {
const state = testHelpers.getInitialState();
state.transaction.network = {
...state.transaction.network,
gasEstimationStatus: transactionNetworkTypes.RequestStatus.REQUESTED,
getFromStatus: transactionNetworkTypes.RequestStatus.SUCCEEDED,
getNonceStatus: transactionNetworkTypes.RequestStatus.REQUESTED,
gasPriceStatus: transactionNetworkTypes.RequestStatus.SUCCEEDED
};
it('should get network status', () => {
expect(transactionNetworkSelectors.getNetworkStatus(state)).toEqual(state.transaction.network);
});
it('should check with the store if the nonce request is pending', () => {
expect(transactionNetworkSelectors.nonceRequestPending(state)).toEqual(true);
});
it('should check with the store if the nonce request failed', () => {
state.transaction.network.getNonceStatus = transactionNetworkTypes.RequestStatus.FAILED;
expect(transactionNetworkSelectors.nonceRequestFailed(state)).toEqual(true);
});
it('should check with the store if the gas estimation is pending', () => {
expect(transactionNetworkSelectors.getGasEstimationPending(state)).toEqual(true);
});
it('should check with the store if gas limit estimation timed out', () => {
state.transaction.network.gasEstimationStatus = transactionNetworkTypes.RequestStatus.TIMEDOUT;
expect(transactionNetworkSelectors.getGasLimitEstimationTimedOut(state)).toEqual(true);
});
it('should check with the store if network request is pending', () => {
state.transaction.network.gasEstimationStatus = transactionNetworkTypes.RequestStatus.REQUESTED;
expect(transactionNetworkSelectors.isNetworkRequestPending(state)).toEqual(true);
});
});
//#endregion Network
//#region Sign
describe('sign tests', () => {
const state = testHelpers.getInitialState();
(state.transaction.sign = {
indexingHash: 'testIndexingHash',
pending: false,
local: {
signedTransaction: new Buffer([4, 5, 6, 7])
},
web3: {
transaction: null
}
}),
it('should return whether the current signature is pending', () => {
expect(derivedSelectors.signaturePending(state)).toEqual({
isHardwareWallet: false,
isSignaturePending: false
});
});
it('should should get the stored sign state', () => {
expect(transactionSignSelectors.getSignState(state)).toEqual(state.transaction.sign);
});
it('should get the signed local transaction state', () => {
expect(transactionSignSelectors.getSignedTx(state)).toEqual(
state.transaction.sign.local.signedTransaction
);
});
it('should get the signed web3 transaction state', () => {
expect(transactionSignSelectors.getWeb3Tx(state)).toEqual(
state.transaction.sign.web3.transaction
);
});
it('should get the serialized transaction state', () => {
expect(derivedSelectors.getSerializedTransaction(state)).toEqual(new Buffer([4, 5, 6, 7]));
});
});
//#endregion Sign