MyCrypto/common/features/transaction/helpers.spec.tsx
Connor Bryan e761b9d1fb Refactor redux pattern from top-level to ducks (#1936)
* Add a new route for AddressBook

* Further templating of the AddressBook view

* Add initial functionality to handle a table of existing address labels

* Make the linter happy

* Adjust paths

* Factor out TableRow and add common functionality

* Add initial Redux boilerplate for addressBook | fix minor linting issues

* Swap out terminology and types

* Connect up to Redux

* Connect data for AddressBookTable to Redux

* Use temporary fields for addition

* Remove alignment and index column

* Stopping point

* Adjust the sizing of rows to be consistent

* Initial implementation of a dropdown for the address field

* Minor styling to dropdown

* Stopping point

* Apply a focus concept onto the factory

* Add keyboard controls for the address field dropdown

* Adjust label of address field when it matches an addressBook entry

* Properly handle attempting to blur a non-existent component

* Minor styling changes on dropdown box

* Standardize address casing, add accessibility to dropdown

* Create an addressLabel component

* Pass refs correctly and fix some typings

* Exact version

* Add module name mapping for shared/keycodes

* addressBook reducer tests

* Add functionality to DeterministicModal

* Minor changes / Add test for addressBook selectors

* Move out AddressBookTable to a component

* Typing, translation and restructuring

* More typing and translation fixes

* More linting fixes

* More type changes

* Variable name for dropdown background

* Fix TS type errors, lint errors, remove unused props

* Used a different selector and removed method: AddressBookTable

* Linter was mad

* Linter mad again :(

* Add a translation and adjust styling of AddressBookTable

* Move the onBlur to a class method

* Prevent the default behavior of up/down/enter for dropdown

* Let's do it this way instead

* Adjust the styling on DeterministicWalletModal labels

* Change `AddressBookTable` into a pseudo-table using section and div

* Use readable keys vs. keycodes

* Put the dropdown in InputFactory and position it correctly

* Sanitation of label adding and changing

* Prevent duplicate labels in AddressBook and Row

* Add a box shadow and use `invalid` class insted of custom

* Use emphasis vs strong for address in dropdown

* Display the label undernearth the input vs. changing it

* Isolate AccountAddress into its own component

* Introduce interactivity to AccountAddress

* Fully incorporate with Redux

* Validation for AccountAddress

* Add validation notifications for address field on AddressBookTable

* Minor formatting

* Adjust wrappage for optimal flexboxxing

* Make AddressBookTable responsive

* Show an invalid input in "real time" instead of only on submit

* Real time input validation for AddressBookTableRow

* Responsive-ize the To address dropdown

* Hide identicons instead at small enough screen sizes

* Fix repsonsiveness of dropdown further

* Fix responsiveness of table rows and inputs

* Truncate account info and switch identicons to the right for consistency

* Use classnames instead of targetting element directly for DWM

* Display a notice if the entered query doesnt match a label and isnt an addr

* Don't show an error on the To address if its a label entry

* Display an error under AddressBookTableRow in real time

* Display errors in real time for AddressBookTable temp inputs

* Add realtime validation to AccountAddress

* Ensure toChecksumAddress is used when entering labels to address manager

* Show errors even after blurring.

* Create a ducks/ implementation for addressBook

* Duck-ize notifications

* Duck-ize customTokens

* Duck-ize deterministicWallets

* Only show errors on address/label entry if they have been blurred

* On certain inputs, show an invalid input immediately

* spec files in same directory

* Rename top-level redux directory

* Duck-ize gas

* Add displayed errors for labels with 0x and labels containing ens

* Move ENS checking validation out

* Add a saga for addLabelForAddress

* Completely revamp the redux side of Address Manager and test it all

* Adjust components to use new redux addressBook

* Incorporate new redux into AddressBookTableRow and clean up for linter

* Make linter and tests happy

* Another reduxy overhaul

* Still fixing it

* More redux updates

* Finalize redux stuff.

* Incorporate new reduxy way into AddressBookTable & Row

* Incorporate redux changes into Account Address

* Small tests fix

* Add and fix some selector tests

* Addressing Will's comments

* Shortened visibility class for line length reasons.

* Incorporate ducks pattern on updates addressBook

* Fix typeerror

* Migrate messages to ducks

* For Henry

* Duckify onboardStatus

* Duckify paritySigner

* Duckify rates

* Duckify transactions

* Duckerize wallet

* Reduckerate config

* Adjust exports and tests of every duck so far

* Duckify ENS

* Duckerificate schedule

* Duckificate swap

* Actually use the new sagas;  fix a circular dependency problem.

* Duckify transaction (phew)

* Add basics to redux/ directory

* Remove non-ducked redux stuff

* First sweep of redux/ directory

* Combine redundant imports

* Fix more linting stuff.

* A few more type fixes

* Welp... now I know not to use index.

* Sweep components/

* Sweep through containers/

* Im really starting to get frustrated

* The dawn of a new age.

* Linter fixes.

* De-flatten config/ reducers

* Do my thang on config selectors

* Adjust all references to config

* Split up ens reducers

* Wrap up de-nesting ENS

* Big boy refactor

* Split transaction into its reducers

* Fix reducers in transaction/

* Stopping point

* Adjust references to transaction from components

* Fix references to selectors

* Nest broadcast actions

* Nest field actions

* Nest meta actions

* Nest network actions

* Nest sign actions

* Nest broadcast types

* Nested fields types

* Nest meta types

* Nested network types

* Nested sign types

* Implement transaction saga changes

* Huh? No prepush problems?

* Update snappshot

* Reintroduce deleted tests

* A few missing tests found

* Found three missing transaction tests

* Found more tests

* Found the rest of the tests, woohoo.

* Renamed TypeKeys in TRANSACTION

* Specify TRANSACTION_BROADCAST

* Pretty up these imports

* Specify TRANSACTION_FIELDS

* Specify TRANSACTION_META

* Specify TRANSACTION_NETWORK

* Specify TRANSACTION_SIGN

* Adjust imports and add translations

* Update config snapshot

* Post-merge

* Temporary fix for DW/Config sagas so Daniel can continue smoke testing

* Remove first circulat dependency

* Fix more circular dependencies

* Properly structure config indices

* Further restructure config

* Prepare for idea

* Target directly from within features/

* Remove that circular dependency -- woohoo

* Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance

* Un-comment the component-in-redux phenomenon

* Move onLoad to the store file

* Adjust addressBook imports/exports

* Adjusted imports/exports for customTokens

* Adjust imports/exports of deterministicWallets

* Adjust imports/exports of ens

* Restructure imports/exports of gas

* Restructure imports/exports for message

* Adjust imports/exports of notifications

* Restructure onboardStatus imports/exports

* Restructure paritySigner imports/exports

* Restructure rates imports/exports

* Restructure schedule imports/exports

* Fix broadcastweb3handler test

* Restructure swap imports/exports/

* Restructure transactionS imports/exports

* Restructured wallet imports and exports

* Hoist all necessary selectors aside from config/**/* and transaction/**/*

* Hoist all top-level selectors from transaction

* [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj

* Implement right-click context menu (#1780) @ bryanwb

* No Private Keys Online (#1466) @ wbobeirne

* Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne

* [Fix] Make ENS Value Consistent (#1956) @ skubakdj

* Auto token add (#1808) @ HenryNguyen5

* Electron Ledger + Trezor Support (#1836) @ wbobeirne

* Fix Context Menu Popup Parameters (#1957)

* Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne

* Change displayed notification back in helpers.tsx

* Remove newline on shell files

* Re-add newlines

* Remove newling on .travis.yml

* Prettier two files

* Re-add index.scss import in OnboardModal

* Restructure transaction subdirectories

* Everything in transaction/ except for sagas

* Restructure transaction imports/exports

* Nest broadcast sagas

* Nest fields

* Nest meta

* Nest network

* Nest sign

* Use generic names for reduxy stuff in the same directory to save space

* Do everything every in the whole wide world
2018-06-17 20:53:00 -05:00

329 lines
10 KiB
TypeScript

import { SagaIterator } from 'redux-saga';
import { select, call, put, take } from 'redux-saga/effects';
import { cloneableGenerator } from 'redux-saga/utils';
import { makeTransaction } from 'libs/transaction';
import { toTokenBase, Wei } from 'libs/units';
import configuredStore from 'features/store';
import * as derivedSelectors from 'features/selectors';
import { getOffline } from 'features/config/meta/selectors';
import { getNetworkConfig, isNetworkUnit } from 'features/config/selectors';
import { walletSelectors } from 'features/wallet';
import { notificationsActions } from 'features/notifications';
import { transactionFieldsSelectors } from './fields';
import { transactionNetworkTypes, transactionNetworkActions } from './network';
import { transactionSignActions, transactionSignSagas } from './sign';
import * as helpers from './helpers';
configuredStore.getState();
describe('transaction: Helpers', () => {
describe('Signing', () => {
describe('signTransactionWrapper*', () => {
const partialTx: any = {
payload: 'payload'
};
const IWalletAndTx: any = {
wallet: 'wallet'
};
const err = new Error('Error');
const func = jest.fn();
const gens: any = {};
gens.gen = cloneableGenerator(transactionSignSagas.signTransactionWrapper(func))(partialTx);
it('should call getWalletAndTransAction', () => {
expect(gens.gen.next().value).toEqual(
call(transactionSignSagas.getWalletAndTransaction, partialTx.payload)
);
});
it('should call getFrom', () => {
gens.clone = gens.gen.clone();
expect(gens.gen.next(IWalletAndTx).value).toEqual(call(transactionSignSagas.getFromSaga));
});
it('should call func with IWalletAndTx', () => {
expect(gens.gen.next().value).toEqual(call(func, IWalletAndTx));
});
it('should handle errors', () => {
expect(gens.clone.throw(err).value).toEqual(
call(transactionSignSagas.handleFailedTransaction, err)
);
});
it('should be done', () => {
expect(gens.gen.next().done).toEqual(true);
});
});
describe('getWalletAndTransaction*', () => {
const partialTx: any = {
gasPrice: 'gasPrice',
_chainId: '_chainId'
};
const wallet = {
data2: 'data2'
};
const networkConfig = {
chainId: 'chainId'
};
const gens: any = {};
gens.gen = cloneableGenerator(transactionSignSagas.getWalletAndTransaction)(partialTx);
it('should select getWalletInst', () => {
expect(gens.gen.next().value).toEqual(select(walletSelectors.getWalletInst));
});
it('should error on no wallet', () => {
gens.clone = gens.gen.clone();
expect(() => gens.clone.next()).toThrow();
});
it('should select getNetworkConfig', () => {
expect(gens.gen.next(wallet).value).toEqual(select(getNetworkConfig));
});
it('should return expected', () => {
expect(gens.gen.next(networkConfig).value).toEqual({
wallet,
tx: partialTx
});
});
it('should be done', () => {
expect(gens.gen.next().done).toEqual(true);
});
});
describe('handleFailedTransaction*', () => {
const err = new Error('Message');
const gen = transactionSignSagas.handleFailedTransaction(err);
let random: () => number;
beforeAll(() => {
random = Math.random;
Math.random = () => 0.001;
});
afterAll(() => {
Math.random = random;
});
it('should put showNotification', () => {
expect(gen.next().value).toEqual(
put(notificationsActions.showNotification('danger', err.message, 5000))
);
});
it('should put signTransactionFailed', () => {
expect(gen.next().value).toEqual(put(transactionSignActions.signTransactionFailed()));
});
});
describe('getFrom*', () => {
const getFromSucceeded = {
type: transactionNetworkTypes.TransactionNetworkActions.GET_FROM_SUCCEEDED
};
const getFromFailed = {
type: transactionNetworkTypes.TransactionNetworkActions.GET_FROM_FAILED
};
const gens: any = {};
gens.gen = cloneableGenerator(transactionSignSagas.getFromSaga)();
it('should put getFromRequested', () => {
expect(gens.gen.next().value).toEqual(put(transactionNetworkActions.getFromRequested()));
});
it('should take GET_FROM*', () => {
expect(gens.gen.next().value).toEqual(
take([
transactionNetworkTypes.TransactionNetworkActions.GET_FROM_SUCCEEDED,
transactionNetworkTypes.TransactionNetworkActions.GET_FROM_FAILED
])
);
});
it('should throw error if failed', () => {
gens.clone = gens.gen.clone();
expect(() => gens.clone.next(getFromFailed)).toThrow();
});
it('should return if success', () => {
expect(gens.gen.next(getFromSucceeded).done).toEqual(true);
});
});
});
describe('Validation', () => {
const itShouldBeDone = (gen: SagaIterator) => {
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
};
describe('rebaseUserInput*', () => {
const validNumberValue = {
raw: '1',
value: Wei('1')
};
const notValidNumberValue: any = {
raw: '-1',
value: '-1'
};
const unit = 'unit';
const newDecimal = 1;
const prevDecimal = 1;
const gens: any = {};
gens.gen1 = helpers.rebaseUserInput(validNumberValue);
gens.gen2 = helpers.rebaseUserInput(notValidNumberValue);
describe('when a valid number', () => {
it('should select getUnit', () => {
expect(gens.gen1.next().value).toEqual(select(derivedSelectors.getUnit));
});
it('should select getDecimalFromUnit with unit', () => {
expect(gens.gen1.next(unit).value).toEqual(
select(derivedSelectors.getDecimalFromUnit, unit)
);
});
it('should return correctly', () => {
expect(gens.gen1.next(newDecimal).value).toEqual({
raw: validNumberValue.raw,
value: toTokenBase(validNumberValue.raw, newDecimal)
});
});
itShouldBeDone(gens.gen1);
});
describe('when not a valid number', () => {
it('should select getUnit', () => {
expect(gens.gen2.next().value).toEqual(select(derivedSelectors.getUnit));
});
it('should select getDecimalFromUnit with unit', () => {
expect(gens.gen2.next(unit).value).toEqual(
select(derivedSelectors.getDecimalFromUnit, unit)
);
});
it('should return correctly', () => {
const result = JSON.stringify(gens.gen2.next(prevDecimal).value);
const expected = JSON.stringify({
raw: notValidNumberValue.raw,
value: null
});
expect(result).toEqual(expected);
});
itShouldBeDone(gens.gen2);
});
});
describe('validateInput*', () => {
const input: any = 'input';
const unit = 'unit';
const etherBalance = Wei('1000');
const etherTransaction = true;
const validationTx = {
gasLimit: Wei('30'),
gasPrice: Wei('1'),
value: Wei('10')
};
const gens: any = {};
gens.gen = cloneableGenerator(helpers.validateInput)(input, unit);
it('should return when !input', () => {
expect(helpers.validateInput(null, '').next().done).toEqual(true);
});
it('should select getEtherBalance', () => {
gens.clone2 = gens.gen.clone();
expect(gens.gen.next().value).toEqual(select(walletSelectors.getEtherBalance));
});
it('should select getOffline', () => {
gens.clone2 = gens.gen.clone();
expect(gens.gen.next(etherBalance).value).toEqual(select(getOffline));
gens.clone1 = gens.gen.clone();
});
it('should call isNetworkUnit', () => {
expect(gens.gen.next(false).value).toEqual(select(isNetworkUnit, unit));
gens.clone3 = gens.gen.clone();
});
it('should return true when offline', () => {
expect(gens.clone1.next(true).value).toEqual(select(isNetworkUnit, unit));
expect(gens.clone1.next().done).toEqual(true);
});
it('should return when !etherBalance', () => {
expect(gens.clone2.next(null).value).toEqual(select(getOffline));
expect(gens.clone2.next(true).value).toEqual(select(isNetworkUnit, unit));
expect(gens.clone2.next().done).toEqual(true);
});
it('should call makeCostCalculationTx', () => {
expect(gens.gen.next(etherTransaction).value).toEqual(
call(helpers.makeCostCalculationTx, input)
);
});
it('should return true if etherTransaction', () => {
expect(gens.gen.next(validationTx).value).toEqual(true);
});
it('should select getTokenBalance if !etherTransaction', () => {
gens.clone3.next(!etherTransaction);
expect(gens.clone3.next(validationTx).value).toEqual(
select(derivedSelectors.getTokenBalance, unit)
);
});
it('should return true if !etherTransaction', () => {
expect(gens.clone3.next().value).toEqual(true);
});
});
describe('makeCostCalculationTx*', () => {
const value = Wei('100');
const gasLimit = {
value: Wei('10')
};
const gasPrice = {
value: Wei('1')
};
const txObj = {
gasLimit: gasLimit.value,
gasPrice: gasPrice.value,
value
};
const gen = helpers.makeCostCalculationTx(value);
it('should select getGasLimit', () => {
expect(gen.next().value).toEqual(select(transactionFieldsSelectors.getGasLimit));
});
it('should select getGasPrice', () => {
expect(gen.next(gasLimit).value).toEqual(select(transactionFieldsSelectors.getGasPrice));
});
it('should call makeTransaction', () => {
expect(gen.next(gasPrice).value).toEqual(call(makeTransaction, txObj));
});
itShouldBeDone(gen);
});
});
});