MyCrypto/spec/sagas/wallet.spec.tsx
HenryNguyen5 08d4ccbdae Productionize Transaction Stack (#456)
* export conditional input and hoc

* Move typings and fields out of send transaction

* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components

* Handle hex and non hex strings automatically in BN conversion

* Fix handling of strings and numbers for BN

* add web3 fixes & comments

* Display short balances on deterministic modals

* add more tests, fix rounding

* Add spacer to balance sidebar network name

* Fix tsc error

* Add offline render CB

* Make more render callbacks

* Transform NonceField into its self contained component

* Remove styling from nonce field

* Better network handling in nonce cb

* Move network nonce initialization to componentDidMount

* Remove unessesary conditional input

* Make nonce component return a BN

* Simplify Query render cb

* Add gas query and token query render cbs

* Re-write address field component, strip out ENS name functionality for now

* Add address and data as unit types

* Cleanup Address Field component

* Export gas query

* Re-write gas field component

* Cleanup gas estimation check

* Re-write Data field

* Transaction field skeleton

* Export transaction field actions

* Rename fields to map to ethtx fields

* Make reducers for fields

* Fix reducer module exports

* Export reducer

* Formatting fix

* Type return of GasQuery

* Add transaction field getter / setter component

* Make transaction fields more flexible

* Formatting fix

* Split transaction fields component into two

* Remove erroneous prop

* Fix field naming to follow ethereum transaction fields

* Merge valid prop into componeent

* Change address field to be redux based

* Convert nonce field to redux based

* Make component for passing in current transaction

* Re-write Gas component to use redux state

* Reduxify data field component

* seperate transaction fields redux state into field data and meta data

* Rename SetTransactionFields to be singular

* Make render callback components for getting/setting meta fields

* Add non-zero option prop for token balance render cb

* re-write unit dropdown component to be redux based

* Make ether the first option

* Fix tsc error on tokenquery

* Handle query string default values in unit drop down

* Add thunks to package

* Add helper function for encoding transfer data

* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based

* Fix wrong typing

* Add token metafield as export

* Start scaffolding out amount field component

* Make render cbs for conditional selection of value and balance

* Make render callbacks nullable

* Progress commit -- get dynaming swapping between tokens and ether working

* Get gas estimation working between ether and tokens

* Remove nonce from breaking gas estimation

* Add better validation for amount field

* Add 500ms debounce to gas saga

* Self contain custom message component

* Add web3 awareness to wallet render cb

* Add render cb for checking if  wallet is unlocked

* Cleanup inline typing

* export available params

* Add render cb to render component when a query string exists

* Add boolean callback param that check that the transaction is filled by user

* Remove uneeded typings from send transaction

* Fix misnomer

* Self contain generate transaction button

* Compartmentalize more send transaction components

* Add query string warning, custom message and generate tx button to fields

* Cleanup send tx component with new components

* export render callbacks

* saga transaction scaffolding

* make gas saga fully declarative

* transaction lib renaming

* Seperate gasprice into its own generator

* Make action creators for tx sign actions

* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx

* Add TransactionComparison component

* Add pushTx

* Progress commit --  Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications

* Get local transaction broadcasting working

* re-write confirmation modal to be redux based

* Fix spacing and import

* Move confirmation modal to be attached to send button, create send button

* Properly handle broadcasting for conf modal

* Handle gas cost > balance for send everything

* Add signing status as its own component (#454)

* Fix ledger errors not showing on notifs

* Make dedicated actions for swapping from tokens to ether and ether to tokens

* Split actionTypes file

* Cleanup comments

* Cleanup comments

* Fix various tsc errors

* Lay down infrastructure for saving configurations per-wallet.

* Add pending and rejected states properly to token values.

* Add custom token form improvements.

* Fix metamask transaction errors

* Fix send entire balance estimation

* Fix add token form from never being enabled.

* Initial pass at account tab with send and view wallet tabs.

* Fix inactive tab.

* Hide private key, toggling

* Progress commit -- Replacing render callbacks with selectors, put  validation logic in sagas

* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.

* Fix navigation link active

* Force read only wallets to info tab.

* Remove commented code

* Saga-ify send everything

* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.

* Add custom token to current wallets tracked tokens.

* Rework remove token icon.

* Adjust button margin

* Remove the rest of the needless render callbacks for selectors, sagaify nonce

* Bug fix send transaction

* remove unused redux-thunk

* Move fields to general components

* Clean up saga structure

* Refactor broadcast tx

* Implement better validation logic, get contract deploy working

* PR feedback.

* Convert tokenbalances component to connected redux component.

* Addressed feedback from Henry.

* Progress commit -- Implement Interact logic, needs manual testing

* Get rid of commented code

* move exports after declarations

* add tests, rough draft

* Get contract method calls working

* Bugfix contracts

* Cleanup hex prefixing

* Reset transaction state on wallet change

* Get rid of old send transaction component

* Disable sign transaction button when network request is underway

* Flatten send button tree, make nonce human readable in confirmation modal

* Add ghetto cost breakdown component, fix token field validation

* Create Generic SubTab and use in Send

* MVP of mnemonics with sub-tabs in Create Wallet view.

* Do dynamic revalidation

* move exports after declarations

* add forgotten signing tests

* update token spec

* update currentValue spec

* update validationHelpers spec

* Address TODO - use injected history to push navigation state instead of hardcoding window.location

* Use SubTabs in Contracts

* Fix revertPath prop for AcceptOrRedirectModal

* Use subtabs in SignAndVerifyMessage

* Routing for subtabs

* Fix routes, adjust sizing.

* Remove unused import

* Request nonce in base 10

* Add offline override to unit display

* Make cost breakdown less buggy

* Add non standard transaction warning

* Fix amount validity

* Cleanup datafield validity

* Display notif on gas estimation failure

* Add post-signing verification against fields, clean up gas price

* Fix tsc errors

* Code cleanup

* add exports to functions

* add specs for sendEverything and reset sagas

* delete duplicate files

* make tslint happy

* Merge develop

* Fix develop regressions

* Delegate nonce pulling  to wallet being set

* Clarify non standard transaction

* Make address a buffer to avoid leading 0's bug

* Clarify validation helper comment

* Increase debounce time, add console error

* Better validation for non-standard transactions

* Add verification skipping for broadcasting txs

* Fix state and wallet resetting for contract tabs

* Fix some spec files, remove contract.spec

* Remove broadcasting specs from wallet

* Close DeterministicWalletModal on confirm

* Revert "Close DeterministicWalletModal on confirm"

This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.

* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.

* Fix client side broadcast checking

* Add more state resetters in error scenarios

* Fix gas estimation

* Add validation for value transactions to contract creation

* Add transaction comparaision differentiation depending on wallet type

* Fix token row display balance showing twice

* Properly handle failed transactions

* Handle bad error messages

* fix broken tests

* fix broken test

* Progress commit -- Implement generic subtab types

* Remove react router v3

* Remove unused routes

* Clean up Tabbing code, add onTabChange handler

* Fix tests

* Add nav fix

* revert opinionated sub-tab implementation

* additional reverts

* Add decimal validation

* Make gas price single source of truth, dont save any transaction state other than gas price

* Get rid of old wallet.spec reducer tests

* Add decimal validation when re-validating gasCost

* remove utilities view

* Remove cost breakdown

* Remove local gas estimation warning

* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values

* Convert reducers to switch case

* Clean tsc errors

* Fix failing test

* fix tscheck error

* Add number validation to gas field

* Fix misaligned input dropdown

* Revert "Fix misaligned input dropdown"

This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.

* Set window timeout long enough for node switch to be persisted to state

* Transaction Refactor Style Fixes (#615)

* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.

* Fix modal amount and gas text.

* Fix misaligned dropdown

* Update conditions for NavLink is-active class
2017-12-18 15:23:31 -06:00

321 lines
8.9 KiB
TypeScript

import { configuredStore } from 'store';
import RpcNode from 'libs/nodes/rpc';
import {
setBalanceFullfilled,
setBalancePending,
unlockPrivateKey as unlockPrivateKeyActionGen,
unlockKeystore as unlockKeystoreActionGen,
unlockMnemonic as unlockMnemonicActionGen,
setTokenBalancesFulfilled,
setTokenBalancesPending,
setTokenBalancesRejected
} from 'actions/wallet';
import { Wei } from 'libs/units';
import { changeNodeIntent, web3UnsetNode } from 'actions/config';
import { INode } from 'libs/nodes/INode';
import { initWeb3Node, Token, N_FACTOR } from 'config/data';
import { apply, call, fork, put, select, take } from 'redux-saga/effects';
import { getNodeLib } from 'selectors/config';
import { getWalletInst, getWalletConfigTokens } from 'selectors/wallet';
import {
updateAccountBalance,
updateTokenBalances,
updateBalances,
unlockPrivateKey,
unlockKeystore,
unlockMnemonic,
unlockWeb3,
getTokenBalances
} from 'sagas/wallet';
import { PrivKeyWallet } from 'libs/wallet/non-deterministic';
import { TypeKeys as ConfigTypeKeys } from 'actions/config/constants';
import Web3Node from 'libs/nodes/web3';
import { cloneableGenerator } from 'redux-saga/utils';
import { showNotification } from 'actions/notifications';
import translate from 'translations';
// init module
configuredStore.getState();
const pkey = '31e97f395cabc6faa37d8a9d6bb185187c35704e7b976c7a110e2f0eab37c344';
const wallet = PrivKeyWallet(Buffer.from(pkey, 'hex'));
const address = '0xe2EdC95134bbD88443bc6D55b809F7d0C2f0C854';
const balance = Wei('100');
const node: INode = new RpcNode('');
const token1: Token = {
address: '0x2',
symbol: 'OMG',
decimal: 16
};
const token2: Token = {
address: '0x3',
symbol: 'BAT',
decimal: 16
};
const tokens = [token1, token2];
const utcKeystore = {
version: 3,
id: 'cb788af4-993d-43ad-851b-0d2031e52c61',
address: '25a24679f35e447f778cf54a3823facf39904a63',
Crypto: {
ciphertext: '4193915c560835d00b2b9ff5dd20f3e13793b2a3ca8a97df649286063f27f707',
cipherparams: {
iv: 'dccb8c009b11d1c6226ba19b557dce4c'
},
cipher: 'aes-128-ctr',
kdf: 'scrypt',
kdfparams: {
dklen: 32,
salt: '037a53e520f2d00fb70f02f39b31b77374de9e0e1d35fd7cbe9c8a8b21d6b0ab',
n: N_FACTOR,
r: 8,
p: 1
},
mac: '774fbe4bf35e7e28df15cd6c3546e74ce6608e9ab68a88d50227858a3b05769a'
}
};
// necessary so we can later inject a mocked web3 to the window
describe('updateAccountBalance*', () => {
const gen1 = updateAccountBalance();
const gen2 = updateAccountBalance();
it('should put setBalancePending', () => {
expect(gen1.next().value).toEqual(put(setBalancePending()));
});
it('should select getWalletInst', () => {
expect(gen1.next().value).toEqual(select(getWalletInst));
});
it('should return if wallet is falsey', () => {
gen2.next();
gen2.next();
gen2.next(null);
expect(gen2.next().done).toBe(true);
});
it('should select getNodeLib', () => {
expect(gen1.next(wallet).value).toEqual(select(getNodeLib));
});
it('should apply wallet.getAddressString', () => {
expect(gen1.next(node).value).toEqual(apply(wallet, wallet.getAddressString));
});
it('should apply node.getBalance', () => {
expect(gen1.next(address).value).toEqual(apply(node, node.getBalance, [address]));
});
it('should put setBalanceFulfilled', () => {
expect(gen1.next(balance).value).toEqual(put(setBalanceFullfilled(balance)));
});
it('should be done', () => {
expect(gen1.next().done).toEqual(true);
});
});
describe('updateTokenBalances*', () => {
const gen1 = cloneableGenerator(updateTokenBalances)();
const gen2 = updateTokenBalances();
const gen3 = updateTokenBalances();
it('should select getWalletInst', () => {
expect(gen1.next().value).toEqual(select(getWalletInst));
});
it('should select getWalletConfigTokens', () => {
expect(gen1.next(wallet).value).toEqual(select(getWalletConfigTokens));
});
it('should return if wallet is falsey', () => {
gen2.next();
gen2.next(null);
expect(gen2.next().done).toEqual(true);
});
it('should return if tokens are falsey', () => {
gen3.next();
gen3.next(wallet);
expect(gen3.next({}).done).toEqual(true);
});
it('should put setTokenBalancesPending', () => {
expect(gen1.next(tokens).value).toEqual(put(setTokenBalancesPending()));
});
it('should throw and put setTokenBalancesRejected', () => {
const gen4 = gen1.clone();
if (gen4.throw) {
expect(gen4.throw().value).toEqual(put(setTokenBalancesRejected()));
}
});
it('should call getTokenBalances', () => {
expect(gen1.next().value).toEqual(call(getTokenBalances, wallet, tokens));
});
it('should put setTokenBalancesFufilled', () => {
expect(gen1.next({}).value).toEqual(put(setTokenBalancesFulfilled({})));
});
it('should be done', () => {
expect(gen1.next().done).toEqual(true);
});
});
describe('updateBalances*', () => {
const gen = updateBalances();
it('should fork updateAccountBalance', () => {
expect(gen.next().value).toEqual(fork(updateAccountBalance));
});
it('should fork updateTokenBalances', () => {
expect(gen.next().value).toEqual(fork(updateTokenBalances));
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
});
describe('unlockPrivateKey', () => {
const value = {
key: pkey,
password: ''
};
const action = unlockPrivateKeyActionGen(value);
const gen = unlockPrivateKey(action);
it('should match put setWallet snapshot', () => {
expect(gen.next().value).toMatchSnapshot();
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
});
describe('unlockKeystore*', () => {
const action = unlockKeystoreActionGen({
file: JSON.stringify(utcKeystore),
password: 'testtesttest'
});
const gen = unlockKeystore(action);
it('should match put setWallet snapshot', () => {
expect(gen.next().value).toMatchSnapshot();
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
});
describe('unlockMnemonic*', () => {
const action = unlockMnemonicActionGen({
phrase: 'first catalog away faculty jelly now life kingdom pigeon raise gain accident',
pass: '',
path: "m/44'/60'/0'/0/8",
address: '0xe2EdC95134bbD88443bc6D55b809F7d0C2f0C854'
});
const gen = unlockMnemonic(action);
it('should match put setWallet snapshot', () => {
expect(gen.next().value).toMatchSnapshot();
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
});
describe('unlockWeb3*', () => {
const G = global as any;
const data = {} as any;
data.gen = cloneableGenerator(unlockWeb3)();
const accounts = [address];
const { random } = Math;
let nodeLib;
function sendAsync(options, cb) {
const resp = {
id: 'id'
};
switch (options.method) {
case 'net_version':
return cb(null, { ...resp, result: '1' });
case 'eth_accounts':
return cb(null, { ...resp, result: JSON.stringify(accounts) });
}
}
beforeAll(async done => {
G.web3 = {
currentProvider: {
sendAsync
}
};
nodeLib = new Web3Node();
Math.random = () => 0.001;
await initWeb3Node();
done();
});
afterAll(() => {
Math.random = random;
delete G.web3;
});
it('should call initWeb3Node', () => {
expect(data.gen.next().value).toEqual(call(initWeb3Node));
});
it('should put changeNodeIntent', () => {
expect(data.gen.next(accounts).value).toEqual(put(changeNodeIntent('web3')));
});
it('should yield take on node change', () => {
const expected = take(
action =>
action.type === ConfigTypeKeys.CONFIG_NODE_CHANGE && action.payload.nodeSelection === 'web3'
);
const result = data.gen.next().value;
expect(JSON.stringify(expected)).toEqual(JSON.stringify(result));
});
it('should select getNodeLib', () => {
expect(data.gen.next().value).toEqual(select(getNodeLib));
});
it('should throw & catch if node is not web3 node', () => {
data.clone = data.gen.clone();
expect(data.clone.next().value).toEqual(put(web3UnsetNode()));
expect(data.clone.next().value).toEqual(
put(showNotification('danger', translate('Cannot use Web3 wallet without a Web3 node.')))
);
expect(data.clone.next().done).toEqual(true);
});
it('should apply nodeLib.getAccounts', () => {
expect(data.gen.next(nodeLib).value).toEqual(apply(nodeLib, nodeLib.getAccounts));
});
it('should throw & catch if no accounts found', () => {
data.clone1 = data.gen.clone();
expect(data.clone1.next([]).value).toEqual(put(web3UnsetNode()));
expect(data.clone1.next().value).toEqual(
put(showNotification('danger', translate('No accounts found in MetaMask / Mist.')))
);
expect(data.clone1.next().done).toEqual(true);
});
it('should match setWallet snapshot', () => {
expect(data.gen.next(accounts).value).toMatchSnapshot();
});
});