Connor Bryan e761b9d1fb Refactor redux pattern from top-level to ducks (#1936)
* Add a new route for AddressBook

* Further templating of the AddressBook view

* Add initial functionality to handle a table of existing address labels

* Make the linter happy

* Adjust paths

* Factor out TableRow and add common functionality

* Add initial Redux boilerplate for addressBook | fix minor linting issues

* Swap out terminology and types

* Connect up to Redux

* Connect data for AddressBookTable to Redux

* Use temporary fields for addition

* Remove alignment and index column

* Stopping point

* Adjust the sizing of rows to be consistent

* Initial implementation of a dropdown for the address field

* Minor styling to dropdown

* Stopping point

* Apply a focus concept onto the factory

* Add keyboard controls for the address field dropdown

* Adjust label of address field when it matches an addressBook entry

* Properly handle attempting to blur a non-existent component

* Minor styling changes on dropdown box

* Standardize address casing, add accessibility to dropdown

* Create an addressLabel component

* Pass refs correctly and fix some typings

* Exact version

* Add module name mapping for shared/keycodes

* addressBook reducer tests

* Add functionality to DeterministicModal

* Minor changes / Add test for addressBook selectors

* Move out AddressBookTable to a component

* Typing, translation and restructuring

* More typing and translation fixes

* More linting fixes

* More type changes

* Variable name for dropdown background

* Fix TS type errors, lint errors, remove unused props

* Used a different selector and removed method: AddressBookTable

* Linter was mad

* Linter mad again :(

* Add a translation and adjust styling of AddressBookTable

* Move the onBlur to a class method

* Prevent the default behavior of up/down/enter for dropdown

* Let's do it this way instead

* Adjust the styling on DeterministicWalletModal labels

* Change `AddressBookTable` into a pseudo-table using section and div

* Use readable keys vs. keycodes

* Put the dropdown in InputFactory and position it correctly

* Sanitation of label adding and changing

* Prevent duplicate labels in AddressBook and Row

* Add a box shadow and use `invalid` class insted of custom

* Use emphasis vs strong for address in dropdown

* Display the label undernearth the input vs. changing it

* Isolate AccountAddress into its own component

* Introduce interactivity to AccountAddress

* Fully incorporate with Redux

* Validation for AccountAddress

* Add validation notifications for address field on AddressBookTable

* Minor formatting

* Adjust wrappage for optimal flexboxxing

* Make AddressBookTable responsive

* Show an invalid input in "real time" instead of only on submit

* Real time input validation for AddressBookTableRow

* Responsive-ize the To address dropdown

* Hide identicons instead at small enough screen sizes

* Fix repsonsiveness of dropdown further

* Fix responsiveness of table rows and inputs

* Truncate account info and switch identicons to the right for consistency

* Use classnames instead of targetting element directly for DWM

* Display a notice if the entered query doesnt match a label and isnt an addr

* Don't show an error on the To address if its a label entry

* Display an error under AddressBookTableRow in real time

* Display errors in real time for AddressBookTable temp inputs

* Add realtime validation to AccountAddress

* Ensure toChecksumAddress is used when entering labels to address manager

* Show errors even after blurring.

* Create a ducks/ implementation for addressBook

* Duck-ize notifications

* Duck-ize customTokens

* Duck-ize deterministicWallets

* Only show errors on address/label entry if they have been blurred

* On certain inputs, show an invalid input immediately

* spec files in same directory

* Rename top-level redux directory

* Duck-ize gas

* Add displayed errors for labels with 0x and labels containing ens

* Move ENS checking validation out

* Add a saga for addLabelForAddress

* Completely revamp the redux side of Address Manager and test it all

* Adjust components to use new redux addressBook

* Incorporate new redux into AddressBookTableRow and clean up for linter

* Make linter and tests happy

* Another reduxy overhaul

* Still fixing it

* More redux updates

* Finalize redux stuff.

* Incorporate new reduxy way into AddressBookTable & Row

* Incorporate redux changes into Account Address

* Small tests fix

* Add and fix some selector tests

* Addressing Will's comments

* Shortened visibility class for line length reasons.

* Incorporate ducks pattern on updates addressBook

* Fix typeerror

* Migrate messages to ducks

* For Henry

* Duckify onboardStatus

* Duckify paritySigner

* Duckify rates

* Duckify transactions

* Duckerize wallet

* Reduckerate config

* Adjust exports and tests of every duck so far

* Duckify ENS

* Duckerificate schedule

* Duckificate swap

* Actually use the new sagas;  fix a circular dependency problem.

* Duckify transaction (phew)

* Add basics to redux/ directory

* Remove non-ducked redux stuff

* First sweep of redux/ directory

* Combine redundant imports

* Fix more linting stuff.

* A few more type fixes

* Welp... now I know not to use index.

* Sweep components/

* Sweep through containers/

* Im really starting to get frustrated

* The dawn of a new age.

* Linter fixes.

* De-flatten config/ reducers

* Do my thang on config selectors

* Adjust all references to config

* Split up ens reducers

* Wrap up de-nesting ENS

* Big boy refactor

* Split transaction into its reducers

* Fix reducers in transaction/

* Stopping point

* Adjust references to transaction from components

* Fix references to selectors

* Nest broadcast actions

* Nest field actions

* Nest meta actions

* Nest network actions

* Nest sign actions

* Nest broadcast types

* Nested fields types

* Nest meta types

* Nested network types

* Nested sign types

* Implement transaction saga changes

* Huh? No prepush problems?

* Update snappshot

* Reintroduce deleted tests

* A few missing tests found

* Found three missing transaction tests

* Found more tests

* Found the rest of the tests, woohoo.

* Renamed TypeKeys in TRANSACTION

* Specify TRANSACTION_BROADCAST

* Pretty up these imports

* Specify TRANSACTION_FIELDS

* Specify TRANSACTION_META

* Specify TRANSACTION_NETWORK

* Specify TRANSACTION_SIGN

* Adjust imports and add translations

* Update config snapshot

* Post-merge

* Temporary fix for DW/Config sagas so Daniel can continue smoke testing

* Remove first circulat dependency

* Fix more circular dependencies

* Properly structure config indices

* Further restructure config

* Prepare for idea

* Target directly from within features/

* Remove that circular dependency -- woohoo

* Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance

* Un-comment the component-in-redux phenomenon

* Move onLoad to the store file

* Adjust addressBook imports/exports

* Adjusted imports/exports for customTokens

* Adjust imports/exports of deterministicWallets

* Adjust imports/exports of ens

* Restructure imports/exports of gas

* Restructure imports/exports for message

* Adjust imports/exports of notifications

* Restructure onboardStatus imports/exports

* Restructure paritySigner imports/exports

* Restructure rates imports/exports

* Restructure schedule imports/exports

* Fix broadcastweb3handler test

* Restructure swap imports/exports/

* Restructure transactionS imports/exports

* Restructured wallet imports and exports

* Hoist all necessary selectors aside from config/**/* and transaction/**/*

* Hoist all top-level selectors from transaction

* [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj

* Implement right-click context menu (#1780) @ bryanwb

* No Private Keys Online (#1466) @ wbobeirne

* Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne

* [Fix] Make ENS Value Consistent (#1956) @ skubakdj

* Auto token add (#1808) @ HenryNguyen5

* Electron Ledger + Trezor Support (#1836) @ wbobeirne

* Fix Context Menu Popup Parameters (#1957)

* Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne

* Change displayed notification back in helpers.tsx

* Remove newline on shell files

* Re-add newlines

* Remove newling on .travis.yml

* Prettier two files

* Re-add index.scss import in OnboardModal

* Restructure transaction subdirectories

* Everything in transaction/ except for sagas

* Restructure transaction imports/exports

* Nest broadcast sagas

* Nest fields

* Nest meta

* Nest network

* Nest sign

* Use generic names for reduxy stuff in the same directory to save space

* Do everything every in the whole wide world
2018-06-17 20:53:00 -05:00

297 lines
9.2 KiB
TypeScript

import { cloneableGenerator } from 'redux-saga/utils';
import { call, put, select, apply } from 'redux-saga/effects';
import { bufferToHex } from 'ethereumjs-util';
import { computeIndexingHash } from 'libs/transaction';
import Web3Wallet from 'libs/wallet/non-deterministic/web3';
import * as configNodesSelectors from 'features/config/nodes/selectors';
import * as configSelectors from 'features/config/selectors';
import { walletSelectors } from 'features/wallet';
import { scheduleSelectors } from 'features/schedule';
import { notificationsActions } from 'features/notifications';
import { transactionFieldsActions } from '../fields';
import { transactionSignSelectors } from '../sign';
import * as actions from './actions';
import * as selectors from './selectors';
import * as sagas from './sagas';
describe('Broadcast Sagas', () => {
describe('broadcastLocalTransactionHandler*', () => {
const signedTx = 'signedTx';
const node: any = {
sendRawTx: jest.fn()
};
const txHash = 'txHash';
const gen = sagas.broadcastLocalTransactionHandler(signedTx);
it('should select getNodeLib', () => {
expect(gen.next().value).toEqual(select(configNodesSelectors.getNodeLib));
});
it('should apply node.sendRawTx', () => {
expect(gen.next(node).value).toEqual(apply(node, node.sendRawTx, [signedTx]));
});
it('should return txHash', () => {
expect(gen.next(txHash).value).toEqual(txHash);
});
it('should be done', () => {
expect(gen.next().done).toEqual(true);
});
});
describe('broadcastWeb3TransactionHandler*', () => {
const tx = 'tx';
const notWeb3Wallet = false;
const web3Wallet = new Web3Wallet('', '');
const txHash = 'txHash';
const nodeLib = { getNetVersion: () => 'ETH' };
const netId = 'ETH';
const networkConfig = { id: 'ETH' };
const gens: any = {};
gens.gen = cloneableGenerator(sagas.broadcastWeb3TransactionHandler)(tx);
it('should select getWalletInst', () => {
expect(gens.gen.next().value).toEqual(select(walletSelectors.getWalletInst));
});
it('should throw if not a web3 wallet', () => {
gens.clone1 = gens.gen.clone();
expect(() => gens.clone1.next(notWeb3Wallet)).toThrow();
});
it('should apply wallet.sendTransaction', () => {
gens.gen.next(web3Wallet);
gens.gen.next(nodeLib);
gens.gen.next(netId);
expect(gens.gen.next(networkConfig).value).toEqual(
apply(web3Wallet as any, web3Wallet.sendTransaction as any, [tx, nodeLib, networkConfig])
);
});
it('should return txHash', () => {
expect(gens.gen.next(txHash).value).toEqual(txHash);
});
it('should be done', () => {
expect(gens.gen.next().done).toEqual(true);
});
});
});
describe('Broadcast sagas', () => {
describe('broadcastTransactionWrapper*', () => {
const indexingHash = 'indexingHash';
const serializedTransaction = new Buffer('serializedTransaction');
const shouldBroadcast = true;
const stringTx = 'stringTx';
const broadcastedHash: any = 'broadcastedHash';
const network: any = {
blockExplorer: 'blockExplorer'
};
let random: () => number;
const func: any = () => undefined;
const action: any = {};
const gens: any = {};
gens.gen = cloneableGenerator(sagas.broadcastTransactionWrapper(func))(action);
beforeAll(() => {
random = Math.random;
Math.random = () => 0.001;
});
afterAll(() => {
Math.random = random;
});
it('should call getSerializedTxAndIndexingHash with action', () => {
expect(gens.gen.next().value).toEqual(call(sagas.getSerializedTxAndIndexingHash, action));
});
it('should call shouldBroadcastTransaction with indexingHash', () => {
expect(
gens.gen.next({
indexingHash,
serializedTransaction
}).value
).toEqual(call(sagas.shouldBroadcastTransaction, indexingHash));
});
it('should handle exceptions', () => {
gens.clone1 = gens.gen.clone();
const error = { message: 'message' };
expect(gens.clone1.throw(error).value).toEqual(
put(actions.broadcastTransactionFailed({ indexingHash }))
);
expect(gens.clone1.next().value).toEqual(
put(notificationsActions.showNotification('danger', error.message))
);
expect(gens.clone1.next().done).toEqual(true);
});
it('should put showNotification & reset if !shouldBroadcast', () => {
gens.clone2 = gens.gen.clone();
expect(gens.clone2.next().value).toEqual(
put(
notificationsActions.showNotification(
'warning',
'TxHash identical: This transaction has already been broadcasted or is broadcasting'
)
)
);
expect(gens.clone2.next().value).toEqual(
put(transactionFieldsActions.resetTransactionRequested())
);
expect(gens.clone2.next(!shouldBroadcast).done).toEqual(true);
});
it('should put broadcastTransactionQueued', () => {
expect(gens.gen.next(shouldBroadcast).value).toEqual(
put(
actions.broadcastTransactionQueued({
indexingHash,
serializedTransaction
})
)
);
});
it('should call bufferToHex with serializedTransactioin', () => {
expect(gens.gen.next().value).toEqual(call(bufferToHex, serializedTransaction));
});
it('should call func with stringTx', () => {
expect(gens.gen.next(stringTx).value).toEqual(call(func, stringTx));
});
it('should put broadcastTransactionSucceeded', () => {
expect(gens.gen.next(broadcastedHash).value).toEqual(
put(
actions.broadcastTransactionSucceeded({
indexingHash,
broadcastedHash
})
)
);
});
it('select getNetworkConfig', () => {
expect(gens.gen.next().value).toEqual(select(configSelectors.getNetworkConfig));
});
it('select isSchedulingEnabled', () => {
expect(gens.gen.next(network).value).toEqual(select(scheduleSelectors.isSchedulingEnabled));
});
it('should put showNotification', () => {
expect(gens.gen.next(false).value).toEqual(
put(
notificationsActions.showNotificationWithComponent(
'success',
'',
{
component: 'TransactionSucceeded',
txHash: broadcastedHash,
blockExplorer: network.blockExplorer,
scheduling: false
},
Infinity
)
)
);
});
it('should be done', () => {
expect(gens.gen.next().done).toEqual(true);
});
});
describe('shouldBroadCastTransaction*', () => {
const indexingHash = 'indexingHash';
const existingTxIsBroadcasting: any = {
isBroadcasting: true
};
const existingTxBroadcastSuccessful: any = {
broadcastSuccessful: true
};
const existingTxFalse: any = false;
const gens: any = {};
gens.gen = cloneableGenerator(sagas.shouldBroadcastTransaction)(indexingHash);
it('should select getTransactionStats with indexingHash', () => {
expect(gens.gen.next().value).toEqual(select(selectors.getTransactionStatus, indexingHash));
});
it('should return false when isBroadcasting', () => {
gens.clone1 = gens.gen.clone();
expect(gens.clone1.next(existingTxIsBroadcasting).value).toEqual(false);
});
it('should return false when broadcastSuccessful', () => {
gens.clone2 = gens.gen.clone();
expect(gens.clone2.next(existingTxBroadcastSuccessful).value).toEqual(false);
});
it('should return true when there is no existingTx', () => {
gens.gen = gens.gen.clone();
expect(gens.gen.next(existingTxFalse).value).toEqual(true);
});
it('should be done', () => {
expect(gens.gen.next().done).toEqual(true);
});
});
describe('getSerializedTxAndIndexingHash*', () => {
const web3Req: any = {
type: 'BROADCAST_WEB3_TRANSACTION_REQUESTED'
};
const notWeb3Req: any = {
type: 'NOT_WEB3_TRANSACTION_REQUEST'
};
const serializedTransaction: any = true;
const indexingHash = 'indexingHash';
const gens: any = {};
gens.gen1 = cloneableGenerator(sagas.getSerializedTxAndIndexingHash)(web3Req);
const gen2 = sagas.getSerializedTxAndIndexingHash(notWeb3Req);
it('should select getWeb3Tx', () => {
expect(gens.gen1.next().value).toEqual(select(transactionSignSelectors.getWeb3Tx));
});
it('should select getSignedTx', () => {
expect(gen2.next().value).toEqual(select(transactionSignSelectors.getSignedTx));
});
it('should throw error if !serializedTransaction', () => {
gens.clone1 = gens.gen1.clone();
expect(() => gens.clone1.next(!serializedTransaction)).toThrowError(
'Can not broadcast: tx does not exist'
);
});
it('should call computeIndexingHash', () => {
expect(gens.gen1.next(serializedTransaction).value).toEqual(
call(computeIndexingHash, serializedTransaction)
);
});
it('should return correctly', () => {
expect(gens.gen1.next(indexingHash).value).toEqual({
serializedTransaction,
indexingHash
});
});
it('should be done', () => {
expect(gens.gen1.next().done).toEqual(true);
});
});
});