mirror of
https://github.com/status-im/MyCrypto.git
synced 2025-01-20 07:58:51 +00:00
04f75a6a27
* Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons.
140 lines
4.9 KiB
TypeScript
140 lines
4.9 KiB
TypeScript
import { configuredStore } from 'store';
|
|
import {
|
|
isValidBTCAddress,
|
|
isValidETHAddress,
|
|
isValidPath,
|
|
isValidPrivKey,
|
|
isLabelWithoutENS,
|
|
isValidAddressLabel
|
|
} from '../../common/libs/validators';
|
|
import { translateRaw } from '../../common/translations';
|
|
import { DPaths } from 'config/dpaths';
|
|
import { valid, invalid } from '../utils/testStrings';
|
|
|
|
configuredStore.getState();
|
|
|
|
const VALID_BTC_ADDRESS = '1MEWT2SGbqtz6mPCgFcnea8XmWV5Z4Wc6';
|
|
const VALID_ETH_ADDRESS = '0x7cB57B5A97eAbe94205C07890BE4c1aD31E486A8';
|
|
const VALID_ETH_PRIVATE_KEY = '3f4fd89ea4970cc77bfd2d07a95786575ea62e183857afe6301578e1a3c5c782';
|
|
const INVALID_ETH_PRIVATE_KEY = '3f4fd89ea4970cc77bfd2d07a95786575ea62e183857afe6301578e1a3c5ZZZZ';
|
|
const VALID_ETH_PRIVATE_BUFFER = Buffer.from(VALID_ETH_PRIVATE_KEY, 'hex');
|
|
const VALID_ETH_PRIVATE_0X = '0x3f4fd89ea4970cc77bfd2d07a95786575ea62e183857afe6301578e1a3c5c782';
|
|
|
|
describe('Validator', () => {
|
|
it('should validate correct BTC address as true', () => {
|
|
expect(isValidBTCAddress(VALID_BTC_ADDRESS)).toBeTruthy();
|
|
});
|
|
it('should validate incorrect BTC address as false', () => {
|
|
expect(isValidBTCAddress('nonsense' + VALID_BTC_ADDRESS + 'nonsense')).toBeFalsy();
|
|
});
|
|
|
|
it('should validate correct ETH address as true', () => {
|
|
expect(isValidETHAddress(VALID_ETH_ADDRESS)).toBeTruthy();
|
|
});
|
|
it('should validate incorrect ETH address as false', () => {
|
|
expect(isValidETHAddress('nonsense' + VALID_ETH_ADDRESS + 'nonsense')).toBeFalsy();
|
|
});
|
|
it('should validate an incorrect DPath as false', () => {
|
|
expect(isValidPath('m/44/60/0/0')).toBeFalsy();
|
|
});
|
|
it('should validate private key as true', () => {
|
|
expect(isValidPrivKey(VALID_ETH_PRIVATE_KEY)).toBeTruthy();
|
|
});
|
|
it('should validate invalid private key as false', () => {
|
|
expect(isValidPrivKey(INVALID_ETH_PRIVATE_KEY)).toBeFalsy();
|
|
});
|
|
it('should validate 0x private keys as true', () => {
|
|
expect(isValidPrivKey(VALID_ETH_PRIVATE_0X)).toBeTruthy();
|
|
});
|
|
it('should validate private key buffer type as true', () => {
|
|
expect(isValidPrivKey(VALID_ETH_PRIVATE_BUFFER)).toBeTruthy();
|
|
});
|
|
});
|
|
|
|
describe('Validator', () => {
|
|
it('should validate correct DPaths as true', () => {
|
|
valid.forEach(path => {
|
|
expect(isValidPath(path)).toBeTruthy();
|
|
});
|
|
});
|
|
it('should validate incorrect DPaths as false', () => {
|
|
invalid.forEach(path => {
|
|
expect(isValidPath(path)).toBeFalsy();
|
|
});
|
|
});
|
|
it('should validate hardcoded DPaths as true', () => {
|
|
DPaths.forEach(DPath => {
|
|
expect(isValidPath(DPath.value)).toBeTruthy();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('isLabelWithoutENS', () => {
|
|
it('should return false if the label contains an ENS TLD', () => {
|
|
expect(isLabelWithoutENS('Foo.eth')).toEqual(false);
|
|
expect(isLabelWithoutENS('Foo.test')).toEqual(false);
|
|
expect(isLabelWithoutENS('Foo.reverse')).toEqual(false);
|
|
});
|
|
it('should return true if a label does not contain an ENS TLD', () => {
|
|
expect(isLabelWithoutENS('Foo')).toEqual(true);
|
|
});
|
|
});
|
|
|
|
describe('isValidAddressLabel', () => {
|
|
const validAddress = '0x081f37708032d0a7b3622591a8959b213fb47d6f';
|
|
const otherValidAddress = '0x86fa049857e0209aa7d9e616f7eb3b3b78ecfdb0';
|
|
const addresses = {
|
|
[validAddress]: 'Foo'
|
|
};
|
|
const labels = {
|
|
Foo: validAddress
|
|
};
|
|
|
|
describe('Happy path', () => {
|
|
it('should return valid', () => {
|
|
expect(isValidAddressLabel(validAddress, 'Foo', {}, {}).isValid).toEqual(true);
|
|
});
|
|
});
|
|
describe('Invalid cases', () => {
|
|
it('should return invalid when the provided address is invalid', () => {
|
|
const { isValid, addressError } = isValidAddressLabel('derp', 'Foo', {}, {});
|
|
|
|
expect(isValid).toEqual(false);
|
|
expect(addressError).toEqual(translateRaw('INVALID_ADDRESS'));
|
|
});
|
|
|
|
it('should return invalid if the address already exists', () => {
|
|
const { isValid, addressError } = isValidAddressLabel(validAddress, 'Foo', addresses, labels);
|
|
|
|
expect(isValid).toEqual(false);
|
|
expect(addressError).toEqual(translateRaw('ADDRESS_ALREADY_EXISTS'));
|
|
});
|
|
|
|
it('should return invalid if the label is not of correct length', () => {
|
|
const { isValid, labelError } = isValidAddressLabel(validAddress, 'X', {}, {});
|
|
|
|
expect(isValid).toEqual(false);
|
|
expect(labelError).toEqual(translateRaw('INVALID_LABEL_LENGTH'));
|
|
});
|
|
|
|
it('should return invalid if the label contains an ENS TLD', () => {
|
|
const { isValid, labelError } = isValidAddressLabel(validAddress, 'Foo.eth', {}, {});
|
|
|
|
expect(isValid).toEqual(false);
|
|
expect(labelError).toEqual(translateRaw('LABEL_CANNOT_CONTAIN_ENS_SUFFIX'));
|
|
});
|
|
|
|
it('should return invalid if the label already exists', () => {
|
|
const { isValid, labelError } = isValidAddressLabel(
|
|
otherValidAddress,
|
|
'Foo',
|
|
addresses,
|
|
labels
|
|
);
|
|
|
|
expect(isValid).toEqual(false);
|
|
expect(labelError).toEqual(translateRaw('LABEL_ALREADY_EXISTS'));
|
|
});
|
|
});
|
|
});
|