mirror of
https://github.com/status-im/MyCrypto.git
synced 2025-02-04 07:14:03 +00:00
e761b9d1fb
* Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Create a ducks/ implementation for addressBook * Duck-ize notifications * Duck-ize customTokens * Duck-ize deterministicWallets * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * spec files in same directory * Rename top-level redux directory * Duck-ize gas * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons. * Incorporate ducks pattern on updates addressBook * Fix typeerror * Migrate messages to ducks * For Henry * Duckify onboardStatus * Duckify paritySigner * Duckify rates * Duckify transactions * Duckerize wallet * Reduckerate config * Adjust exports and tests of every duck so far * Duckify ENS * Duckerificate schedule * Duckificate swap * Actually use the new sagas; fix a circular dependency problem. * Duckify transaction (phew) * Add basics to redux/ directory * Remove non-ducked redux stuff * First sweep of redux/ directory * Combine redundant imports * Fix more linting stuff. * A few more type fixes * Welp... now I know not to use index. * Sweep components/ * Sweep through containers/ * Im really starting to get frustrated * The dawn of a new age. * Linter fixes. * De-flatten config/ reducers * Do my thang on config selectors * Adjust all references to config * Split up ens reducers * Wrap up de-nesting ENS * Big boy refactor * Split transaction into its reducers * Fix reducers in transaction/ * Stopping point * Adjust references to transaction from components * Fix references to selectors * Nest broadcast actions * Nest field actions * Nest meta actions * Nest network actions * Nest sign actions * Nest broadcast types * Nested fields types * Nest meta types * Nested network types * Nested sign types * Implement transaction saga changes * Huh? No prepush problems? * Update snappshot * Reintroduce deleted tests * A few missing tests found * Found three missing transaction tests * Found more tests * Found the rest of the tests, woohoo. * Renamed TypeKeys in TRANSACTION * Specify TRANSACTION_BROADCAST * Pretty up these imports * Specify TRANSACTION_FIELDS * Specify TRANSACTION_META * Specify TRANSACTION_NETWORK * Specify TRANSACTION_SIGN * Adjust imports and add translations * Update config snapshot * Post-merge * Temporary fix for DW/Config sagas so Daniel can continue smoke testing * Remove first circulat dependency * Fix more circular dependencies * Properly structure config indices * Further restructure config * Prepare for idea * Target directly from within features/ * Remove that circular dependency -- woohoo * Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance * Un-comment the component-in-redux phenomenon * Move onLoad to the store file * Adjust addressBook imports/exports * Adjusted imports/exports for customTokens * Adjust imports/exports of deterministicWallets * Adjust imports/exports of ens * Restructure imports/exports of gas * Restructure imports/exports for message * Adjust imports/exports of notifications * Restructure onboardStatus imports/exports * Restructure paritySigner imports/exports * Restructure rates imports/exports * Restructure schedule imports/exports * Fix broadcastweb3handler test * Restructure swap imports/exports/ * Restructure transactionS imports/exports * Restructured wallet imports and exports * Hoist all necessary selectors aside from config/**/* and transaction/**/* * Hoist all top-level selectors from transaction * [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj * Implement right-click context menu (#1780) @ bryanwb * No Private Keys Online (#1466) @ wbobeirne * Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne * [Fix] Make ENS Value Consistent (#1956) @ skubakdj * Auto token add (#1808) @ HenryNguyen5 * Electron Ledger + Trezor Support (#1836) @ wbobeirne * Fix Context Menu Popup Parameters (#1957) * Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne * Change displayed notification back in helpers.tsx * Remove newline on shell files * Re-add newlines * Remove newling on .travis.yml * Prettier two files * Re-add index.scss import in OnboardModal * Restructure transaction subdirectories * Everything in transaction/ except for sagas * Restructure transaction imports/exports * Nest broadcast sagas * Nest fields * Nest meta * Nest network * Nest sign * Use generic names for reduxy stuff in the same directory to save space * Do everything every in the whole wide world
118 lines
3.3 KiB
TypeScript
118 lines
3.3 KiB
TypeScript
import Tx from 'ethereumjs-tx';
|
|
import { bufferToHex } from 'ethereumjs-util';
|
|
|
|
import { translateRaw } from 'translations';
|
|
import { Wei } from 'libs/units';
|
|
import { isValidAddress } from 'libs/validators';
|
|
import { IFullWallet } from 'libs/wallet';
|
|
import { hexEncodeQuantity, hexEncodeData } from 'libs/nodes/rpc/utils';
|
|
import { TransactionFieldValues } from 'features/types';
|
|
import { ITransaction, IHexStrTransaction } from '../typings';
|
|
|
|
// we dont include the signature paramaters because web3 transactions are unsigned
|
|
const computeIndexingHash = (tx: Buffer) => bufferToHex(makeTransaction(tx).hash(false));
|
|
|
|
// Get useable fields from an EthTx object.
|
|
const getTransactionFields = (t: Tx): IHexStrTransaction => {
|
|
// For some crazy reason, toJSON spits out an array, not keyed values.
|
|
const { data, gasLimit, gasPrice, to, nonce, value } = t;
|
|
const chainId = t.getChainId();
|
|
|
|
return {
|
|
value: hexEncodeQuantity(value),
|
|
data: hexEncodeData(data),
|
|
// To address is unchecksummed, which could cause mismatches in comparisons
|
|
to: hexEncodeData(to),
|
|
// Everything else is as-is
|
|
nonce: hexEncodeQuantity(nonce),
|
|
gasPrice: hexEncodeQuantity(gasPrice),
|
|
gasLimit: hexEncodeQuantity(gasLimit),
|
|
chainId
|
|
};
|
|
};
|
|
|
|
const getTransactionFee = (gasPrice: string, gasLimit: string) => {
|
|
return Wei(gasPrice).mul(Wei(gasLimit));
|
|
};
|
|
|
|
/**
|
|
* @description Return the minimum amount of ether needed
|
|
* @param t
|
|
*/
|
|
const enoughBalanceViaTx = (t: Tx | ITransaction, accountBalance: Wei) =>
|
|
makeTransaction(t)
|
|
.getUpfrontCost()
|
|
.lte(accountBalance);
|
|
|
|
/**
|
|
* @description Return the minimum amount of gas needed (for gas limit validation)
|
|
* @param t
|
|
*/
|
|
const validGasLimit = (t: ITransaction) =>
|
|
makeTransaction(t)
|
|
.getBaseFee()
|
|
.lte(t.gasLimit);
|
|
|
|
/**
|
|
* @description Check that gas limits and prices are within valid ranges
|
|
* @param t
|
|
*/
|
|
const gasParamsInRange = (t: ITransaction) => {
|
|
if (t.gasLimit.ltn(21000)) {
|
|
throw Error(translateRaw('ERROR_GAS_LIMIT_LOW', { $limit: '21000' }));
|
|
}
|
|
if (t.gasLimit.gtn(5000000)) {
|
|
throw Error(translateRaw('GETH_GASLIMIT'));
|
|
}
|
|
if (t.gasPrice.gt(Wei('1000000000000'))) {
|
|
throw Error(translateRaw('ERROR_GAS_LIMIT_HIGH'));
|
|
}
|
|
};
|
|
|
|
const validAddress = (t: ITransaction) => {
|
|
if (!isValidAddress(bufferToHex(t.to), t.chainId)) {
|
|
throw Error(translateRaw('ERROR_5'));
|
|
}
|
|
};
|
|
|
|
const makeTransaction = (
|
|
t:
|
|
| Partial<Tx>
|
|
| Partial<ITransaction>
|
|
| Partial<IHexStrTransaction>
|
|
| Buffer
|
|
| string
|
|
| TransactionFieldValues
|
|
) => new Tx(t);
|
|
|
|
//TODO: check that addresses are always checksummed
|
|
const signTx = async (t: ITransaction, w: IFullWallet) => {
|
|
const tx = makeTransaction(t);
|
|
const signedTx = await w.signRawTransaction(tx); //returns a serialized, signed tx
|
|
return signedTx; //instead of returning the rawTx with it, we can derive it from the signedTx anyway
|
|
};
|
|
|
|
const validateTx = (t: ITransaction, accountBalance: Wei, isOffline: boolean) => {
|
|
gasParamsInRange(t);
|
|
if (!isOffline && !validGasLimit(t)) {
|
|
throw Error('Not enough gas supplied');
|
|
}
|
|
if (!enoughBalanceViaTx(t, accountBalance)) {
|
|
throw Error(translateRaw('GETH_BALANCE'));
|
|
}
|
|
validAddress(t);
|
|
};
|
|
|
|
export {
|
|
signTx,
|
|
validAddress,
|
|
validGasLimit,
|
|
enoughBalanceViaTx,
|
|
gasParamsInRange,
|
|
validateTx,
|
|
makeTransaction,
|
|
getTransactionFields,
|
|
getTransactionFee,
|
|
computeIndexingHash
|
|
};
|