Connor Bryan e761b9d1fb Refactor redux pattern from top-level to ducks (#1936)
* Add a new route for AddressBook

* Further templating of the AddressBook view

* Add initial functionality to handle a table of existing address labels

* Make the linter happy

* Adjust paths

* Factor out TableRow and add common functionality

* Add initial Redux boilerplate for addressBook | fix minor linting issues

* Swap out terminology and types

* Connect up to Redux

* Connect data for AddressBookTable to Redux

* Use temporary fields for addition

* Remove alignment and index column

* Stopping point

* Adjust the sizing of rows to be consistent

* Initial implementation of a dropdown for the address field

* Minor styling to dropdown

* Stopping point

* Apply a focus concept onto the factory

* Add keyboard controls for the address field dropdown

* Adjust label of address field when it matches an addressBook entry

* Properly handle attempting to blur a non-existent component

* Minor styling changes on dropdown box

* Standardize address casing, add accessibility to dropdown

* Create an addressLabel component

* Pass refs correctly and fix some typings

* Exact version

* Add module name mapping for shared/keycodes

* addressBook reducer tests

* Add functionality to DeterministicModal

* Minor changes / Add test for addressBook selectors

* Move out AddressBookTable to a component

* Typing, translation and restructuring

* More typing and translation fixes

* More linting fixes

* More type changes

* Variable name for dropdown background

* Fix TS type errors, lint errors, remove unused props

* Used a different selector and removed method: AddressBookTable

* Linter was mad

* Linter mad again :(

* Add a translation and adjust styling of AddressBookTable

* Move the onBlur to a class method

* Prevent the default behavior of up/down/enter for dropdown

* Let's do it this way instead

* Adjust the styling on DeterministicWalletModal labels

* Change `AddressBookTable` into a pseudo-table using section and div

* Use readable keys vs. keycodes

* Put the dropdown in InputFactory and position it correctly

* Sanitation of label adding and changing

* Prevent duplicate labels in AddressBook and Row

* Add a box shadow and use `invalid` class insted of custom

* Use emphasis vs strong for address in dropdown

* Display the label undernearth the input vs. changing it

* Isolate AccountAddress into its own component

* Introduce interactivity to AccountAddress

* Fully incorporate with Redux

* Validation for AccountAddress

* Add validation notifications for address field on AddressBookTable

* Minor formatting

* Adjust wrappage for optimal flexboxxing

* Make AddressBookTable responsive

* Show an invalid input in "real time" instead of only on submit

* Real time input validation for AddressBookTableRow

* Responsive-ize the To address dropdown

* Hide identicons instead at small enough screen sizes

* Fix repsonsiveness of dropdown further

* Fix responsiveness of table rows and inputs

* Truncate account info and switch identicons to the right for consistency

* Use classnames instead of targetting element directly for DWM

* Display a notice if the entered query doesnt match a label and isnt an addr

* Don't show an error on the To address if its a label entry

* Display an error under AddressBookTableRow in real time

* Display errors in real time for AddressBookTable temp inputs

* Add realtime validation to AccountAddress

* Ensure toChecksumAddress is used when entering labels to address manager

* Show errors even after blurring.

* Create a ducks/ implementation for addressBook

* Duck-ize notifications

* Duck-ize customTokens

* Duck-ize deterministicWallets

* Only show errors on address/label entry if they have been blurred

* On certain inputs, show an invalid input immediately

* spec files in same directory

* Rename top-level redux directory

* Duck-ize gas

* Add displayed errors for labels with 0x and labels containing ens

* Move ENS checking validation out

* Add a saga for addLabelForAddress

* Completely revamp the redux side of Address Manager and test it all

* Adjust components to use new redux addressBook

* Incorporate new redux into AddressBookTableRow and clean up for linter

* Make linter and tests happy

* Another reduxy overhaul

* Still fixing it

* More redux updates

* Finalize redux stuff.

* Incorporate new reduxy way into AddressBookTable & Row

* Incorporate redux changes into Account Address

* Small tests fix

* Add and fix some selector tests

* Addressing Will's comments

* Shortened visibility class for line length reasons.

* Incorporate ducks pattern on updates addressBook

* Fix typeerror

* Migrate messages to ducks

* For Henry

* Duckify onboardStatus

* Duckify paritySigner

* Duckify rates

* Duckify transactions

* Duckerize wallet

* Reduckerate config

* Adjust exports and tests of every duck so far

* Duckify ENS

* Duckerificate schedule

* Duckificate swap

* Actually use the new sagas;  fix a circular dependency problem.

* Duckify transaction (phew)

* Add basics to redux/ directory

* Remove non-ducked redux stuff

* First sweep of redux/ directory

* Combine redundant imports

* Fix more linting stuff.

* A few more type fixes

* Welp... now I know not to use index.

* Sweep components/

* Sweep through containers/

* Im really starting to get frustrated

* The dawn of a new age.

* Linter fixes.

* De-flatten config/ reducers

* Do my thang on config selectors

* Adjust all references to config

* Split up ens reducers

* Wrap up de-nesting ENS

* Big boy refactor

* Split transaction into its reducers

* Fix reducers in transaction/

* Stopping point

* Adjust references to transaction from components

* Fix references to selectors

* Nest broadcast actions

* Nest field actions

* Nest meta actions

* Nest network actions

* Nest sign actions

* Nest broadcast types

* Nested fields types

* Nest meta types

* Nested network types

* Nested sign types

* Implement transaction saga changes

* Huh? No prepush problems?

* Update snappshot

* Reintroduce deleted tests

* A few missing tests found

* Found three missing transaction tests

* Found more tests

* Found the rest of the tests, woohoo.

* Renamed TypeKeys in TRANSACTION

* Specify TRANSACTION_BROADCAST

* Pretty up these imports

* Specify TRANSACTION_FIELDS

* Specify TRANSACTION_META

* Specify TRANSACTION_NETWORK

* Specify TRANSACTION_SIGN

* Adjust imports and add translations

* Update config snapshot

* Post-merge

* Temporary fix for DW/Config sagas so Daniel can continue smoke testing

* Remove first circulat dependency

* Fix more circular dependencies

* Properly structure config indices

* Further restructure config

* Prepare for idea

* Target directly from within features/

* Remove that circular dependency -- woohoo

* Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance

* Un-comment the component-in-redux phenomenon

* Move onLoad to the store file

* Adjust addressBook imports/exports

* Adjusted imports/exports for customTokens

* Adjust imports/exports of deterministicWallets

* Adjust imports/exports of ens

* Restructure imports/exports of gas

* Restructure imports/exports for message

* Adjust imports/exports of notifications

* Restructure onboardStatus imports/exports

* Restructure paritySigner imports/exports

* Restructure rates imports/exports

* Restructure schedule imports/exports

* Fix broadcastweb3handler test

* Restructure swap imports/exports/

* Restructure transactionS imports/exports

* Restructured wallet imports and exports

* Hoist all necessary selectors aside from config/**/* and transaction/**/*

* Hoist all top-level selectors from transaction

* [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj

* Implement right-click context menu (#1780) @ bryanwb

* No Private Keys Online (#1466) @ wbobeirne

* Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne

* [Fix] Make ENS Value Consistent (#1956) @ skubakdj

* Auto token add (#1808) @ HenryNguyen5

* Electron Ledger + Trezor Support (#1836) @ wbobeirne

* Fix Context Menu Popup Parameters (#1957)

* Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne

* Change displayed notification back in helpers.tsx

* Remove newline on shell files

* Re-add newlines

* Remove newling on .travis.yml

* Prettier two files

* Re-add index.scss import in OnboardModal

* Restructure transaction subdirectories

* Everything in transaction/ except for sagas

* Restructure transaction imports/exports

* Nest broadcast sagas

* Nest fields

* Nest meta

* Nest network

* Nest sign

* Use generic names for reduxy stuff in the same directory to save space

* Do everything every in the whole wide world
2018-06-17 20:53:00 -05:00

485 lines
15 KiB
TypeScript

import EthTx from 'ethereumjs-tx';
import BN from 'bn.js';
import { gasPriceToBase, getDecimalFromEtherUnit } from 'libs/units';
import {
transactionBroadcastTypes,
transactionBroadcastActions,
transactionBroadcastReducer
} from './broadcast';
import {
transactionFieldsTypes,
transactionFieldsActions,
transactionFieldsReducer
} from './fields';
import { transactionMetaTypes, transactionMetaActions, transactionMetaReducer } from './meta';
import {
transactionNetworkTypes,
transactionNetworkActions,
transactionNetworkReducer
} from './network';
import { transactionSignTypes, transactionSignReducer } from './sign';
import * as types from './types';
describe('transaction: Reducers', () => {
describe('Broadcast', () => {
const indexingHash = 'testingHash';
const serializedTransaction = new Buffer('testSerialized');
const nextTxStatus: transactionBroadcastTypes.ITransactionStatus = {
broadcastedHash: null,
broadcastSuccessful: false,
isBroadcasting: true,
serializedTransaction
};
const nextState: transactionBroadcastTypes.TransactionBroadcastState = {
...transactionBroadcastReducer.BROADCAST_INITIAL_STATE,
[indexingHash]: nextTxStatus
};
it('should handle BROADCAST_TRANSACTION_QUEUED', () => {
expect(
transactionBroadcastReducer.broadcastReducer(
transactionBroadcastReducer.BROADCAST_INITIAL_STATE as transactionBroadcastTypes.TransactionBroadcastState,
transactionBroadcastActions.broadcastTransactionQueued({
indexingHash,
serializedTransaction
})
)
).toEqual(nextState);
});
it('should handle BROADCAST_TRANSACTION_SUCCESS', () => {
const broadcastedHash = 'testBroadcastHash';
const broadcastedState = {
...nextState,
[indexingHash]: {
...nextTxStatus,
broadcastedHash,
isBroadcasting: false,
broadcastSuccessful: true
}
};
expect(
transactionBroadcastReducer.broadcastReducer(
nextState,
transactionBroadcastActions.broadcastTransactionSucceeded({
indexingHash,
broadcastedHash
})
)
).toEqual(broadcastedState);
});
it('should handle BROADCAST_TRANSACTION_FAILURE', () => {
const failedBroadcastState = {
...nextState,
[indexingHash]: { ...nextTxStatus, isBroadcasting: false, broadcastSuccessful: false }
};
expect(
transactionBroadcastReducer.broadcastReducer(
nextState,
transactionBroadcastActions.broadcastTransactionFailed({ indexingHash })
)
).toEqual(failedBroadcastState);
});
});
describe('Fields', () => {
const FIELDS_INITIAL_STATE: transactionFieldsTypes.TransactionFieldsState = {
to: { raw: '', value: null },
data: { raw: '', value: null },
nonce: { raw: '', value: null },
value: { raw: '', value: null },
gasLimit: { raw: '21000', value: new BN(21000) },
gasPrice: { raw: '20', value: gasPriceToBase(20) }
};
const testPayload = { raw: 'test', value: null };
it('should handle TO_FIELD_SET', () => {
expect(
transactionFieldsReducer.fieldsReducer(
FIELDS_INITIAL_STATE,
transactionFieldsActions.setToField(testPayload)
)
).toEqual({
...FIELDS_INITIAL_STATE,
to: testPayload
});
});
it('should handle VALUE_FIELD_SET', () => {
expect(
transactionFieldsReducer.fieldsReducer(
FIELDS_INITIAL_STATE,
transactionFieldsActions.setValueField(testPayload)
)
).toEqual({
...FIELDS_INITIAL_STATE,
value: testPayload
});
});
it('should handle DATA_FIELD_SET', () => {
expect(
transactionFieldsReducer.fieldsReducer(
FIELDS_INITIAL_STATE,
transactionFieldsActions.setDataField(testPayload)
)
).toEqual({
...FIELDS_INITIAL_STATE,
data: testPayload
});
});
it('should handle GAS_LIMIT_FIELD_SET', () => {
expect(
transactionFieldsReducer.fieldsReducer(
FIELDS_INITIAL_STATE,
transactionFieldsActions.setGasLimitField(testPayload)
)
).toEqual({
...FIELDS_INITIAL_STATE,
gasLimit: testPayload
});
});
it('should handle NONCE_SET', () => {
expect(
transactionFieldsReducer.fieldsReducer(
FIELDS_INITIAL_STATE,
transactionFieldsActions.setNonceField(testPayload)
)
).toEqual({
...FIELDS_INITIAL_STATE,
nonce: testPayload
});
});
it('should handle GAS_PRICE_FIELD_SET', () => {
expect(
transactionFieldsReducer.fieldsReducer(
FIELDS_INITIAL_STATE,
transactionFieldsActions.setGasPriceField(testPayload)
)
).toEqual({
...FIELDS_INITIAL_STATE,
gasPrice: testPayload
});
});
it('should handle TOKEN_TO_ETHER_SWAP', () => {
const swapAction: types.SwapTokenToEtherAction = {
type: types.TransactionActions.TOKEN_TO_ETHER_SWAP,
payload: {
to: testPayload,
value: testPayload,
decimal: 1
}
};
expect(transactionFieldsReducer.fieldsReducer(FIELDS_INITIAL_STATE, swapAction)).toEqual({
...FIELDS_INITIAL_STATE,
to: testPayload,
value: testPayload
});
});
it('should handle ETHER_TO_TOKEN_SWAP', () => {
const swapAction: types.SwapEtherToTokenAction = {
type: types.TransactionActions.ETHER_TO_TOKEN_SWAP,
payload: {
to: testPayload,
data: testPayload,
tokenTo: testPayload,
tokenValue: testPayload,
decimal: 1
}
};
expect(transactionFieldsReducer.fieldsReducer(FIELDS_INITIAL_STATE, swapAction)).toEqual({
...FIELDS_INITIAL_STATE,
to: testPayload,
data: testPayload
});
});
it('should handle TOKEN_TO_TOKEN_SWAP', () => {
const swapAction: types.SwapTokenToTokenAction = {
type: types.TransactionActions.TOKEN_TO_TOKEN_SWAP,
payload: {
to: testPayload,
data: testPayload,
tokenValue: testPayload,
decimal: 1
}
};
expect(transactionFieldsReducer.fieldsReducer(FIELDS_INITIAL_STATE, swapAction)).toEqual({
...FIELDS_INITIAL_STATE,
to: testPayload,
data: testPayload
});
});
it('should reset', () => {
const resetAction: types.ResetTransactionSuccessfulAction = {
type: types.TransactionActions.RESET_SUCCESSFUL,
payload: { isContractInteraction: false }
};
const modifiedState: transactionFieldsTypes.TransactionFieldsState = {
...FIELDS_INITIAL_STATE,
data: { raw: 'modified', value: null }
};
expect(transactionFieldsReducer.fieldsReducer(modifiedState, resetAction)).toEqual(
FIELDS_INITIAL_STATE
);
});
});
describe('Meta', () => {
const META_INITIAL_STATE: transactionMetaTypes.TransactionMetaState = {
unit: '',
previousUnit: '',
decimal: getDecimalFromEtherUnit('ether'),
tokenValue: { raw: '', value: null },
tokenTo: { raw: '', value: null },
from: null,
isContractInteraction: false
};
const testPayload = { raw: 'test', value: null };
it('should handle UNIT_META_SET', () => {
const setUnitMetaAction: transactionMetaTypes.SetUnitMetaAction = {
type: transactionMetaTypes.TransactionMetaActions.UNIT_META_SET,
payload: 'test'
};
expect(transactionMetaReducer.metaReducer(META_INITIAL_STATE, setUnitMetaAction));
});
it('should handle TOKEN_VALUE_META_SET', () => {
expect(
transactionMetaReducer.metaReducer(
META_INITIAL_STATE,
transactionMetaActions.setTokenValue(testPayload)
)
).toEqual({
...META_INITIAL_STATE,
tokenValue: testPayload
});
});
it('should handle TOKEN_TO_META_SET', () => {
expect(
transactionMetaReducer.metaReducer(
META_INITIAL_STATE,
transactionMetaActions.setTokenTo(testPayload)
)
).toEqual({
...META_INITIAL_STATE,
tokenTo: testPayload
});
});
it('should handle GET_FROM_SUCCEEDED', () => {
expect(
transactionMetaReducer.metaReducer(
META_INITIAL_STATE,
transactionNetworkActions.getFromSucceeded('test')
)
).toEqual({
...META_INITIAL_STATE,
from: 'test'
});
});
it('should handle TOKEN_TO_ETHER_SWAP', () => {
const swapAction: types.SwapTokenToEtherAction = {
type: types.TransactionActions.TOKEN_TO_ETHER_SWAP,
payload: {
to: testPayload,
value: testPayload,
decimal: 1
}
};
expect(transactionMetaReducer.metaReducer(META_INITIAL_STATE, swapAction)).toEqual({
...META_INITIAL_STATE,
decimal: swapAction.payload.decimal
});
});
it('should handle ETHER_TO_TOKEN_SWAP', () => {
const swapAction: types.SwapEtherToTokenAction = {
type: types.TransactionActions.ETHER_TO_TOKEN_SWAP,
payload: {
to: testPayload,
data: testPayload,
tokenTo: testPayload,
tokenValue: testPayload,
decimal: 1
}
};
expect(transactionMetaReducer.metaReducer(META_INITIAL_STATE, swapAction)).toEqual({
...META_INITIAL_STATE,
decimal: swapAction.payload.decimal,
tokenTo: testPayload,
tokenValue: testPayload
});
});
it('should handle TOKEN_TO_TOKEN_SWAP', () => {
const swapAction: types.SwapTokenToTokenAction = {
type: types.TransactionActions.TOKEN_TO_TOKEN_SWAP,
payload: {
to: testPayload,
data: testPayload,
tokenValue: testPayload,
decimal: 1
}
};
expect(transactionMetaReducer.metaReducer(META_INITIAL_STATE, swapAction)).toEqual({
...META_INITIAL_STATE,
decimal: swapAction.payload.decimal,
tokenValue: testPayload
});
});
it('should reset', () => {
const resetAction: types.ResetTransactionSuccessfulAction = {
type: types.TransactionActions.RESET_SUCCESSFUL,
payload: { isContractInteraction: false }
};
const modifiedState: transactionMetaTypes.TransactionMetaState = {
...META_INITIAL_STATE,
unit: 'modified'
};
expect(transactionMetaReducer.metaReducer(modifiedState, resetAction)).toEqual(modifiedState);
});
});
describe('Network', () => {
const NETWORK_INITIAL_STATE: transactionNetworkTypes.TransactionNetworkState = {
gasEstimationStatus: null,
getFromStatus: null,
getNonceStatus: null,
gasPriceStatus: null
};
it('should handle gas estimation status actions', () => {
const gasEstimationAction: transactionNetworkTypes.TransactionNetworkAction = {
type: transactionNetworkTypes.TransactionNetworkActions.ESTIMATE_GAS_SUCCEEDED
};
expect(
transactionNetworkReducer.networkReducer(NETWORK_INITIAL_STATE, gasEstimationAction)
).toEqual({
...NETWORK_INITIAL_STATE,
gasEstimationStatus: 'SUCCESS'
});
});
it('should handle get from status actions', () => {
const getFromAction: transactionNetworkTypes.TransactionNetworkAction = {
type: transactionNetworkTypes.TransactionNetworkActions.GET_FROM_SUCCEEDED,
payload: 'test'
};
expect(
transactionNetworkReducer.networkReducer(NETWORK_INITIAL_STATE, getFromAction)
).toEqual({
...NETWORK_INITIAL_STATE,
getFromStatus: 'SUCCESS'
});
});
it('should handle get nonce status actions', () => {
const getNonceAction: transactionNetworkTypes.TransactionNetworkAction = {
type: transactionNetworkTypes.TransactionNetworkActions.GET_NONCE_SUCCEEDED,
payload: 'test'
};
expect(
transactionNetworkReducer.networkReducer(NETWORK_INITIAL_STATE, getNonceAction)
).toEqual({
...NETWORK_INITIAL_STATE,
getNonceStatus: 'SUCCESS'
});
});
it('should handle gasPriceIntent', () => {
const gasPriceAction: transactionFieldsTypes.InputGasPriceAction = {
type: transactionFieldsTypes.TransactionFieldsActions.GAS_PRICE_INPUT,
payload: 'test'
};
expect(
transactionNetworkReducer.networkReducer(NETWORK_INITIAL_STATE, gasPriceAction)
).toEqual({
...NETWORK_INITIAL_STATE,
gasPriceStatus: 'SUCCESS'
});
});
});
describe('Sign', () => {
const SIGN_INITIAL_STATE: transactionSignTypes.TransactionSignState = {
local: { signedTransaction: null },
web3: { transaction: null },
indexingHash: null,
pending: false
};
it('should handle SIGN_TRANSACTION_REQUESTED', () => {
const signTxRequestedAction: transactionSignTypes.SignTransactionRequestedAction = {
type: transactionSignTypes.TransactionSignActions.SIGN_TRANSACTION_REQUESTED,
payload: {} as EthTx
};
expect(transactionSignReducer.signReducer(SIGN_INITIAL_STATE, signTxRequestedAction)).toEqual(
{
...SIGN_INITIAL_STATE,
pending: true
}
);
});
it('should handle SIGN_LOCAL_TRANSACTION_SUCCEEDED', () => {
const signedTransaction = new Buffer('test');
const indexingHash = 'test';
const signLocalTxSucceededAction: transactionSignTypes.SignLocalTransactionSucceededAction = {
type: transactionSignTypes.TransactionSignActions.SIGN_LOCAL_TRANSACTION_SUCCEEDED,
payload: { signedTransaction, indexingHash }
};
expect(
transactionSignReducer.signReducer(SIGN_INITIAL_STATE, signLocalTxSucceededAction)
).toEqual({
...SIGN_INITIAL_STATE,
pending: false,
indexingHash,
local: { signedTransaction }
});
});
it('should handle SIGN_WEB3_TRANSACTION_SUCCEEDED', () => {
const transaction = new Buffer('test');
const indexingHash = 'test';
const signWeb3TxSucceededAction: transactionSignTypes.SignWeb3TransactionSucceededAction = {
type: transactionSignTypes.TransactionSignActions.SIGN_WEB3_TRANSACTION_SUCCEEDED,
payload: { transaction, indexingHash }
};
expect(
transactionSignReducer.signReducer(SIGN_INITIAL_STATE, signWeb3TxSucceededAction)
).toEqual({
...SIGN_INITIAL_STATE,
pending: false,
indexingHash,
web3: { transaction }
});
});
it('should reset', () => {
const resetAction: types.ResetTransactionSuccessfulAction = {
type: types.TransactionActions.RESET_SUCCESSFUL,
payload: { isContractInteraction: false }
};
const modifiedState: transactionSignTypes.TransactionSignState = {
...SIGN_INITIAL_STATE,
pending: true
};
expect(transactionSignReducer.signReducer(modifiedState, resetAction)).toEqual(
SIGN_INITIAL_STATE
);
});
});
});