* add gas limit/price constants
* add gas limit/price validators & selectors
* apply new gas limit/price validation to components and sagas
* create/apply function to sanitize advanced fields input
* add types, update tests
* fix unrelated failing test
* Refactor BaseNode to be an interface INode
* Initial contract commit
* Remove redundant fallback ABI function
* First working iteration of Contract generator to be used in ENS branch
* Hide abi to clean up logging output
* Strip 0x prefix from output decode
* Handle unnamed output params
* Implement ability to supply output mappings to ABI functions
* Fix null case in outputMapping
* Add flow typing
* Add .call method to functions
* Partial commit for type refactor
* Temp contract type fix -- waiting for NPM modularization
* Remove empty files
* Cleanup contract
* Add call request to node interface
* Fix output mapping types
* Revert destructuring overboard
* Add sendCallRequest to rpcNode class and add typing
* Use enum for selecting ABI methods
* Add transaction capability to contracts
* Cleanup privaite/public members
* Remove broadcasting step from a contract transaction
* Cleanup uneeded types
* Refactor ens-base to typescript and add typings for ENS smart contracts
* Migrate ens-name-search to TS
* Add IResolveDomainRequest
* Fix rest of TSC errors
* Add definition file for bn.js
* Remove types-bn
* Fix some typings
* make isBN a static property
* progress commit -- swap out bignumber.js for bn.js
* Swap out bignumber for bn in vendor
* Change modn to number return
* Start to strip out units lib for a string manipulation based lib
* Convert codebase to only base units
* Get rid of useless component
* Handle only wei in values
* Use unit conversion in sidebar
* Automatically strip hex prefix, and handle decimal edge case
* Handle base 16 wei in transactions
* Make a render callback component for dealing with unit conversion
* Switch contracts to use bn.js, and get transaction values from signedTx instead of state
* Get send transaction working with bn.js
* Remove redundant hex stripping, return base value of tokens
* Cleanup unit file
* Re-implement toFixed for strings
* Use formatNumber in codebase
* Cleanup code
* Undo package test changes
* Update snapshot and remove console logs
* Use TokenValue / Wei more consistently where applicable
* Add typing to deterministicWallets, fix confirmation modal, make UnitDisplay more flexible
* Split different ENS modes into their own components
* Fix Abi typedef
* Remove redundant moment type package
* Add Aux helper component
* Split out resolve components
* Make 'to' parameter optional
* Change import type
* Change typing to be base domain request
* Split handling of resolving into object handler
* Fix countdown component
* Adjust element spacing
* Implement reveal search functionality
* Add unit display for highest bidder
* Fill out forbidden/NYA modes
* ENS wallet component skeleton
* Clean up prop handling in UnitDisplay
* Change instanceof to typeof check, change boolean of displayBalance
* Add ENS wallet component
* Cleanup spacing
* Convert ConfModal for bidding in ENS
* Make ui component for placing bids
* Fix destructure in placeBid
* Pass through entire wallet
* Remove text center
* Display inline notification ENS isValid & add some ENS tests
* Add export of Aux
* Reformat with prettier
* progress...
* Add ENSUnlockLayout
* Add RevealBid component
* organize NameResolve components
* Merge ENS with transaction-refactor changes
* Fix address resolution
* Update styles
* convert ens name to lowercase before checking
* Add overflow-y:scroll to table
* update ens snapshots & tests
* cast 'undefined' state argument as any for testing
* clean up components
* Connect unitconverter to redux state
* remove unnecessary type assertion
* fix spinner size
* remove old bidmodal
* validate bidmask before opening modal
* progress...
* Update styles
* Add saga / actions for placing a bid
* Update types & clean up dead code
* Delete old test
* Dispatch PlaceBidRequested acitons
* Progress commit -- get ENS bidding ready for tx generation via sagas
* Seperate ENS action creators and types
* Add reducer & actions for ENS fields
* Add preliminary sagas for bid mask and bid value
* Initial commit
* Add loading indicator
* Remove some bidding components
* Revert bidding files
* Remove more bidding code
* Remove rest of bidding code
* Fix ENS error message
* Revert value saga changes
* Remove error param from setting 'To' field
* Fix existing ENS test
* Cleanup address resolution, remove dead code
* Remove error messages from unimplemented ENS
* Fix last character being not set bug
* Remove error state from Meta
* Rename isGenesisAddress to isCreationAddress
* Check offline status immediately.
* If they start the page offline, show a less severe error message.
* Get rid of offline aware header. Disable wallet options when offline.
* Add online indicator to the header.
* Prevent some components from render, some requests from firing when offline.
* Allow for array of elements with typing.
* Dont show dollars in fee summary when offline.
* Fix up saga tests.
* Fix sidebar component offline styles.
* Remove force offline.
* Dont request rates if offline.
* Nonce in advanced, show even of online.
* Show invalid advanced props.
* Fix up offline poll tests.
1. Attempt an empty password every time a keystore is uploaded.
2. Delegate scrypt decryption (ie ethereumjs-wallet.fromV3) to its own web worker and interface with it through an async typescript function that gets handled in the wallet saga. This keeps the UI unblocked when scrypt takes a long time to decrypt.
3. Add logic to show a spinner x number of milliseconds after file upload so the user will understand when a wallet is being decrypted.
* Use network unit in confirmation modal. Make sure network is set at init.
* Fix token display
* Ensure that when the node changes, the network also changes. Show network unit in unit dropdown.
* Type saga, fix tests.
* progress
* Normalize bity api response
* Filter api response
* Track swap information in component state
* Update dropdown onchange
* remove dead code
* Update Min Max Validation
* Update minmax err msg && fix onChangeOriginKind
* Add origin & destination to redux state
* Update types & Update tests
* Update types
* Update swap.spec.ts test
* Remove commented out code
* Remove hardcoded coin array
* Create types.ts for swap reducer
* Update swapinput type
* Update bityRates in localStorage & Replace all instances of ...Kind / ...Amount props
* Add shapeshift banner
* initial work for sagas
* Update Types
* Update swap reducer initial state
* Update Types & Store empty obj for bityRates / options
* Update more types
* added shapeshift file and rates comments
* action reducers and prop mapping to components
* add typings and swap icon
* more actions reducers and sagas
* debugging shapeshift service
* add Headers
* Fix content type
* add order reset saga and ui fixes
* remove console log and swap b/w Bity and Shapeshift
* working state for Shapeshift and Bity - tested with mainnet
* add icon component
* UI improvements and fix select bug
* fix timer bug
* add bity fallback options and toFixed floats
* tslint errors
* add arrow to dropdown and add support footer
* Add service provider
* fix minor $ bug and stop timer on order complete
* better load UX and dropdown UX
* fixed single test
* currRate prop bugs and reduce LS bloat
* takeEvery on timer saga and don't clear state.options to restartSwap reducer
* export tx sagas and fix minor type
* Add ShapeShift Rates functionality when selecting a ShapeShift pair.
* type fixes
* BugFix: Don't change displayed ShapeShift Rate Inputs on every dropdown change
Also contains some caching / performance improvements
* BugFix: Don't remote rate inputs when falsy amount
* fix type error
* Progress commit
* Implement saga logic
* Make address field factory component
* Shorten debounce time
* Make new actions / sagas for handling single token lookup
* Implement working version of litesend
* Change saga into selector
* Add failing spec
* fix broken test
* add debounce to error message
* fix tests
* update snapshots
* test coverage
* move setState disabled property from debounce so we instantly can go to next step on valid amounts
* much deeper test coverage, fix debounce ux, and fix bity flashing at swap page load
* fix minor failing test
* seperate shapeshift erc20 token whitelist
* fix saveState store bug
* break orderTimeRemaining saga up and rewrite tests
* add new swap icon
* remove unused allowReadOnly prop
* change offlineaware to walletdecrypt for litesend
* fix LiteSend changewallet bug
* fix error message UX
* fix button styling to match develop
* fix liteSend test
* Fix LiteSend UX on unavl tokens, dropdown null value, and don't show decrypt in litesend after successful wallet decrypt.
* add litesend network check
* Initial work at splitting out generate into two flows.
* Finish mnemonic flow.
* Convert keystore to state-based component. Remove all redux generate stuff. Remove generate help section. Fix styles.
* Add back button, switch to routing instead of state for generate pages.
* PR feedback.
* Alertify warning at generate. Linkify alternatives. Fix some alert link styles.
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
* Initialize with no requested currencies, so that the initial request always fires.
* Adjust tokens with different decimals for equivalent values.
* Reuse libs units function.
* Create lib function and tests for base conversion behavior.
* improve derivation-checking performance by batching docker calls; move into spec dir
* remove npm command to run derivation-checking; create 'int-test' (integration) command and hook up into jest
* add integration testing to CI; configure docker / docker image (dternyak/eth-priv-to-addr) in CI
* docker build -> docker pull
* use travis build matrix to group tests and improve build times
* remove int-test call
* attempt travis 'job' with all tests running in parallel
* remove typo
* attempt travis 'job' with all tests running in parallel (round 2)
* organize integration tests
* refactor/cleanup
* refactor/address comments
* setup components, reducers, actions, and added routes
* removed redux, using local state and ethereumjs-wallet
* added validation and state reset
* added visibility options and changed btn colors
* updated isValidPrivKey and updated some components to stateless functional comp
* componentize input and add placeholder message
* removed cn from KeystoreDetails
* adds isValidPrivate to buffer check and min pw length to 0
* remove packagelock to fix merge conflict
* added utilities tab removed keystore tab
* adds fixpkey in validators and uses it across two components
* added checksum removal and btn css fixes
* Fixed en.json formatting - also removed fixedPkey
* Added unit tests for isValidPrivKey
* add runtime checks and rename stripHexPrefix to strippedPrivateKey
* switch back to stripHexPrefix
* Add constant for n-factor
* enforce 9 char minimum
* create ensureOkResponse and check against RPC responses
* Merge with develop branch
* added single unit test
* main nodes added
* getBalance method
* remove console.log
* minor conflict fix - readd polyfill to integration test
* added two more method tests
* seperate rpcnode from extended classes
* fixes etherscan
* added all tests
* revert files with only formatting changes
* remove console.logs - still need to update snapshot before tests will pass
* updated snapshot due to RpcNode fixes for Infura and Etherscan nodes
* added RpcNodeTest config so we don't rely on constants in code
* undo formatting changes
* Multiple fixes to error handling tokens.
* Fixed TSC errors
* Minor styling edit - change async func to promise
* changed shape of tokenBalances
* change balance type back to stricter TokenValue type
* remove package.json change and include test for error state.
* minor change removing unneeded line of code
* added longer timeout for api
* update snapshot
* Layed out components for custom nodes.
* Outline of custom nodes. Still missing various features and error handling.
* Persist custom nodes to local storage.
* Make custom nodes removable.
* Add latest block functions, call it when switching nodes.
* Initialize correct node, move node utils into utils file.
* Fix names
* Send headers along with rpc requests.
* Remove custom network options for now.
* PR feedback.
* One last log.
* Fix tests.
* Headers in batch too.
* Switch to node when you add it.
* Reduce hackery.
* Clean up linter and tsc.
* Fix latest block hex conversion.
* Unit tests.
* Fix missing property.
* Fix Modal title typing.
* Fetch all token rates at once. Add option for displaying all token values.
* Ensure spinner always shows before equivalent values are ready.
* Fix up test.
* Add definition file for bn.js
* Remove types-bn
* make isBN a static property
* progress commit -- swap out bignumber.js for bn.js
* Swap out bignumber for bn in vendor
* Change modn to number return
* Start to strip out units lib for a string manipulation based lib
* Convert codebase to only base units
* Get rid of useless component
* Handle only wei in values
* Use unit conversion in sidebar
* Automatically strip hex prefix, and handle decimal edge case
* Handle base 16 wei in transactions
* Make a render callback component for dealing with unit conversion
* Switch contracts to use bn.js, and get transaction values from signedTx instead of state
* Get send transaction working with bn.js
* Remove redundant hex stripping, return base value of tokens
* Cleanup unit file
* Re-implement toFixed for strings
* Use formatNumber in codebase
* Cleanup code
* Undo package test changes
* Update snapshot and remove console logs
* Use TokenValue / Wei more consistently where applicable
* Add typing to deterministicWallets, fix confirmation modal, make UnitDisplay more flexible
* Clean up prop handling in UnitDisplay
* Change instanceof to typeof check, change boolean of displayBalance
* Fix tsc errors
* Fix token row displaying wrong decimals
* Fix deterministic modal token display
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Progress commit -- ethereumjs-wallet typings
* Add hdkey module + better wallet typing
* Add provider-engine typings
* Add jsdoc descriptions for hdkey constructor methods
* Fix missing return type
* Fix another missing return
* Make provider engine options optional
* Add priv/pubkey members to wallet instance
* Turn into SFC + Use ethereumjs-lib
* Use proper interface naming for V3Wallet
* Switch to ethereumjs-wallet
* Switch to ethereumjs-wallet and refactor using NewTabLink
* Use proper interface naming for V3Wallet
* Use proper interface naming for PublicKeyOnlyWallet
* Strip out wallet classes for ethereumjs-wallet, stuff wallet types in privkey for now
* Seperate wallets into deterministic and non-deterministic, change IWallet and deterministic wallets to adhere to getAddressString
* Fix broken test, remove scryptsy
* Fix broken test, re-add scryptsy to make this PR pass
* Remove uuid from deps and keystore test
* Add ethereumjs-wallet to DLL
* Wrap mnemonic wallet
* Fix definition module for thirdparty wallets
* Fix MewV1 wallet not loading due to wrong library
* Fix tsc error
* Decrease n-factor to 1024, checksum address of keystore
* Fix isKeystorePassRequired
* Fix tsc errors
* Merge package lock
* Update package lock
* regenerate lock file
* Lock typescript to 2.5.2
* Merge develop
* add route and nav tab for new module
* add new module to tabs index
* add signMessage to wallet interface
* add signed message verification, normalize pkey sign
* init Sign & Verify Message tab
* reorder imports
* mock out Trezor
* cast to bool instead of length check
* normalize ledger sign message
* fix broken this context
* add commented message signing to trezor wallet
* correct var to start on sign tab
* remove unused state var
* clean up SignMessage classes
* clean up VerifyMessage classes, remove unnecessary log
* correct event variable types
* remove unnecessary exports
* remove empty classname
* use implicit return
* shorten signMessage method
* remove unnecessary disable
* tweak variable name
* make better use of destructuring, remove console log
* use destructured var
* flatten if statement
* add signMessage method to wallet reducer test
* offline-send mvp
* cleanup unneeded imports
* - create pollOfflineStatus action, action creator, interface
* expand UnlockHeader when collapse-button is clicked, instead of div
* kick-off pollOfflineStatus upon SendTransaction mount.
* Create sagas for polling offline status
* remove comment
* - create CONFIG_FORCE_OFFLINE action, action creator, interface
* Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline.
* - Assume offline in SendTransaction when either offline or forcedOffline
* - handle forceOffline action in reducer
- adjust state type / provide default state for forceOffline in config reducer
* adjust test to pass with different key name
* fix incorrect import
* - allow size to be specified in offline toggle
* - Decode and display nonce in confirmation modal
* - set default nonces when forced offline and have online connectivity based on transaction count
- pass nonce to generateCompleteTransaction
- refactor componentDidUpdate
* Allow optional nonce to be passed to generateCompleteTransaction
* - create stripHexPrefix function
* - cleanup sagas
* move getParam into helper util
* update address on component update
* - show spinner while transaction is being signed
- reset state when wallet instance changes (new wallet instantiated via UnlockHeader)
* center-align offline message
* Adjust force offline/online button text
* - validate nonces when offline
- only estimate gas when online
- don't show send tx button when offline
* - break generateCompleteTransactionFromRawTransaction into multiple functions.
- support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation.
* Create Help component (to be used as a tooltip)
* Disable hardware wallets when offline.
* Hide Send Entire Balance when balance is falsy
* Show help icon in nonce field.
* - show helper instructions on how to broadcast when user is offline after generating a tx
- hardcoded gas limits when offline
- refactors
* create isPositiveInteger helper function
* fix nonce validation
* really fix nonce validation (specifically the input highlighting)
* remove stray // @flow's
* remove offline tab nav
* remove unused action arg
* address PR comments