* Add a new route for AddressBook
* Further templating of the AddressBook view
* Add initial functionality to handle a table of existing address labels
* Make the linter happy
* Adjust paths
* Factor out TableRow and add common functionality
* Add initial Redux boilerplate for addressBook | fix minor linting issues
* Swap out terminology and types
* Connect up to Redux
* Connect data for AddressBookTable to Redux
* Use temporary fields for addition
* Remove alignment and index column
* Stopping point
* Adjust the sizing of rows to be consistent
* Initial implementation of a dropdown for the address field
* Minor styling to dropdown
* Stopping point
* Apply a focus concept onto the factory
* Add keyboard controls for the address field dropdown
* Adjust label of address field when it matches an addressBook entry
* Properly handle attempting to blur a non-existent component
* Minor styling changes on dropdown box
* Standardize address casing, add accessibility to dropdown
* Create an addressLabel component
* Pass refs correctly and fix some typings
* Exact version
* Add module name mapping for shared/keycodes
* addressBook reducer tests
* Add functionality to DeterministicModal
* Minor changes / Add test for addressBook selectors
* Move out AddressBookTable to a component
* Typing, translation and restructuring
* More typing and translation fixes
* More linting fixes
* More type changes
* Variable name for dropdown background
* Fix TS type errors, lint errors, remove unused props
* Used a different selector and removed method: AddressBookTable
* Linter was mad
* Linter mad again :(
* Add a translation and adjust styling of AddressBookTable
* Move the onBlur to a class method
* Prevent the default behavior of up/down/enter for dropdown
* Let's do it this way instead
* Adjust the styling on DeterministicWalletModal labels
* Change `AddressBookTable` into a pseudo-table using section and div
* Use readable keys vs. keycodes
* Put the dropdown in InputFactory and position it correctly
* Sanitation of label adding and changing
* Prevent duplicate labels in AddressBook and Row
* Add a box shadow and use `invalid` class insted of custom
* Use emphasis vs strong for address in dropdown
* Display the label undernearth the input vs. changing it
* Isolate AccountAddress into its own component
* Introduce interactivity to AccountAddress
* Fully incorporate with Redux
* Validation for AccountAddress
* Add validation notifications for address field on AddressBookTable
* Minor formatting
* Adjust wrappage for optimal flexboxxing
* Make AddressBookTable responsive
* Show an invalid input in "real time" instead of only on submit
* Real time input validation for AddressBookTableRow
* Responsive-ize the To address dropdown
* Hide identicons instead at small enough screen sizes
* Fix repsonsiveness of dropdown further
* Fix responsiveness of table rows and inputs
* Truncate account info and switch identicons to the right for consistency
* Use classnames instead of targetting element directly for DWM
* Display a notice if the entered query doesnt match a label and isnt an addr
* Don't show an error on the To address if its a label entry
* Display an error under AddressBookTableRow in real time
* Display errors in real time for AddressBookTable temp inputs
* Add realtime validation to AccountAddress
* Ensure toChecksumAddress is used when entering labels to address manager
* Show errors even after blurring.
* Only show errors on address/label entry if they have been blurred
* On certain inputs, show an invalid input immediately
* Add displayed errors for labels with 0x and labels containing ens
* Move ENS checking validation out
* Add a saga for addLabelForAddress
* Completely revamp the redux side of Address Manager and test it all
* Adjust components to use new redux addressBook
* Incorporate new redux into AddressBookTableRow and clean up for linter
* Make linter and tests happy
* Another reduxy overhaul
* Still fixing it
* More redux updates
* Finalize redux stuff.
* Incorporate new reduxy way into AddressBookTable & Row
* Incorporate redux changes into Account Address
* Small tests fix
* Add and fix some selector tests
* Addressing Will's comments
* Shortened visibility class for line length reasons.
* Fix#1569
* Use common component for handling "to" address
* If to address becomes invalid, hide contract interact explorer
* Add IS_CONTRACT_INTERACTION mode - fix bugs related to contract interact
* Bump shepherd version to fix bugs related to metamask + network switches
* Update mycrypto link downloads
* Update facebook link
* Remove console log from checktx
* Fix dollar sign on contract address in conf modal
* Fix unchecksummed address for metamask signing
* Cleanup unused classname
* Update generate keystore file description to be correct
* Add space to create new wallet banner
* Remove extra variable
* Do checksumming in library function instead of component
* Clear state on address change
* Parity Signer Squashed
* ParitySigner to be a container
* Parity Signer: style and polish
* target blank on appstore links
* PR fixes
* Move QrSignerModal to SendTransaction container
* Rework redux, use signing saga
* Cleanup
* Use new logo, change helpLink
* Rework finalize actions and types a bit
* Webcam info + wiki link on unlock screen
* Make the Parity QR Signer its own component, that has error messaging and ismore robust about adding / removing cameras.
* Unneded l10n
* Remove title from account, tighten buttons and subtabs.
* Send everything button in input.
* Request tx to full width, adjust transaction fee spacing.
* Fix token balances button spacing.
* Fix address identicon flying offscreen. Tighten up identicon, show border even when theres no identicon.
* Add isSelfAddress boolean to AddressField, use it on WalletInfo tab.
* Use short amount again.
* Unused
* Update account view routing
* Temporarily add unicode character to translated strings for testing
* Temporarily select add unicode to all untranslated strings
* Format changes
* Add all english translations for /account & /generate
* Add the rest of the english translations
* Add a few more missing translations
* Update en translations
* Get selectedLanguage from localstorage instead of redux sttate
* Update snapshots
* Add missing translation keys & Update translate functs & change variable prefix
* translate all markdown strings & remove old translation strings
* Update snapshot
* Add a few more translation strs
* Move raw strings being translated into json
* All translation keys are now Uppercase
* Fix up the last few translations
* Update snapshot
* Uppercase de translation strings
* Bring back shapeshift logo on swap
* Fix contracts tab translations
* Fix a few more translations
* Fix translations
* remove debugging stuff
* Update snapshots
* Use react.fragment as markdown root renderer
* Seperate markdown translations into their own function
* Clean up translation functions
* Clean up translation functions
* Update snapshot
* Fix some broken translation strings
* Add prettier ignore file
* Save transactions to local storage.
* Checksum more things + reset hash on network change.
* Fix IHexTransaction type, grab from from tx object directly.
* Refactor storage of recent transactions to use redux storage and loading.
* Refactor types to a transactions types file.
* Initial crack at recent transactions tab on account
* Punctuation.
* Transaction Status responsive behavior.
* Refactor transaction helper function out to remove circular dependency.
* Fix typings
* Collapse subtabs to select list when too small.
* s/wallet/address
* Type select onChange
* Get fields from current state if web3 tx
* Allow zero number
* Fail when request payment is zero value, or if you try to send token with zero value.
* Parseint instead of addition casting to catch empty string.
* Set default unit to 'ETH' instead of 'ether'
* Use 'isEtherUnit()' everywhere
* Set default unit to empty string
* Update isEthUnit to isNetworkUnit
* Fix unit conversion for non-ethereum networks
* Set default network unit properly
* Fix tests
* fix typos
* Update isNetworkUnit selector
* Update isNetworkUnit
* Fix validationhelpers tests
* Add mock state to tests & Move isNetworkUnit to selectors
* Fix validation helper spec
* fix unit swap spec
* Start splitting networks into their own reducers
* Split out nodes and networks into their own reducers
* Cleanup file structure
* Make selectors for new state
* Change custom network typing
* re-type repo
* Fix up components to use selectors, work on fixing sagas
* Provide consistency in naming, fix more sagas
* Get non web3 node switching working
* Split config rehydration off into a different file for store
* Inline auth for custom nodes
* Include typing for app state
* moar selectors
* Get web3 working + cleanup sagas
* Cleanup tsc errors
* Use forof loop instead of foreach for clearing pruning custom networks
* Add reducer tests for new redux state
* Export needed variables
* Add console error
* Remove old comment
* Work on saga tests
* Get passing existing saga tests
* Fix more tests
* Remove irrlevant tests
* add console error
* Get rest of tests passing
* Fix merge errors
* Remove random text
* Fix store saving
* Fix selector lib only grabbing from static nodes
* Fix custom node removal crashing app
* Infer selected network via node
* Prune custom networks properly on node removal
* Infer network name from chainid from selecting state
* Cleanup tsc errors
* Remove MEW nodes for main and testnet
* Transfer query arguments over with routing.
* Create a Query Redirect wrapper.
* Add RedirectWithQuery component to SendTransaction index redirect.
* Correct hash-query ordering.
* PureComponent a ton of non-connected components.
* Debounce gas price slider. Keep gas price in state to reflect changes immediately.
* PureComponent balance sidebar and swap unconnected components.
* Import correct component.
* Move debouncing of gas slider to sagas via gasPriceInputIntent action.
* Remove console log.
* Remove leftover file from merge.
* Create reusable password toggle component, convert private key and mnemonic to it.
* Convert keystore modal to togglable password.
* Remove the restore keystore tab code (defunct).
* Replace wallet info with togglable password. Allow for controlled togglable password.
* Convert last password component (generate) and cleanup unneeded files and styles.
* Insecure wallet blocker warning before unlocking insecure wallet.
* Wrap in quotes to avoid prettier error.
* Make account the homepage. Add a link to generate on the wallet unlock component.
* Fix send routing weirdness.
* Check offline status immediately.
* If they start the page offline, show a less severe error message.
* Get rid of offline aware header. Disable wallet options when offline.
* Add online indicator to the header.
* Prevent some components from render, some requests from firing when offline.
* Allow for array of elements with typing.
* Dont show dollars in fee summary when offline.
* Fix up saga tests.
* Fix sidebar component offline styles.
* Remove force offline.
* Dont request rates if offline.
* Nonce in advanced, show even of online.
* Show invalid advanced props.
* Fix up offline poll tests.
* Initial crack at simple only gas slider component.
* Work on advanced component. Refactor redux and components to specify gas limit vs price.
* Convert fee summary to a render cbesque thing.
* Rework responsive columns.
* Remove force offline button.
* Tweak styles.
* Fix tscheck issues, remove unneeded prop.
* Fix references to GasField
* Gas slider in lite send.
* Make gas slider network-aware for symbol and price calculation.
* progress
* Normalize bity api response
* Filter api response
* Track swap information in component state
* Update dropdown onchange
* remove dead code
* Update Min Max Validation
* Update minmax err msg && fix onChangeOriginKind
* Add origin & destination to redux state
* Update types & Update tests
* Update types
* Update swap.spec.ts test
* Remove commented out code
* Remove hardcoded coin array
* Create types.ts for swap reducer
* Update swapinput type
* Update bityRates in localStorage & Replace all instances of ...Kind / ...Amount props
* Add shapeshift banner
* initial work for sagas
* Update Types
* Update swap reducer initial state
* Update Types & Store empty obj for bityRates / options
* Update more types
* added shapeshift file and rates comments
* action reducers and prop mapping to components
* add typings and swap icon
* more actions reducers and sagas
* debugging shapeshift service
* add Headers
* Fix content type
* add order reset saga and ui fixes
* remove console log and swap b/w Bity and Shapeshift
* working state for Shapeshift and Bity - tested with mainnet
* add icon component
* UI improvements and fix select bug
* fix timer bug
* add bity fallback options and toFixed floats
* tslint errors
* add arrow to dropdown and add support footer
* Add service provider
* fix minor $ bug and stop timer on order complete
* better load UX and dropdown UX
* fixed single test
* currRate prop bugs and reduce LS bloat
* takeEvery on timer saga and don't clear state.options to restartSwap reducer
* export tx sagas and fix minor type
* Add ShapeShift Rates functionality when selecting a ShapeShift pair.
* type fixes
* BugFix: Don't change displayed ShapeShift Rate Inputs on every dropdown change
Also contains some caching / performance improvements
* BugFix: Don't remote rate inputs when falsy amount
* fix type error
* Progress commit
* Implement saga logic
* Make address field factory component
* Shorten debounce time
* Make new actions / sagas for handling single token lookup
* Implement working version of litesend
* make unit dropdown searchable, add props for all tokens, custom validation
* add string generators for EIP 681 token & ether transactions
* add new selectors
* add request payment tab
* Change saga into selector
* Add failing spec
* fix broken test
* add debounce to error message
* fix tests
* update snapshots
* test coverage
* move setState disabled property from debounce so we instantly can go to next step on valid amounts
* reset amount value (useful for switching between tabs)
* much deeper test coverage, fix debounce ux, and fix bity flashing at swap page load
* fix minor failing test
* seperate shapeshift erc20 token whitelist
* fix saveState store bug
* break orderTimeRemaining saga up and rewrite tests
* fix tslint error
* add isReadOnly prop to address field
* use AddressField component, add additional validation
* make prop optional
* correct validation
* allow for request tab to be used with view only wallet
* account for undefined activeTab
* add types
* Reorganize files to better match other components.
* Initial UI for wallet buttons.
* Fix leftover rebase conflict.
* Wallet selection, styling, mobile handling.
* Initial work on animations.
* Adjusted animations.
* Adjust wallet unlock forms to be more uniform. Fix view address saying 'unlock'
* Adjust tooltips.
* Fix embedded decrypt components.
* Cover whole sign msg form with decrypt.
* Give deploy contract a better unlock treatment like sign msg.
* Reset decrypt component on hide / show
* Unused var
* Fix tooltip hover.
* Fix hover lift.
* Make spacing better on mobile.
* Back button mobile handling.
* Redesign mobile button icons. Prevent clicking through when clicking on icons.
* TSCheck fixes.
* Attempt to unlock MetaMask onClick, and provide existing flow with notification when unlock fails.
* Get rid of outline.
* Remove decrypt min height. Make view only textarea.
* Add change wallet buttons to deploy contract and sign msg.
* Standardize
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
* Check in.
* Add read only wallet and new types for that. Convert some components to require full wallet.
* Fix readonly property, fix uncaught throw.
* Disable address only on some tabs.
* Use FullWalletOnly render callback to handle signing.
* Work around uncertain wallet type.
* Fix function args.
* Undo bug fix that should be done in another branch.
* Disable button while address is bad.
* Remove log.
* Convert anonymous functions to class functions.
* Add definition file for bn.js
* Remove types-bn
* make isBN a static property
* progress commit -- swap out bignumber.js for bn.js
* Swap out bignumber for bn in vendor
* Change modn to number return
* Start to strip out units lib for a string manipulation based lib
* Convert codebase to only base units
* Get rid of useless component
* Handle only wei in values
* Use unit conversion in sidebar
* Automatically strip hex prefix, and handle decimal edge case
* Handle base 16 wei in transactions
* Make a render callback component for dealing with unit conversion
* Switch contracts to use bn.js, and get transaction values from signedTx instead of state
* Get send transaction working with bn.js
* Remove redundant hex stripping, return base value of tokens
* Cleanup unit file
* Re-implement toFixed for strings
* Use formatNumber in codebase
* Cleanup code
* Undo package test changes
* Update snapshot and remove console logs
* Use TokenValue / Wei more consistently where applicable
* Add typing to deterministicWallets, fix confirmation modal, make UnitDisplay more flexible
* Clean up prop handling in UnitDisplay
* Change instanceof to typeof check, change boolean of displayBalance
* Fix tsc errors
* Fix token row displaying wrong decimals
* Fix deterministic modal token display
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Progress commit -- ethereumjs-wallet typings
* Add hdkey module + better wallet typing
* Add provider-engine typings
* Add jsdoc descriptions for hdkey constructor methods
* Fix missing return type
* Fix another missing return
* Make provider engine options optional
* Add priv/pubkey members to wallet instance
* Turn into SFC + Use ethereumjs-lib
* Use proper interface naming for V3Wallet
* Switch to ethereumjs-wallet
* Switch to ethereumjs-wallet and refactor using NewTabLink
* Use proper interface naming for V3Wallet
* Use proper interface naming for PublicKeyOnlyWallet
* Strip out wallet classes for ethereumjs-wallet, stuff wallet types in privkey for now
* Seperate wallets into deterministic and non-deterministic, change IWallet and deterministic wallets to adhere to getAddressString
* Fix broken test, remove scryptsy
* Fix broken test, re-add scryptsy to make this PR pass
* Remove uuid from deps and keystore test
* Add ethereumjs-wallet to DLL
* Wrap mnemonic wallet
* Fix definition module for thirdparty wallets
* Fix MewV1 wallet not loading due to wrong library
* Fix tsc error
* Decrease n-factor to 1024, checksum address of keystore
* Fix isKeystorePassRequired
* Fix tsc errors
* Merge package lock
* Update package lock
* regenerate lock file
* Lock typescript to 2.5.2
* Merge develop
Connor Bryan
HenryNguyen5
Daniel Kmak
William O'Beirne
Maciej Hirsz
Daniel Ternyak
James Prado
aitrean
Danny Skubak
greenkeeper[bot]