diff --git a/common/components/TransactionStatus/TransactionDataTable.tsx b/common/components/TransactionStatus/TransactionDataTable.tsx index 07d015e8..ff9cd069 100644 --- a/common/components/TransactionStatus/TransactionDataTable.tsx +++ b/common/components/TransactionStatus/TransactionDataTable.tsx @@ -78,7 +78,7 @@ const TransactionDataTable: React.SFC = ({ data, receipt, network }) => { {statusSeeMore && explorer.tx && !network.isCustom && ( - + (See more on {network.blockExplorer.name}) )} diff --git a/common/components/ui/ColorDropdown.scss b/common/components/ui/ColorDropdown.scss index 4f0a8211..8d061712 100644 --- a/common/components/ui/ColorDropdown.scss +++ b/common/components/ui/ColorDropdown.scss @@ -2,7 +2,7 @@ &-item { position: relative; padding-right: 10px; - border-left: 2px solid; + border-left: 2px solid #fff; &-remove { position: absolute; diff --git a/common/components/ui/HelpLink.tsx b/common/components/ui/HelpLink.tsx index ddf4eac8..9c948358 100644 --- a/common/components/ui/HelpLink.tsx +++ b/common/components/ui/HelpLink.tsx @@ -8,7 +8,7 @@ interface Props { } const HelpLink: React.SFC = ({ article, children, ...rest }) => ( - + {children} ); diff --git a/common/components/ui/OldDropdown.tsx b/common/components/ui/OldDropdown.tsx index 975e30e5..9e0259df 100644 --- a/common/components/ui/OldDropdown.tsx +++ b/common/components/ui/OldDropdown.tsx @@ -61,7 +61,7 @@ export default class DropdownComponent extends PureComponent, State> }); const searchableStyle = { maxHeight: '300px', - overflowY: 'auto' + overflowY: 'auto' as 'auto' }; const searchRegex = new RegExp(search, 'gi'); const onSearchChange = (e: React.FormEvent) => { @@ -69,7 +69,7 @@ export default class DropdownComponent extends PureComponent, State> }; return ( -
    +
      {searchable && ( ({ ...state, diff --git a/common/reducers/config/networks/index.ts b/common/reducers/config/networks/index.ts index 9c0a2760..d5d601a5 100644 --- a/common/reducers/config/networks/index.ts +++ b/common/reducers/config/networks/index.ts @@ -1,6 +1,7 @@ -import { customNetworks, State as CustomNetworksState } from './customNetworks'; -import { staticNetworks, State as StaticNetworksState } from './staticNetworks'; import { combineReducers } from 'redux'; +import { customNetworks } from './customNetworks'; +import { staticNetworks } from './staticNetworks'; +import { StaticNetworksState, CustomNetworksState } from './types'; interface State { customNetworks: CustomNetworksState; diff --git a/common/reducers/config/networks/staticNetworks.ts b/common/reducers/config/networks/staticNetworks.ts index 7843c327..f047ee24 100644 --- a/common/reducers/config/networks/staticNetworks.ts +++ b/common/reducers/config/networks/staticNetworks.ts @@ -16,9 +16,8 @@ import { UBQ_DEFAULT } from 'config/dpaths'; import { ConfigAction } from 'actions/config'; -import { StaticNetworkIds, StaticNetworkConfig, BlockExplorerConfig } from 'types/network'; - -export type State = { [key in StaticNetworkIds]: StaticNetworkConfig }; +import { BlockExplorerConfig } from 'types/network'; +import { StaticNetworksState as State } from './types'; // Must be a website that follows the ethplorer convention of /tx/[hash] and // address/[address] to generate the correct functions. diff --git a/common/reducers/config/networks/types.ts b/common/reducers/config/networks/types.ts new file mode 100644 index 00000000..801485f1 --- /dev/null +++ b/common/reducers/config/networks/types.ts @@ -0,0 +1,10 @@ +// Moving state types into their own file resolves an annoying webpack bug +// https://github.com/angular/angular-cli/issues/2034 +import { StaticNetworkIds, StaticNetworkConfig, CustomNetworkConfig } from 'types/network'; + +export type StaticNetworksState = { [key in StaticNetworkIds]: StaticNetworkConfig }; + +// TODO: this doesn't accurately represent custom networks state +export interface CustomNetworksState { + [customNetworkId: string]: CustomNetworkConfig; +} diff --git a/common/reducers/config/nodes/customNodes.ts b/common/reducers/config/nodes/customNodes.ts index f424af1b..12a1e176 100644 --- a/common/reducers/config/nodes/customNodes.ts +++ b/common/reducers/config/nodes/customNodes.ts @@ -4,11 +4,7 @@ import { AddCustomNodeAction, RemoveCustomNodeAction } from 'actions/config'; -import { CustomNodeConfig } from 'types/node'; - -export interface State { - [customNodeId: string]: CustomNodeConfig; -} +import { CustomNodesState as State } from './types'; const addCustomNode = (state: State, { payload }: AddCustomNodeAction): State => ({ ...state, diff --git a/common/reducers/config/nodes/index.ts b/common/reducers/config/nodes/index.ts index 07fdebea..2c5ab672 100644 --- a/common/reducers/config/nodes/index.ts +++ b/common/reducers/config/nodes/index.ts @@ -1,7 +1,8 @@ -import { customNodes, State as CustomNodesState } from './customNodes'; -import { staticNodes, State as StaticNodesState } from './staticNodes'; -import { selectedNode, State as SelectedNodeState } from './selectedNode'; import { combineReducers } from 'redux'; +import { customNodes } from './customNodes'; +import { staticNodes } from './staticNodes'; +import { selectedNode } from './selectedNode'; +import { CustomNodesState, StaticNodesState, SelectedNodeState } from './types'; interface State { customNodes: CustomNodesState; diff --git a/common/reducers/config/nodes/selectedNode.ts b/common/reducers/config/nodes/selectedNode.ts index 6d69e6e7..9b468c19 100644 --- a/common/reducers/config/nodes/selectedNode.ts +++ b/common/reducers/config/nodes/selectedNode.ts @@ -6,20 +6,9 @@ import { RemoveCustomNodeAction, CustomNodeAction } from 'actions/config'; +import { SelectedNodeState as State } from './types'; -interface NodeLoaded { - pending: false; - nodeId: string; -} - -interface NodeChangePending { - pending: true; - nodeId: string; -} - -export type State = NodeLoaded | NodeChangePending; - -export const INITIAL_STATE: NodeLoaded = { +export const INITIAL_STATE: State = { nodeId: 'eth_mycrypto', pending: false }; diff --git a/common/reducers/config/nodes/staticNodes.ts b/common/reducers/config/nodes/staticNodes.ts index 3787a8f4..63bb6cac 100644 --- a/common/reducers/config/nodes/staticNodes.ts +++ b/common/reducers/config/nodes/staticNodes.ts @@ -1,8 +1,6 @@ import { EtherscanNode, InfuraNode, RPCNode } from 'libs/nodes'; import { TypeKeys, NodeAction } from 'actions/config'; -import { NonWeb3NodeConfigs, Web3NodeConfigs } from 'types/node'; - -export type State = NonWeb3NodeConfigs & Web3NodeConfigs; +import { StaticNodesState as State } from './types'; export const INITIAL_STATE: State = { eth_mycrypto: { diff --git a/common/reducers/config/nodes/types.ts b/common/reducers/config/nodes/types.ts new file mode 100644 index 00000000..fa2afa71 --- /dev/null +++ b/common/reducers/config/nodes/types.ts @@ -0,0 +1,21 @@ +// Moving state types into their own file resolves an annoying webpack bug +// https://github.com/angular/angular-cli/issues/2034 +import { NonWeb3NodeConfigs, Web3NodeConfigs, CustomNodeConfig } from 'types/node'; + +export interface CustomNodesState { + [customNodeId: string]: CustomNodeConfig; +} + +interface NodeLoaded { + pending: false; + nodeId: string; +} + +interface NodeChangePending { + pending: true; + nodeId: string; +} + +export type SelectedNodeState = NodeLoaded | NodeChangePending; + +export type StaticNodesState = NonWeb3NodeConfigs & Web3NodeConfigs; diff --git a/common/sagas/transaction/broadcast/helpers.tsx b/common/sagas/transaction/broadcast/helpers.tsx index bacb0ae3..c97a9f82 100644 --- a/common/sagas/transaction/broadcast/helpers.tsx +++ b/common/sagas/transaction/broadcast/helpers.tsx @@ -79,7 +79,7 @@ export function* shouldBroadcastTransaction(indexingHash: string): SagaIterator } return true; } -export function* getSerializedTxAndIndexingHash({ type }: BroadcastRequestedAction) { +export function* getSerializedTxAndIndexingHash({ type }: BroadcastRequestedAction): SagaIterator { const isWeb3Req = type === TK.BROADCAST_WEB3_TRANSACTION_REQUESTED; const txSelector = isWeb3Req ? getWeb3Tx : getSignedTx; const serializedTransaction: StateSerializedTx = yield select(txSelector); diff --git a/common/sagas/transaction/signing/helpers.ts b/common/sagas/transaction/signing/helpers.ts index 8281be0d..9d9f8812 100644 --- a/common/sagas/transaction/signing/helpers.ts +++ b/common/sagas/transaction/signing/helpers.ts @@ -39,7 +39,9 @@ const signTransactionWrapper = (func: (IWalletAndTx: IFullWalletAndTransaction) * the rest of the tx parameters from the action * @param partialTx */ -function* getWalletAndTransaction(partialTx: SignTransactionRequestedAction['payload']) { +function* getWalletAndTransaction( + partialTx: SignTransactionRequestedAction['payload'] +): SagaIterator { // get the wallet we're going to sign with const wallet: null | IFullWallet = yield select(getWalletInst); if (!wallet) { diff --git a/package.json b/package.json index 802a4e27..849338cb 100644 --- a/package.json +++ b/package.json @@ -22,7 +22,6 @@ "ethereumjs-util": "5.1.5", "ethereumjs-wallet": "0.6.0", "font-awesome": "4.7.0", - "hard-source-webpack-plugin": "0.5.16", "hdkey": "0.8.0", "idna-uts46": "1.1.0", "jsonschema": "1.2.2", @@ -76,11 +75,7 @@ "@types/uuid": "3.4.3", "@types/webpack-env": "1.13.4", "@types/zxcvbn": "4.4.0", - "autodll-webpack-plugin": "0.3.8", - "awesome-typescript-loader": "3.5.0", - "babel-minify-webpack-plugin": "0.3.0", - "bs58": "4.0.1", - "cache-loader": "1.2.2", + "autodll-webpack-plugin": "0.3.9", "check-node-version": "3.2.0", "concurrently": "3.5.1", "copy-webpack-plugin": "4.5.1", @@ -92,47 +87,44 @@ "enzyme-adapter-react-16": "1.1.1", "enzyme-to-json": "3.3.3", "express": "4.16.2", - "extract-text-webpack-plugin": "3.0.2", "favicons-webpack-plugin": "0.0.8", "file-loader": "1.1.11", "friendly-errors-webpack-plugin": "1.6.1", - "glob": "7.1.2", - "hoist-non-react-statics": "2.5.0", - "html-webpack-plugin": "3.0.3", + "hard-source-webpack-plugin": "0.6.4", + "html-webpack-plugin": "3.0.6", "husky": "0.14.3", "image-webpack-loader": "4.2.0", "jest": "22.1.4", "klaw-sync": "3.0.2", "lint-staged": "7.0.0", + "mini-css-extract-plugin": "0.2.0", "minimist": "1.2.0", "node-sass": "4.8.3", "nodemon": "1.17.2", "null-loader": "0.1.1", "prettier": "1.11.1", - "progress": "2.0.0", - "react-hot-loader": "3.1.3", - "react-test-renderer": "16.2.0", + "react-hot-loader": "4.0.0", "redux-devtools-extension": "2.13.2", "redux-test-utils": "0.2.2", - "resolve-url-loader": "2.3.0", "rimraf": "2.6.2", "sass-loader": "6.0.7", "style-loader": "0.20.3", "thread-loader": "1.1.5", "ts-jest": "22.4.2", - "ts-loader": "3.3.1", + "ts-loader": "4.1.0", "tslint": "5.9.1", "tslint-config-prettier": "1.10.0", "tslint-microsoft-contrib": "5.0.3", "tslint-react": "3.5.1", "types-rlp": "0.0.1", - "typescript": "2.6.2", - "url-loader": "1.0.1", + "typescript": "2.7.2", + "uglifyjs-webpack-plugin": "1.2.4", "url-search-params-polyfill": "3.0.0", - "webpack": "3.11.0", - "webpack-dev-middleware": "2.0.6", - "webpack-hot-middleware": "2.21.0", - "webpack-sources": "1.0.1", + "webpack": "4.2.0", + "webpack-cli": "2.0.13", + "webpack-dev-middleware": "3.1.0", + "webpack-hot-middleware": "2.21.2", + "webpack-sources": "1.1.0", "webpack-subresource-integrity": "1.1.0-rc.4", "what-input": "5.0.5", "worker-loader": "1.1.1" @@ -141,18 +133,14 @@ "freezer": "webpack --config=./webpack_config/webpack.freezer.js && node ./dist/freezer.js", "freezer:validate": "npm run freezer -- --validate", "db": "nodemon ./db", - "build": "webpack --config webpack_config/webpack.prod.js", + "build": "webpack --mode=production --config webpack_config/webpack.prod.js", "prebuild": "check-node-version --package", - "build:downloadable": "webpack --config webpack_config/webpack.html.js", + "build:downloadable": "webpack --mode=production --config webpack_config/webpack.html.js", "prebuild:downloadable": "check-node-version --package", - "build:electron": - "webpack --config webpack_config/webpack.electron-prod.js && node webpack_config/buildElectron.js", - "build:electron:osx": - "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=osx node webpack_config/buildElectron.js", - "build:electron:windows": - "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=windows node webpack_config/buildElectron.js", - "build:electron:linux": - "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=linux node webpack_config/buildElectron.js", + "build:electron": "webpack --config webpack_config/webpack.electron-prod.js && node webpack_config/buildElectron.js", + "build:electron:osx": "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=osx node webpack_config/buildElectron.js", + "build:electron:windows": "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=windows node webpack_config/buildElectron.js", + "build:electron:linux": "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=linux node webpack_config/buildElectron.js", "prebuild:electron": "check-node-version --package", "jenkins:build:linux": "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=JENKINS_LINUX node webpack_config/buildElectron.js", "jenkins:build:mac": "webpack --config webpack_config/webpack.electron-prod.js && ELECTRON_OS=JENKINS_MAC node webpack_config/buildElectron.js", @@ -167,18 +155,14 @@ "predev": "check-node-version --package", "dev:https": "HTTPS=true node webpack_config/devServer.js", "predev:https": "check-node-version --package", - "dev:electron": - "concurrently --kill-others --names 'webpack,electron' 'BUILD_ELECTRON=true node webpack_config/devServer.js' 'webpack --config webpack_config/webpack.electron-dev.js && electron dist/electron-js/main.js'", - "dev:electron:https": - "concurrently --kill-others --names 'webpack,electron' 'BUILD_ELECTRON=true HTTPS=true node webpack_config/devServer.js' 'HTTPS=true webpack --config webpack_config/webpack.electron-dev.js && electron dist/electron-js/main.js'", + "dev:electron": "concurrently --kill-others --names 'webpack,electron' 'BUILD_ELECTRON=true node webpack_config/devServer.js' 'webpack --config webpack_config/webpack.electron-dev.js && electron dist/electron-js/main.js'", + "dev:electron:https": "concurrently --kill-others --names 'webpack,electron' 'BUILD_ELECTRON=true HTTPS=true node webpack_config/devServer.js' 'HTTPS=true webpack --config webpack_config/webpack.electron-dev.js && electron dist/electron-js/main.js'", "tslint": "tslint --project . --exclude common/vendor/**/*", "tscheck": "tsc --noEmit", "start": "npm run dev", "precommit": "lint-staged", - "formatAll": - "find ./common/ -name '*.ts*' | xargs prettier --write --config ./.prettierrc --config-precedence file-override", - "prettier:diff": - "prettier --write --config ./.prettierrc --list-different \"common/**/*.ts\" \"common/**/*.tsx\"", + "formatAll": "find ./common/ -name '*.ts*' | xargs prettier --write --config ./.prettierrc --config-precedence file-override", + "prettier:diff": "prettier --write --config ./.prettierrc --list-different \"common/**/*.ts\" \"common/**/*.tsx\"", "prepush": "npm run tslint && npm run tscheck" }, "lint-staged": { diff --git a/spec/package.json.spec.ts b/spec/package.json.spec.ts index abd09a22..d3849073 100644 --- a/spec/package.json.spec.ts +++ b/spec/package.json.spec.ts @@ -1,11 +1,15 @@ import packageJSON from '../package.json'; +interface Dependencies { + [key: string]: string; +} + // from https://docs.npmjs.com/files/package.json#dependencies const nonExactPrefixes = ['~', '^', '>', '>=', '<', '<=']; describe('package.json', () => { it('dependencies should not contain any non-exact versions', () => { - const deps = Object.values(packageJSON.dependencies); + const deps = Object.values(packageJSON.dependencies as Dependencies); deps.forEach(depVersion => { nonExactPrefixes.forEach(badPrefix => { expect(depVersion.includes(badPrefix)).toBeFalsy(); @@ -13,7 +17,7 @@ describe('package.json', () => { }); }); it('devDependencies should not contain any non-exact versions', () => { - const deps = Object.values(packageJSON.devDependencies); + const deps = Object.values(packageJSON.devDependencies as Dependencies); deps.forEach(depVersion => { nonExactPrefixes.forEach(badPrefix => { expect(depVersion.includes(badPrefix)).toBeFalsy(); diff --git a/spec/reducers/config/nodes/selectedNode.spec.ts b/spec/reducers/config/nodes/selectedNode.spec.ts index 691c5604..db4c6835 100644 --- a/spec/reducers/config/nodes/selectedNode.spec.ts +++ b/spec/reducers/config/nodes/selectedNode.spec.ts @@ -1,5 +1,6 @@ import { changeNodeIntent, changeNode } from 'actions/config'; -import { State, selectedNode } from 'reducers/config/nodes/selectedNode'; +import { selectedNode } from 'reducers/config/nodes/selectedNode'; +import { SelectedNodeState } from 'reducers/config/nodes/types'; export const expectedState = { initialState: { nodeId: 'eth_mycrypto', pending: false }, @@ -20,9 +21,9 @@ describe('selected node reducer', () => { expect(selectedNode(undefined, actions.changeNode)).toEqual(expectedState.nodeChange)); it('should handle the intent to change a node', () => - expect(selectedNode(expectedState.initialState as State, actions.changeNodeIntent)).toEqual( - expectedState.nodeChangeIntent - )); + expect( + selectedNode(expectedState.initialState as SelectedNodeState, actions.changeNodeIntent) + ).toEqual(expectedState.nodeChangeIntent)); }); export { actions as selectedNodeActions, expectedState as selectedNodeExpectedState }; diff --git a/webpack_config/devServer.js b/webpack_config/devServer.js index e79ddd88..0868857f 100644 --- a/webpack_config/devServer.js +++ b/webpack_config/devServer.js @@ -45,7 +45,7 @@ const devMiddleWare = require('webpack-dev-middleware')(compiler, { app.use(devMiddleWare); app.use( require('webpack-hot-middleware')(compiler, { - log: console.info + log: false }) ); diff --git a/webpack_config/makeConfig.js b/webpack_config/makeConfig.js index 402e0cc1..250f6320 100644 --- a/webpack_config/makeConfig.js +++ b/webpack_config/makeConfig.js @@ -6,13 +6,12 @@ const threadLoader = require('thread-loader'); const HtmlWebpackPlugin = require('html-webpack-plugin'); const CopyWebpackPlugin = require('copy-webpack-plugin'); const FriendlyErrorsPlugin = require('friendly-errors-webpack-plugin'); -const AutoDllPlugin = require('autodll-webpack-plugin'); -const HardSourceWebpackPlugin = require('hard-source-webpack-plugin'); const FaviconsWebpackPlugin = require('favicons-webpack-plugin'); -const ExtractTextPlugin = require('extract-text-webpack-plugin'); +// const AutoDllPlugin = require('autodll-webpack-plugin'); +const HardSourceWebpackPlugin = require('hard-source-webpack-plugin'); const ProgressPlugin = require('webpack/lib/ProgressPlugin'); -const BabelMinifyPlugin = require('babel-minify-webpack-plugin'); const SriPlugin = require('webpack-subresource-integrity'); +const MiniCSSExtractPlugin = require('mini-css-extract-plugin'); const ClearDistPlugin = require('./plugins/clearDist'); const SortCachePlugin = require('./plugins/sortCache'); @@ -71,17 +70,18 @@ module.exports = function(opts = {}) { rules.push( { test: /\.css$/, - use: ExtractTextPlugin.extract({ - fallback: 'style-loader', - use: 'css-loader' - }) + use: [ + MiniCSSExtractPlugin.loader, + 'css-loader' + ] }, { test: /\.scss$/, - use: ExtractTextPlugin.extract({ - fallback: 'style-loader', - use: ['css-loader', 'sass-loader'] - }) + use: [ + MiniCSSExtractPlugin.loader, + 'css-loader', + 'sass-loader' + ] } ); } else { @@ -186,24 +186,9 @@ module.exports = function(opts = {}) { if (options.isProduction) { plugins.push( - new BabelMinifyPlugin( - { - // Mangle seems to be reusing variable identifiers, causing errors - mangle: false, - // These two on top of a lodash file are causing illegal characters for - // safari and ios browsers - evaluate: false, - propertyLiterals: false - }, - { - comments: false - } - ), - new webpack.optimize.CommonsChunkPlugin({ - name: 'vendor', - filename: 'vendor.[chunkhash:8].js' + new MiniCSSExtractPlugin({ + filename: '[name].[chunkhash:8].css' }), - new ExtractTextPlugin('[name].[chunkhash:8].css'), new FaviconsWebpackPlugin({ logo: path.resolve(config.path.assets, 'images/favicon.png'), background: '#163151', @@ -219,24 +204,23 @@ module.exports = function(opts = {}) { ); } else { plugins.push( - new AutoDllPlugin({ - inject: true, // will inject the DLL bundles to index.html - filename: '[name]_[hash].js', - debug: true, - context: path.join(config.path.root), - entry: { - vendor: [...config.vendorModules, 'babel-polyfill', 'bootstrap-sass', 'font-awesome'] - } - }), + // new AutoDllPlugin({ + // inject: true, // will inject the DLL bundles to index.html + // filename: '[name]_[hash].js', + // debug: true, + // context: path.join(config.path.root), + // entry: { + // vendor: [...config.vendorModules, 'babel-polyfill', 'bootstrap-sass', 'font-awesome'] + // } + // }), new HardSourceWebpackPlugin({ environmentHash: { root: process.cwd(), - directories: ['webpack_config'], + directories: ['common/webpack_config'], files: ['package.json'] } }), new webpack.HotModuleReplacementPlugin(), - new webpack.NoEmitOnErrorsPlugin(), new FriendlyErrorsPlugin() ); } @@ -261,6 +245,17 @@ module.exports = function(opts = {}) { ); } + // ==================== + // === Optimization === + // ==================== + const optimization = {}; + if (options.isProduction) { + optimization.splitChunks = { + chunks: 'all' + }; + optimization.concatenateModules = false; + } + // ==================== // ====== DevTool ===== // ==================== @@ -295,6 +290,8 @@ module.exports = function(opts = {}) { performance: { hints: options.isProduction ? 'warning' : false }, + optimization, + mode: options.isProduction ? 'production' : 'development', stats: { // Reduce build output children: false, diff --git a/webpack_config/plugins/serverLog.js b/webpack_config/plugins/serverLog.js index 767ee564..2d67fbd6 100644 --- a/webpack_config/plugins/serverLog.js +++ b/webpack_config/plugins/serverLog.js @@ -1,20 +1,19 @@ 'use strict'; const chalk = require('chalk'); -// this plugin if for loggin url after each time the compilation is done. -module.exports = class LogPlugin { - constructor(port) { - this.port = port; - } - - apply(compiler) { - const protocol = process.env.HTTPS ? 'https' : 'http'; - compiler.plugin('done', () => { - console.log( - `> App is running at ${chalk.yellow( - `${protocol}://localhost:${this.port}` - )}\n` - ); - }); - } +const LogPlugin = function(port) { + this.port = port; + this.protocol = process.env.HTTPS ? 'https' : 'http'; }; + +LogPlugin.prototype.apply = function(compiler) { + compiler.plugin('done', (compiler, done) => { + console.log( + `> App is running at ${chalk.yellow( + `${this.protocol}://localhost:${this.port}` + )}\n` + ); + }); +}; + +module.exports = LogPlugin; diff --git a/webpack_config/webpack.electron-dev.js b/webpack_config/webpack.electron-dev.js index bf96ef29..f0efb7b9 100644 --- a/webpack_config/webpack.electron-dev.js +++ b/webpack_config/webpack.electron-dev.js @@ -7,6 +7,7 @@ const makeConfig = require('./makeConfig'); const electronConfig = { target: 'electron-main', + mode: 'development', entry: { main: path.join(config.path.electron, 'main/index.ts') }, diff --git a/webpack_config/webpack.electron-prod.js b/webpack_config/webpack.electron-prod.js index c06d1d5a..a0343c6a 100644 --- a/webpack_config/webpack.electron-prod.js +++ b/webpack_config/webpack.electron-prod.js @@ -13,6 +13,8 @@ const jsConfig = makeConfig({ }); // Redefine plugins with prod specific stuff +electronConfig.mode = 'production'; + electronConfig.plugins = [ new ClearDistPlugin(), new webpack.DefinePlugin({ diff --git a/webpack_config/webpack.freezer.js b/webpack_config/webpack.freezer.js index 556aa51a..b58bd8b0 100644 --- a/webpack_config/webpack.freezer.js +++ b/webpack_config/webpack.freezer.js @@ -5,6 +5,7 @@ const config = require('./config'); const freezerConfig = { target: 'node', + mode: 'development', entry: './common/freezer', output: { path: config.path.output,