From b94bede473974ae680f90165f6d425bc573c7103 Mon Sep 17 00:00:00 2001
From: HenryNguyen5 <ngu.henry@hotmail.com>
Date: Wed, 18 Oct 2017 22:29:49 -0400
Subject: [PATCH] Add "No Unused Params and Locals" Linting Rule (#297)

Add "No Unused Params and Locals" Linting Rule
---
 common/actions/ens/actionTypes.ts             |  2 --
 common/actions/rates/actionCreators.ts        |  2 +-
 common/components/Footer/index.tsx            |  2 +-
 .../Header/components/Navigation.tsx          |  1 -
 .../DeterministicWalletsModal.tsx             | 23 ++++++++-----------
 common/components/WalletDecrypt/Mnemonic.tsx  | 11 ++++-----
 common/components/ui/Code.tsx                 |  2 +-
 common/components/ui/ColorDropdown.tsx        |  2 --
 common/components/ui/Dropdown.tsx             |  2 +-
 common/components/ui/Help.tsx                 |  1 -
 common/containers/Tabs/ENS/index.tsx          |  2 +-
 common/libs/erc20.ts                          |  2 +-
 common/libs/nodes/infura/client.ts            |  1 -
 common/libs/transaction.ts                    |  2 +-
 common/libs/wallet/trezor.ts                  |  2 +-
 common/reducers/config.ts                     | 12 ++++------
 common/reducers/rates.ts                      | 11 +++------
 common/sagas/config.ts                        |  6 +----
 common/sagas/swap/rates.ts                    |  2 +-
 common/utils/formatters.ts                    |  2 +-
 common/utils/localStorage.ts                  |  1 -
 tsconfig.json                                 |  4 +++-
 22 files changed, 37 insertions(+), 58 deletions(-)

diff --git a/common/actions/ens/actionTypes.ts b/common/actions/ens/actionTypes.ts
index 6489772a..d87a9445 100644
--- a/common/actions/ens/actionTypes.ts
+++ b/common/actions/ens/actionTypes.ts
@@ -1,5 +1,3 @@
-import * as constants from './constants';
-
 /*** Resolve ENS name ***/
 export interface ResolveEnsNameAction {
   type: 'ENS_RESOLVE';
diff --git a/common/actions/rates/actionCreators.ts b/common/actions/rates/actionCreators.ts
index 91ce5118..8725bf0b 100644
--- a/common/actions/rates/actionCreators.ts
+++ b/common/actions/rates/actionCreators.ts
@@ -1,6 +1,6 @@
 import * as interfaces from './actionTypes';
 import { TypeKeys } from './constants';
-import { fetchRates, CCResponse } from './actionPayloads';
+import { fetchRates } from './actionPayloads';
 
 export type TFetchCCRates = typeof fetchCCRates;
 export function fetchCCRates(): interfaces.FetchCCRates {
diff --git a/common/components/Footer/index.tsx b/common/components/Footer/index.tsx
index 4101dbbc..4c5ae0b7 100644
--- a/common/components/Footer/index.tsx
+++ b/common/components/Footer/index.tsx
@@ -1,6 +1,6 @@
 import logo from 'assets/images/logo-myetherwallet.svg';
 import { bityReferralURL, donationAddressMap } from 'config/data';
-import React, { Component } from 'react';
+import React from 'react';
 import translate from 'translations';
 import './index.scss';
 import PreFooter from './PreFooter';
diff --git a/common/components/Header/components/Navigation.tsx b/common/components/Header/components/Navigation.tsx
index 339b1cb5..dd230aa7 100644
--- a/common/components/Header/components/Navigation.tsx
+++ b/common/components/Header/components/Navigation.tsx
@@ -1,4 +1,3 @@
-import PropTypes from 'prop-types';
 import React, { Component } from 'react';
 import NavigationLink from './NavigationLink';
 
diff --git a/common/components/WalletDecrypt/DeterministicWalletsModal.tsx b/common/components/WalletDecrypt/DeterministicWalletsModal.tsx
index 40e953d1..d87e41c3 100644
--- a/common/components/WalletDecrypt/DeterministicWalletsModal.tsx
+++ b/common/components/WalletDecrypt/DeterministicWalletsModal.tsx
@@ -7,7 +7,7 @@ import {
   SetDesiredTokenAction
 } from 'actions/deterministicWallets';
 import Modal, { IButton } from 'components/ui/Modal';
-import { NetworkConfig, Token } from 'config/data';
+import { NetworkConfig } from 'config/data';
 import { isValidPath } from 'libs/validators';
 import React from 'react';
 import { connect } from 'react-redux';
@@ -123,20 +123,21 @@ class DeterministicWalletsModal extends React.Component<Props, State> {
               onChange={this.handleChangePath}
               value={isCustomPath ? 'custom' : dPath}
             >
-              {dPaths.map(dp =>
+              {dPaths.map(dp => (
                 <option key={dp.value} value={dp.value}>
                   {dp.label}
                 </option>
-              )}
+              ))}
               <option value="custom">Custom path...</option>
             </select>
-            {isCustomPath &&
+            {isCustomPath && (
               <input
                 className={`form-control ${validPathClass}`}
                 value={customPath}
                 placeholder="m/44'/60'/0'/0"
                 onChange={this.handleChangeCustomPath}
-              />}
+              />
+            )}
           </form>
 
           <div className="DWModal-addresses">
@@ -145,9 +146,7 @@ class DeterministicWalletsModal extends React.Component<Props, State> {
                 <tr>
                   <td>#</td>
                   <td>Address</td>
-                  <td>
-                    {network.unit}
-                  </td>
+                  <td>{network.unit}</td>
                   <td>
                     <select
                       className="DWModal-addresses-table-token"
@@ -155,11 +154,11 @@ class DeterministicWalletsModal extends React.Component<Props, State> {
                       onChange={this.handleChangeToken}
                     >
                       <option value="">-Token-</option>
-                      {tokens.map(t =>
+                      {tokens.map(t => (
                         <option key={t.symbol} value={t.symbol}>
                           {t.symbol}
                         </option>
-                      )}
+                      ))}
                     </select>
                   </td>
                   <td>More</td>
@@ -280,9 +279,7 @@ class DeterministicWalletsModal extends React.Component<Props, State> {
         key={wallet.address}
         onClick={this.selectAddress.bind(this, wallet.address, wallet.index)}
       >
-        <td>
-          {wallet.index + 1}
-        </td>
+        <td>{wallet.index + 1}</td>
         <td className="DWModal-addresses-table-address">
           <input
             type="radio"
diff --git a/common/components/WalletDecrypt/Mnemonic.tsx b/common/components/WalletDecrypt/Mnemonic.tsx
index c170d0dd..060e09fc 100644
--- a/common/components/WalletDecrypt/Mnemonic.tsx
+++ b/common/components/WalletDecrypt/Mnemonic.tsx
@@ -31,9 +31,7 @@ export default class MnemonicDecrypt extends Component<Props, State> {
     return (
       <section className="col-md-4 col-sm-6">
         <div id="selectedTypeKey">
-          <h4>
-            {translate('ADD_Radio_5')}
-          </h4>
+          <h4>{translate('ADD_Radio_5')}</h4>
           <div className="form-group">
             <textarea
               id="aria-private-key"
@@ -56,7 +54,7 @@ export default class MnemonicDecrypt extends Component<Props, State> {
               type="password"
             />
           </div>
-          {isValidMnemonic &&
+          {isValidMnemonic && (
             <div className="form-group">
               <button
                 style={{ width: '100%' }}
@@ -65,7 +63,8 @@ export default class MnemonicDecrypt extends Component<Props, State> {
               >
                 {translate('Choose Address')}
               </button>
-            </div>}
+            </div>
+          )}
         </div>
 
         <DeterministicWalletsModal
@@ -90,7 +89,7 @@ export default class MnemonicDecrypt extends Component<Props, State> {
     this.setState({ phrase: (e.target as HTMLTextAreaElement).value });
   };
 
-  public onDWModalOpen = (e: React.SyntheticEvent<HTMLButtonElement>) => {
+  public onDWModalOpen = () => {
     const { phrase, pass } = this.state;
 
     if (!validateMnemonic(phrase)) {
diff --git a/common/components/ui/Code.tsx b/common/components/ui/Code.tsx
index 41f1dfae..179cb16d 100644
--- a/common/components/ui/Code.tsx
+++ b/common/components/ui/Code.tsx
@@ -1,4 +1,4 @@
-import React, { Component } from 'react';
+import React from 'react';
 import './Code.scss';
 
 const Code = ({ children }) => (
diff --git a/common/components/ui/ColorDropdown.tsx b/common/components/ui/ColorDropdown.tsx
index 161d5e43..7384827b 100644
--- a/common/components/ui/ColorDropdown.tsx
+++ b/common/components/ui/ColorDropdown.tsx
@@ -52,8 +52,6 @@ export default class ColorDropdown<T> extends Component<Props<T>, {}> {
   private renderOptions = () => {
     const { options, value, menuAlign, extra } = this.props;
 
-    const activeOption = this.getActiveOption();
-
     const listItems = options.reduce((prev: any[], opt) => {
       const prevOpt = prev.length ? prev[prev.length - 1] : null;
       if (prevOpt && !prevOpt.divider && prevOpt.color !== opt.color) {
diff --git a/common/components/ui/Dropdown.tsx b/common/components/ui/Dropdown.tsx
index 8fb664dd..79271cd2 100644
--- a/common/components/ui/Dropdown.tsx
+++ b/common/components/ui/Dropdown.tsx
@@ -34,7 +34,7 @@ export default class DropdownComponent<T> extends Component<Props<T>, {}> {
   }
 
   private renderLabel = () => {
-    const { label, value } = this.props;
+    const { value } = this.props;
     const labelStr = this.props.label ? `${this.props.label}:` : '';
     return (
       <span>
diff --git a/common/components/ui/Help.tsx b/common/components/ui/Help.tsx
index 5106fae9..e7132d06 100644
--- a/common/components/ui/Help.tsx
+++ b/common/components/ui/Help.tsx
@@ -1,6 +1,5 @@
 import React from 'react';
 import helpIcon from 'assets/images/icon-help.svg';
-import translate, { translateRaw } from 'translations';
 
 type sizeType = 'small' | 'medium' | 'large';
 
diff --git a/common/containers/Tabs/ENS/index.tsx b/common/containers/Tabs/ENS/index.tsx
index e0f9f603..22c396bf 100644
--- a/common/containers/Tabs/ENS/index.tsx
+++ b/common/containers/Tabs/ENS/index.tsx
@@ -1,6 +1,6 @@
 import { connect } from 'react-redux';
 import ENS from './components/ENS';
 
-const mapStateToProps = state => ({});
+const mapStateToProps = _ => ({});
 
 export default connect(mapStateToProps)(ENS);
diff --git a/common/libs/erc20.ts b/common/libs/erc20.ts
index 4a4b9bf9..4b36f9b7 100644
--- a/common/libs/erc20.ts
+++ b/common/libs/erc20.ts
@@ -1,4 +1,4 @@
-import Big, {BigNumber} from 'bignumber.js';
+import { BigNumber } from 'bignumber.js';
 import { toChecksumAddress } from 'ethereumjs-util';
 import Contract, { ABI } from 'libs/contract';
 
diff --git a/common/libs/nodes/infura/client.ts b/common/libs/nodes/infura/client.ts
index 2b639117..536173e3 100644
--- a/common/libs/nodes/infura/client.ts
+++ b/common/libs/nodes/infura/client.ts
@@ -1,4 +1,3 @@
-import Big from 'bignumber.js';
 import { randomBytes } from 'crypto';
 import RPCClient from '../rpc/client';
 
diff --git a/common/libs/transaction.ts b/common/libs/transaction.ts
index 82998c67..d6e1cdc8 100644
--- a/common/libs/transaction.ts
+++ b/common/libs/transaction.ts
@@ -9,7 +9,7 @@ import { Ether, toTokenUnit, UnitKey, Wei } from 'libs/units';
 import { isValidETHAddress } from 'libs/validators';
 import { stripHexPrefixAndLower, valueToHex } from 'libs/values';
 import { IWallet } from 'libs/wallet';
-import translate, { translateRaw } from 'translations';
+import { translateRaw } from 'translations';
 import Big, { BigNumber } from 'bignumber.js';
 
 export interface TransactionInput {
diff --git a/common/libs/wallet/trezor.ts b/common/libs/wallet/trezor.ts
index e10ae117..5d7ec16c 100644
--- a/common/libs/wallet/trezor.ts
+++ b/common/libs/wallet/trezor.ts
@@ -1,4 +1,4 @@
-import Big, { BigNumber } from 'bignumber.js';
+import Big from 'bignumber.js';
 import EthTx from 'ethereumjs-tx';
 import { addHexPrefix } from 'ethereumjs-util';
 import { RawTransaction } from 'libs/transaction';
diff --git a/common/reducers/config.ts b/common/reducers/config.ts
index 811ce9da..19c9dbf1 100644
--- a/common/reducers/config.ts
+++ b/common/reducers/config.ts
@@ -2,9 +2,7 @@ import {
   ChangeGasPriceAction,
   ChangeLanguageAction,
   ChangeNodeAction,
-  ConfigAction,
-  ToggleOfflineAction,
-  ForceOfflineAction
+  ConfigAction
 } from 'actions/config';
 import { TypeKeys } from 'actions/config/constants';
 import { NODES } from '../config/data';
@@ -47,14 +45,14 @@ function changeGasPrice(state: State, action: ChangeGasPriceAction): State {
   };
 }
 
-function toggleOffline(state: State, action: ToggleOfflineAction): State {
+function toggleOffline(state: State): State {
   return {
     ...state,
     offline: !state.offline
   };
 }
 
-function forceOffline(state: State, action: ForceOfflineAction): State {
+function forceOffline(state: State): State {
   return {
     ...state,
     forceOffline: !state.forceOffline
@@ -73,9 +71,9 @@ export function config(
     case TypeKeys.CONFIG_GAS_PRICE:
       return changeGasPrice(state, action);
     case TypeKeys.CONFIG_TOGGLE_OFFLINE:
-      return toggleOffline(state, action);
+      return toggleOffline(state);
     case TypeKeys.CONFIG_FORCE_OFFLINE:
-      return forceOffline(state, action);
+      return forceOffline(state);
     default:
       return state;
   }
diff --git a/common/reducers/rates.ts b/common/reducers/rates.ts
index 6fbfd18b..5d0cb9fc 100644
--- a/common/reducers/rates.ts
+++ b/common/reducers/rates.ts
@@ -1,9 +1,4 @@
-import {
-  FetchCCRatesSucceeded,
-  FetchCCRatesFailed,
-  RatesAction,
-  CCResponse
-} from 'actions/rates';
+import { FetchCCRatesSucceeded, RatesAction, CCResponse } from 'actions/rates';
 import { TypeKeys } from 'actions/rates/constants';
 import { Optional } from 'utils/types';
 
@@ -22,7 +17,7 @@ function fetchCCRatesSucceeded(
   return { ...state, rates: action.payload };
 }
 
-function fetchCCRatesFailed(state: State, action: FetchCCRatesFailed): State {
+function fetchCCRatesFailed(state: State): State {
   // TODO: Make library for error messages
   return {
     ...state,
@@ -38,7 +33,7 @@ export function rates(
     case TypeKeys.RATES_FETCH_CC_SUCCEEDED:
       return fetchCCRatesSucceeded(state, action);
     case TypeKeys.RATES_FETCH_CC_FAILED:
-      return fetchCCRatesFailed(state, action);
+      return fetchCCRatesFailed(state);
     default:
       return state;
   }
diff --git a/common/sagas/config.ts b/common/sagas/config.ts
index 4172d8eb..6a64c3dd 100644
--- a/common/sagas/config.ts
+++ b/common/sagas/config.ts
@@ -13,11 +13,7 @@ import { NODES } from 'config/data';
 import { getNodeConfig } from 'selectors/config';
 import { AppState } from 'reducers';
 import { TypeKeys } from 'actions/config/constants';
-import {
-  toggleOfflineConfig,
-  TToggleOfflineConfig,
-  changeNode
-} from 'actions/config';
+import { toggleOfflineConfig, changeNode } from 'actions/config';
 import { State as ConfigState } from 'reducers/config';
 
 export const getConfig = (state: AppState): ConfigState => state.config;
diff --git a/common/sagas/swap/rates.ts b/common/sagas/swap/rates.ts
index 3a135f8d..1f31720e 100644
--- a/common/sagas/swap/rates.ts
+++ b/common/sagas/swap/rates.ts
@@ -4,7 +4,7 @@ import { getAllRates } from 'api/bity';
 import { delay, SagaIterator } from 'redux-saga';
 import { call, cancel, fork, put, take, takeLatest } from 'redux-saga/effects';
 
-export function* loadBityRates(action?: any): SagaIterator {
+export function* loadBityRates(): SagaIterator {
   while (true) {
     try {
       const data = yield call(getAllRates);
diff --git a/common/utils/formatters.ts b/common/utils/formatters.ts
index ee57d21b..f728c25d 100644
--- a/common/utils/formatters.ts
+++ b/common/utils/formatters.ts
@@ -1,4 +1,4 @@
-import Big, { BigNumber } from 'bignumber.js';
+import { BigNumber } from 'bignumber.js';
 
 export function toFixedIfLarger(num: number, fixedSize: number = 6): string {
   return parseFloat(num.toFixed(fixedSize)).toString();
diff --git a/common/utils/localStorage.ts b/common/utils/localStorage.ts
index d373f1af..ce49f9e3 100644
--- a/common/utils/localStorage.ts
+++ b/common/utils/localStorage.ts
@@ -1,5 +1,4 @@
 export const REDUX_STATE = 'REDUX_STATE';
-import { State as CustomTokenState } from 'reducers/customTokens';
 import { State as SwapState } from 'reducers/swap';
 
 export function loadState<T>(): T | undefined {
diff --git a/tsconfig.json b/tsconfig.json
index c3dc0955..f3c77572 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -11,7 +11,9 @@
     "lib": ["es2017", "dom"],
     "allowSyntheticDefaultImports": true,
     "moduleResolution": "node",
-    "noEmitOnError": false
+    "noEmitOnError": false,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true
   },
   "include": [
     "./common/",